Fix remove while iterating in suppress_netgroup_memberof.

https://fedorahosted.org/freeipa/ticket/3464

ipalib/plugins/host.py

@@ -364,7 +364,7 @@ class host(LDAPObject):
         """
         ng_container = DN(api.env.container_netgroup, api.env.basedn)
         if 'memberofindirect' in entry_attrs:
-            for member in entry_attrs['memberofindirect']:
+            for member in list(entry_attrs['memberofindirect']):
                 memberdn = DN(member)
                 if memberdn.endswith(ng_container):
                     try:

ipalib/plugins/hostgroup.py

@@ -99,7 +99,7 @@ class hostgroup(LDAPObject):
         """
         if 'memberof' in entry_attrs:
             hgdn = DN(dn)
-            for member in entry_attrs['memberof']:
+            for member in list(entry_attrs['memberof']):
                 ngdn = DN(member)
                 if ngdn['cn'] == hgdn['cn']:
                     try:

tests/test_xmlrpc/test_nesting.py

@@ -790,7 +790,6 @@ class test_nesting(Declarative):
                     managedby_host=[fqdn1],
                     memberof_hostgroup = [u'testhostgroup2'],
                     memberofindirect_hostgroup = [u'testhostgroup1'],
-                    memberofindirect_netgroup = [u'testhostgroup2'],
                 ),
             ),
         ),