IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

pwd-plugin: Fix ignored return error

Browse Source 
CoverityID: 11904

Also remove 'inline', the compiler can do it on its own if needed.

Fixes:
https://fedorahosted.org/freeipa/ticket/3882
This commit is contained in:
Simo Sorce
2013-08-27 09:15:21 -04:00
committed by Petr Viktorin
parent 3c9261699a
commit b29ce20705
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
daemons/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
View File

@@ -1220,11 +1220,12 @@ Slapi_Filter *ipapwd_string2filter(char *strfilter)
} }
/* Loads the OTP config entry, parses it, and applies it. */ /* Loads the OTP config entry, parses it, and applies it. */
static inline bool ipapwd_load_otp_config(void) static bool ipapwd_load_otp_config(void)
{ {
char *config_attrs[] = { IPA_USER_AUTH_TYPE, NULL }; char *config_attrs[] = { IPA_USER_AUTH_TYPE, NULL };
Slapi_Entry *config_entry = NULL; Slapi_Entry *config_entry = NULL;
Slapi_DN *config_sdn = NULL; Slapi_DN *config_sdn = NULL;
int ret;
/* If we are using an alternate config area, check it for our /* If we are using an alternate config area, check it for our
* configuration, otherwise we just use our main plug-in config * configuration, otherwise we just use our main plug-in config
@@ -1238,8 +1239,12 @@ static inline bool ipapwd_load_otp_config(void)
config_sdn ? slapi_sdn_get_ndn(config_sdn) : "null"); config_sdn ? slapi_sdn_get_ndn(config_sdn) : "null");
/* Fetch the config entry. */ /* Fetch the config entry. */
slapi_search_internal_get_entry(config_sdn, config_attrs, &config_entry, ret = slapi_search_internal_get_entry(config_sdn, config_attrs,
ipapwd_plugin_id); &config_entry, ipapwd_plugin_id);
if (ret != LDAP_SUCCESS) {
LOG_TRACE("Search for OTP config failed, err (%d)\n", ret);
/* fall through, defaults will be set */
}
/* Parse and apply the config. */ /* Parse and apply the config. */
ipapwd_parse_otp_config_entry(config_entry, true); ipapwd_parse_otp_config_entry(config_entry, true);