Add check for IP addresses into DNS installer

https://fedorahosted.org/freeipa/ticket/5814

Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Martin Basti 2016-09-13 17:52:07 +02:00 committed by David Kupka
parent b7fcbe9a59
commit bb2c1790ea
3 changed files with 12 additions and 6 deletions

View File

@ -260,6 +260,9 @@ def install_check(standalone, api, replica, options, hostname):
ip_addresses = get_server_ip_address(hostname, options.unattended,
True, options.ip_addresses)
util.network_ip_address_warning(ip_addresses)
util.broadcast_ip_address_warning(ip_addresses)
if not options.forward_policy:
# user did not specify policy, derive it: default is 'first' but
# if any of local IP addresses belongs to private ranges use 'only'

View File

@ -613,8 +613,9 @@ def install_check(installer):
not installer.interactive, False,
options.ip_addresses)
network_ip_address_warning(ip_addresses)
broadcast_ip_address_warning(ip_addresses)
# check addresses here, dns module is doing own check
network_ip_address_warning(ip_addresses)
broadcast_ip_address_warning(ip_addresses)
# installer needs to update hosts file when DNS subsystem will be
# installed or custom addresses are used

View File

@ -739,8 +739,9 @@ def install_check(installer):
config.host_name, not installer.interactive, False,
options.ip_addresses)
network_ip_address_warning(config.ips)
broadcast_ip_address_warning(config.ips)
# check addresses here, dns module is doing own check
network_ip_address_warning(config.ips)
broadcast_ip_address_warning(config.ips)
except errors.ACIError:
raise ScriptError("\nThe password provided is incorrect for LDAP server "
@ -1314,8 +1315,9 @@ def promote_check(installer):
config.host_name, not installer.interactive,
False, options.ip_addresses)
network_ip_address_warning(config.ips)
broadcast_ip_address_warning(config.ips)
# check addresses here, dns module is doing own check
network_ip_address_warning(config.ips)
broadcast_ip_address_warning(config.ips)
except errors.ACIError:
raise ScriptError("\nInsufficient privileges to promote the server.")