IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2024-12-25 08:21:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

Increase replication changelog trimming to 30 days

Browse Source 
A long time ago the DS team recommended that the changelog trimming interval be set to 7 days.  However, more recently we tend to see more time skews on certain platforms, and issues where it appears changes were trimmed too early (which can break replication).

It would be better to set the trimming interval to 30 days.  This still prevents the changelog from getting too large, and it should help with some of the other issues we are now seeing.

Fixes: https://pagure.io/freeipa/issue/8464

Signed-off-by: Mark Reynolds <mreynolds@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
This commit is contained in:
Mark Reynolds 2020-08-17 09:28:26 -04:00 committed by Rob Crittenden
parent 454e023ad8
commit c08c7e1156
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ipaserver/install/plugins/update_changelog_maxage.py
View File

@ -20,7 +20,7 @@ class update_changelog_maxage(Updater):
def update_entry(self, cl_entry, conn): def update_entry(self, cl_entry, conn):
maxage = cl_entry.single_value.get('nsslapd-changelogmaxage') maxage = cl_entry.single_value.get('nsslapd-changelogmaxage')
if maxage is None: if maxage is None:
cl_entry['nsslapd-changelogmaxage'] = '7d' cl_entry['nsslapd-changelogmaxage'] = '30d'
conn.update_entry(cl_entry) conn.update_entry(cl_entry)
def execute(self, **options): def execute(self, **options):

4
ipaserver/install/replication.py
View File

@ -609,7 +609,7 @@ class ReplicationManager:
'objectclass': ["top", "extensibleobject"], 'objectclass': ["top", "extensibleobject"],
'cn': ["changelog5"], 'cn': ["changelog5"],
'nsslapd-changelogdir': [os.path.join(dbdir, "cldb")], 'nsslapd-changelogdir': [os.path.join(dbdir, "cldb")],
'nsslapd-changelogmaxage': ['7d'], 'nsslapd-changelogmaxage': ['30d'],
} }
) )
try: try:
@ -618,7 +618,7 @@ class ReplicationManager:
return return
else: else:
# Set the changelog trimming # Set the changelog trimming
cl_entry['nsslapd-changelogmaxage'] = '7d' cl_entry['nsslapd-changelogmaxage'] = '30d'
try: try:
conn.update_entry(cl_entry) conn.update_entry(cl_entry)
except errors.EmptyModlist: except errors.EmptyModlist: