IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipa-kdb: fix memleaks in ipa_kdb_mspac.c

Browse Source
This commit is contained in:
Simo Sorce
2011-11-20 20:50:11 -05:00
parent 64dfa1b37e
commit c3dc08b93f
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
daemons/ipa-kdb/ipa_kdb_mspac.c
View File

@@ -466,7 +466,7 @@ static krb5_error_code ipadb_get_pac(krb5_context kcontext,
TALLOC_CTX *tmpctx; TALLOC_CTX *tmpctx;
struct ipadb_e_data *ied; struct ipadb_e_data *ied;
struct ipadb_context *ipactx; struct ipadb_context *ipactx;
LDAPMessage *results; LDAPMessage *results = NULL;
LDAPMessage *lentry; LDAPMessage *lentry;
DATA_BLOB pac_data; DATA_BLOB pac_data;
krb5_data data; krb5_data data;
@@ -479,11 +479,6 @@ static krb5_error_code ipadb_get_pac(krb5_context kcontext,
return KRB5_KDB_DBNOTINITED; return KRB5_KDB_DBNOTINITED;
} }
tmpctx = talloc_new(NULL);
if (!tmpctx) {
return ENOMEM;
}
ied = (struct ipadb_e_data *)client->e_data; ied = (struct ipadb_e_data *)client->e_data;
if (ied->magic != IPA_E_DATA_MAGIC) { if (ied->magic != IPA_E_DATA_MAGIC) {
return EINVAL; return EINVAL;
@@ -493,9 +488,14 @@ static krb5_error_code ipadb_get_pac(krb5_context kcontext,
return 0; return 0;
} }
tmpctx = talloc_new(NULL);
if (!tmpctx) {
return ENOMEM;
}
memset(&pac_info, 0, sizeof(pac_info)); memset(&pac_info, 0, sizeof(pac_info));
pac_info.logon_info.info = talloc_zero(tmpctx, struct PAC_LOGON_INFO); pac_info.logon_info.info = talloc_zero(tmpctx, struct PAC_LOGON_INFO);
if (!tmpctx) { if (!pac_info.logon_info.info) {
kerr = ENOMEM; kerr = ENOMEM;
goto done; goto done;
} }
@@ -542,6 +542,7 @@ static krb5_error_code ipadb_get_pac(krb5_context kcontext,
kerr = krb5_pac_add_buffer(kcontext, *pac, KRB5_PAC_LOGON_INFO, &data); kerr = krb5_pac_add_buffer(kcontext, *pac, KRB5_PAC_LOGON_INFO, &data);
done: done:
ldap_msgfree(results);
talloc_free(tmpctx); talloc_free(tmpctx);
return kerr; return kerr;
} }