IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

pylint3: workaround false positives reported for W1662

Browse Source 
Pylint3 falsely reports warning W1662: using a variable that was bound
inside a comprehension for the cases where the same name is reused for a
loop after the comprehension in question.

Rename the variable in a loop to avoid it.

If the code looks like the following:

  arr = [f for f in filters if callable(f)]
  for f in arr:
      result = result + f()

pylint3 would consider 'f' used outside of comprehension. Clearly, this
is a false-positive warning as the second 'f' use is completely
independent of the comprehension's use of 'f'.

Reviewed-By: Aleksei Slaikovskii <aslaikov@redhat.com>
This commit is contained in:
Alexander Bokovoy 2018-05-17 17:49:27 +03:00 committed by Rob Crittenden
parent a0eaa74234
commit c61151f6aa
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ipaclient/csrgen.py
View File

@ -144,8 +144,8 @@ class Formatter(object):
for rule in field_mapping.data_rules] for rule in field_mapping.data_rules]
data_sources = [] data_sources = []
for rule in field_mapping.data_rules: for xrule in field_mapping.data_rules:
data_source = rule.options.get('data_source') data_source = xrule.options.get('data_source')
if data_source: if data_source:
data_sources.append(data_source) data_sources.append(data_source)

2
ipalib/plugable.py
View File

@ -638,7 +638,7 @@ class API(ReadOnly):
logger.debug("importing all plugin modules in %s...", package_name) logger.debug("importing all plugin modules in %s...", package_name)
modules = getattr(package, 'modules', find_modules_in_dir(package_dir)) modules = getattr(package, 'modules', find_modules_in_dir(package_dir))
modules = ['.'.join((package_name, name)) for name in modules] modules = ['.'.join((package_name, mname)) for mname in modules]
for name in modules: for name in modules:
logger.debug("importing plugin module %s", name) logger.debug("importing plugin module %s", name)

2
ipapython/ipaldap.py
View File

@ -1226,7 +1226,7 @@ class LDAPClient(object):
assert isinstance(filters, (list, tuple)) assert isinstance(filters, (list, tuple))
filters = [f for f in filters if f] filters = [fx for fx in filters if fx]
if filters and rules == cls.MATCH_NONE: # unary operator if filters and rules == cls.MATCH_NONE: # unary operator
return '(%s%s)' % (cls.MATCH_NONE, return '(%s%s)' % (cls.MATCH_NONE,
cls.combine_filters(filters, cls.MATCH_ANY)) cls.combine_filters(filters, cls.MATCH_ANY))

2
ipapython/ipautil.py
View File

@ -496,7 +496,7 @@ def run(args, stdin=None, raiseonerr=True, nolog=(), env=None,
pent = pwd.getpwnam(runas) pent = pwd.getpwnam(runas)
suplementary_gids = [ suplementary_gids = [
grp.getgrnam(group).gr_gid for group in suplementary_groups grp.getgrnam(sgroup).gr_gid for sgroup in suplementary_groups
] ]
logger.debug('runas=%s (UID %d, GID %s)', runas, logger.debug('runas=%s (UID %d, GID %s)', runas,