mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-02-25 18:55:28 -06:00
Fix errors found by Pylint-2.4.3
New Pylint (2.4.3) catches several new 'true problems'. At the same time, it warns about things that are massively and reasonably employed in FreeIPA. list of fixed: - no-else-continue - redeclared-assigned-name - no-else-break - unnecessary-comprehension - using-constant-test (false positive) list of ignored (responsibility of contributors and reviewers): - import-outside-toplevel Fixes: https://pagure.io/freeipa/issue/8102 Signed-off-by: Stanislav Levin <slev@altlinux.org> Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
This commit is contained in:
committed by
Fraser Tweedale
parent
f44b73b97c
commit
c6769ad12f
@@ -495,7 +495,7 @@ class config_mod(LDAPUpdate):
|
||||
for field in entry_attrs[k].split(',')]
|
||||
# test if all base types (without sub-types) are allowed
|
||||
for a in attributes:
|
||||
a, _dummy, _dummy = a.partition(';')
|
||||
a, _unused1, _unused2 = a.partition(';')
|
||||
if a not in allowed_attrs:
|
||||
raise errors.ValidationError(
|
||||
name=k, error=_('attribute "%s" not allowed') % a
|
||||
@@ -527,7 +527,7 @@ class config_mod(LDAPUpdate):
|
||||
if self.api.Object[obj].uuid_attribute:
|
||||
checked_attrs = checked_attrs + [self.api.Object[obj].uuid_attribute]
|
||||
for obj_attr in checked_attrs:
|
||||
obj_attr, _dummy, _dummy = obj_attr.partition(';')
|
||||
obj_attr, _unused1, _unused2 = obj_attr.partition(';')
|
||||
if obj_attr in OPERATIONAL_ATTRIBUTES:
|
||||
continue
|
||||
if obj_attr in self.api.Object[obj].params and \
|
||||
|
||||
Reference in New Issue
Block a user