From c898be1df926bd134ac4d7cd86d10a00ff5cd2ae Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Mon, 23 Sep 2019 18:30:22 -0300
Subject: [PATCH] Removes several pylint warnings.

This patche removes 93 pylint deprecation warnings due to invalid escape
sequences (mostly 'invalid escape sequence \d') on unicode strings.

Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
---
 ipaclient/remote_plugins/2_114/automember.py  |  2 +-
 ipaclient/remote_plugins/2_114/group.py       |  2 +-
 ipaclient/remote_plugins/2_114/hbactest.py    |  2 +-
 ipaclient/remote_plugins/2_114/trust.py       |  2 +-
 ipaclient/remote_plugins/2_156/automember.py  |  2 +-
 ipaclient/remote_plugins/2_156/group.py       |  2 +-
 ipaclient/remote_plugins/2_156/hbactest.py    |  2 +-
 ipaclient/remote_plugins/2_156/trust.py       |  2 +-
 ipaclient/remote_plugins/compat.py            | 10 +++--
 ipalib/plugable.py                            |  6 ++-
 ipapython/certdb.py                           |  2 +-
 ipapython/dn.py                               |  2 +-
 ipapython/ipautil.py                          |  6 +--
 ipaserver/dcerpc.py                           | 16 ++++----
 ipaserver/dns_data_management.py              | 40 +++++++++----------
 ipaserver/install/adtrustinstance.py          |  3 +-
 ipaserver/install/bindinstance.py             |  4 +-
 ipaserver/install/dsinstance.py               |  2 +-
 ipaserver/install/server/upgrade.py           |  4 +-
 ipaserver/plugins/automember.py               |  6 +--
 ipaserver/plugins/baseldap.py                 |  4 +-
 ipaserver/plugins/dns.py                      |  2 +-
 ipaserver/plugins/hbactest.py                 |  2 +-
 ipaserver/plugins/host.py                     |  2 +-
 ipaserver/plugins/permission.py               |  2 +-
 ipatests/pytest_ipa/integration/__init__.py   |  6 +--
 .../test_backup_and_restore.py                |  2 +-
 ipatests/test_integration/test_external_ca.py |  2 +-
 .../test_integration/test_legacy_clients.py   | 12 +++---
 ipatests/test_integration/test_topology.py    |  4 +-
 ipatests/test_xmlrpc/test_external_members.py |  4 +-
 ipatests/util.py                              |  2 +-
 32 files changed, 84 insertions(+), 77 deletions(-)

diff --git a/ipaclient/remote_plugins/2_114/automember.py b/ipaclient/remote_plugins/2_114/automember.py
index 09b5a8d01..f6b941d64 100644
--- a/ipaclient/remote_plugins/2_114/automember.py
+++ b/ipaclient/remote_plugins/2_114/automember.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Auto Membership Rule.
 
 Bring clarity to the membership of hosts and users by configuring inclusive
diff --git a/ipaclient/remote_plugins/2_114/group.py b/ipaclient/remote_plugins/2_114/group.py
index 86d8f7d4a..5bf4a8580 100644
--- a/ipaclient/remote_plugins/2_114/group.py
+++ b/ipaclient/remote_plugins/2_114/group.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Groups of users
 
 Manage groups of users. By default, new groups are POSIX groups. You
diff --git a/ipaclient/remote_plugins/2_114/hbactest.py b/ipaclient/remote_plugins/2_114/hbactest.py
index b0c49b71b..4b168f3d9 100644
--- a/ipaclient/remote_plugins/2_114/hbactest.py
+++ b/ipaclient/remote_plugins/2_114/hbactest.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Simulate use of Host-based access controls
 
 HBAC rules control who can access what services on what hosts.
diff --git a/ipaclient/remote_plugins/2_114/trust.py b/ipaclient/remote_plugins/2_114/trust.py
index 69226663a..4c26599dc 100644
--- a/ipaclient/remote_plugins/2_114/trust.py
+++ b/ipaclient/remote_plugins/2_114/trust.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Cross-realm trusts
 
 Manage trust relationship between IPA and Active Directory domains.
diff --git a/ipaclient/remote_plugins/2_156/automember.py b/ipaclient/remote_plugins/2_156/automember.py
index 09b5a8d01..f6b941d64 100644
--- a/ipaclient/remote_plugins/2_156/automember.py
+++ b/ipaclient/remote_plugins/2_156/automember.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Auto Membership Rule.
 
 Bring clarity to the membership of hosts and users by configuring inclusive
diff --git a/ipaclient/remote_plugins/2_156/group.py b/ipaclient/remote_plugins/2_156/group.py
index ed57c4caa..e18003ecb 100644
--- a/ipaclient/remote_plugins/2_156/group.py
+++ b/ipaclient/remote_plugins/2_156/group.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Groups of users
 
 Manage groups of users. By default, new groups are POSIX groups. You
diff --git a/ipaclient/remote_plugins/2_156/hbactest.py b/ipaclient/remote_plugins/2_156/hbactest.py
index b0c49b71b..4b168f3d9 100644
--- a/ipaclient/remote_plugins/2_156/hbactest.py
+++ b/ipaclient/remote_plugins/2_156/hbactest.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Simulate use of Host-based access controls
 
 HBAC rules control who can access what services on what hosts.
diff --git a/ipaclient/remote_plugins/2_156/trust.py b/ipaclient/remote_plugins/2_156/trust.py
index 39a563831..c5c8f60e6 100644
--- a/ipaclient/remote_plugins/2_156/trust.py
+++ b/ipaclient/remote_plugins/2_156/trust.py
@@ -16,7 +16,7 @@ from ipapython.dnsutil import DNSName
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Cross-realm trusts
 
 Manage trust relationship between IPA and Active Directory domains.
diff --git a/ipaclient/remote_plugins/compat.py b/ipaclient/remote_plugins/compat.py
index c1ae63539..2a600fccc 100644
--- a/ipaclient/remote_plugins/compat.py
+++ b/ipaclient/remote_plugins/compat.py
@@ -2,6 +2,8 @@
 # Copyright (C) 2016  FreeIPA Contributors see COPYING for license
 #
 
+from __future__ import unicode_literals
+
 import importlib
 import os
 import re
@@ -42,19 +44,19 @@ def get_package(server_info, client):
     if not is_valid:
         if not client.isconnected():
             client.connect(verbose=False)
-        env = client.forward(u'env', u'api_version', version=u'2.0')
+        env = client.forward('env', 'api_version', version='2.0')
         try:
             server_version = env['result']['api_version']
         except KeyError:
-            ping = client.forward(u'ping', version=u'2.0')
+            ping = client.forward('ping', version='2.0')
             try:
-                match = re.search(u'API version (2\.[0-9]+)', ping['summary'])
+                match = re.search(r'API version (2\.[0-9]+)', ping['summary'])
             except KeyError:
                 match = None
             if match is not None:
                 server_version = match.group(1)
             else:
-                server_version = u'2.0'
+                server_version = '2.0'
         server_info['version'] = server_version
         server_info.update_validity()
 
diff --git a/ipalib/plugable.py b/ipalib/plugable.py
index 084ee5f91..f0204a151 100644
--- a/ipalib/plugable.py
+++ b/ipalib/plugable.py
@@ -24,6 +24,8 @@ The classes in this module make heavy use of Python container emulation. If
 you are unfamiliar with this Python feature, see
 http://docs.python.org/ref/sequence-types.html
 """
+from __future__ import unicode_literals
+
 import logging
 import operator
 import re
@@ -173,7 +175,7 @@ class Plugin(ReadOnly):
     def __summary_getter(cls):
         doc = cls.doc
         if not _(doc).msg:
-            return u'<%s.%s>' % (cls.__module__, cls.__name__)
+            return '<%s.%s>' % (cls.__module__, cls.__name__)
         else:
             return unicode(doc).split('\n\n', 1)[0].strip()
 
@@ -467,7 +469,7 @@ class API(ReadOnly):
             level = ipa_log_manager.convert_log_level(match.group(1))
 
             value = getattr(self.env, attr)
-            regexps = re.split('\s*,\s*', value)
+            regexps = re.split(r'\s*,\s*', value)
 
             # Add the regexp, it maps to the configured level
             for regexp in regexps:
diff --git a/ipapython/certdb.py b/ipapython/certdb.py
index dcab5512e..84ce1cf35 100644
--- a/ipapython/certdb.py
+++ b/ipapython/certdb.py
@@ -554,7 +554,7 @@ class NSSDatabase:
         chain = result.output.splitlines()
 
         for c in chain:
-            m = re.match('\s*"(.*)" \[.*', c)
+            m = re.match(r'\s*"(.*)" \[.*', c)
             if m:
                 root_nicknames.append(m.groups()[0])
 
diff --git a/ipapython/dn.py b/ipapython/dn.py
index aa15c19ca..8974b420c 100644
--- a/ipapython/dn.py
+++ b/ipapython/dn.py
@@ -17,7 +17,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-'''
+r'''
 
 Goal
 ----
diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py
index f144b9809..d87b9e3c1 100644
--- a/ipapython/ipautil.py
+++ b/ipapython/ipautil.py
@@ -310,7 +310,7 @@ def template_str(txt, vars):
     # eval() is a special string one can insert into a template to have the
     # Python interpreter evaluate the string. This is intended to allow
     # math to be performed in templates.
-    pattern = re.compile('(eval\s*\(([^()]*)\))')
+    pattern = re.compile(r'(eval\s*\(([^()]*)\))')
     val = pattern.sub(lambda x: str(eval(x.group(2))), val)
 
     return val
@@ -1145,7 +1145,7 @@ def config_replace_variables(filepath, replacevars=dict(), appendvars=dict(),
     One have to run restore_context(filepath) afterwards or
     security context of the file will not be correct after modification
     """
-    pattern = re.compile('''
+    pattern = re.compile(r'''
 (^
                         \s*
         (?P<option>     [^\#;]+?)
@@ -1220,7 +1220,7 @@ def inifile_replace_variables(filepath, section, replacevars=dict(), appendvars=
     One have to run restore_context(filepath) afterwards or
     security context of the file will not be correct after modification
     """
-    pattern = re.compile('''
+    pattern = re.compile(r'''
 (^
                         \[
         (?P<section>    .+) \]
diff --git a/ipaserver/dcerpc.py b/ipaserver/dcerpc.py
index adac8bbd6..1a5a91208 100644
--- a/ipaserver/dcerpc.py
+++ b/ipaserver/dcerpc.py
@@ -22,7 +22,7 @@
 # Make sure we only run this module at the server where samba4-python
 # package is installed to avoid issues with unavailable modules
 
-from __future__ import absolute_import
+from __future__ import absolute_import, unicode_literals
 
 import logging
 import re
@@ -634,7 +634,7 @@ class DomainValidator:
             struct.unpack('<I', sid[8+4*i:12+4*i])[0]
             for i in range(number_sub_id)
         ]
-        return u'S-%d-%d-%s' % (sid_rev_num, ia,
+        return 'S-%d-%d-%s' % (sid_rev_num, ia,
                                 '-'.join([str(s) for s in subs]),)
 
     def kinit_as_administrator(self, domain):
@@ -900,9 +900,9 @@ class TrustDomainInstance:
 
         We try NCACN_NP before NCACN_IP_TCP and use SMB2 before SMB1.
         """
-        transports = (u'ncacn_np', u'ncacn_ip_tcp')
-        options = (u'smb2,print', u'print')
-        return [u'%s:%s[%s]' % (t, remote_host, o)
+        transports = ('ncacn_np', 'ncacn_ip_tcp')
+        options = ('smb2,print', 'print')
+        return ['%s:%s[%s]' % (t, remote_host, o)
                 for t in transports for o in options]
 
     def retrieve_anonymously(self, remote_host,
@@ -976,7 +976,7 @@ class TrustDomainInstance:
         objectAttribute.sec_qos = lsa.QosInfo()
         try:
             self._policy_handle = \
-                self._pipe.OpenPolicy2(u"", objectAttribute,
+                self._pipe.OpenPolicy2("", objectAttribute,
                                        security.SEC_FLAG_MAXIMUM_ALLOWED)
             result = self._pipe.QueryInfoPolicy2(self._policy_handle,
                                                  lsa.LSA_POLICY_INFO_DNS)
@@ -1301,7 +1301,7 @@ class TrustDomainInstance:
         """
         if self.info['name'] == another_domain.info['name']:
             # Check that NetBIOS names do not clash
-            raise errors.ValidationError(name=u'AD Trust Setup',
+            raise errors.ValidationError(name='AD Trust Setup',
                                          error=_('the IPA server and the '
                                                  'remote domain cannot share '
                                                  'the same NetBIOS name: %s')
@@ -1597,7 +1597,7 @@ def retrieve_remote_domain(hostname, local_flatname,
                 # realm admin is in DOMAIN\user format
                 # strip DOMAIN part as we'll enforce the one discovered
                 realm_admin = names[-1]
-            auth_string = u"%s\%s%%%s" \
+            auth_string = r"%s\%s%%%s" \
                           % (rd.info['name'], realm_admin, realm_passwd)
             td = get_instance(local_flatname)
             td.creds.parse_string(auth_string)
diff --git a/ipaserver/dns_data_management.py b/ipaserver/dns_data_management.py
index 9a9ad82e6..994326ada 100644
--- a/ipaserver/dns_data_management.py
+++ b/ipaserver/dns_data_management.py
@@ -2,7 +2,7 @@
 # Copyright (C) 2016  FreeIPA Contributors see COPYING for license
 #
 
-from __future__ import absolute_import
+from __future__ import absolute_import, unicode_literals
 
 import logging
 
@@ -31,23 +31,23 @@ logger = logging.getLogger(__name__)
 
 IPA_DEFAULT_MASTER_SRV_REC = (
     # srv record name, port
-    (DNSName(u'_ldap._tcp'), 389),
-    (DNSName(u'_kerberos._tcp'), 88),
-    (DNSName(u'_kerberos._udp'), 88),
-    (DNSName(u'_kerberos-master._tcp'), 88),
-    (DNSName(u'_kerberos-master._udp'), 88),
-    (DNSName(u'_kpasswd._tcp'), 464),
-    (DNSName(u'_kpasswd._udp'), 464),
+    (DNSName('_ldap._tcp'), 389),
+    (DNSName('_kerberos._tcp'), 88),
+    (DNSName('_kerberos._udp'), 88),
+    (DNSName('_kerberos-master._tcp'), 88),
+    (DNSName('_kerberos-master._udp'), 88),
+    (DNSName('_kpasswd._tcp'), 464),
+    (DNSName('_kpasswd._udp'), 464),
 )
 
 IPA_DEFAULT_ADTRUST_SRV_REC = (
     # srv record name, port
-    (DNSName(u'_ldap._tcp.Default-First-Site-Name._sites.dc._msdcs'), 389),
-    (DNSName(u'_ldap._tcp.dc._msdcs'), 389),
-    (DNSName(u'_kerberos._tcp.Default-First-Site-Name._sites.dc._msdcs'), 88),
-    (DNSName(u'_kerberos._udp.Default-First-Site-Name._sites.dc._msdcs'), 88),
-    (DNSName(u'_kerberos._tcp.dc._msdcs'), 88),
-    (DNSName(u'_kerberos._udp.dc._msdcs'), 88),
+    (DNSName('_ldap._tcp.Default-First-Site-Name._sites.dc._msdcs'), 389),
+    (DNSName('_ldap._tcp.dc._msdcs'), 389),
+    (DNSName('_kerberos._tcp.Default-First-Site-Name._sites.dc._msdcs'), 88),
+    (DNSName('_kerberos._udp.Default-First-Site-Name._sites.dc._msdcs'), 88),
+    (DNSName('_kerberos._tcp.dc._msdcs'), 88),
+    (DNSName('_kerberos._udp.dc._msdcs'), 88),
 )
 
 IPA_DEFAULT_NTP_SRV_REC = (
@@ -83,7 +83,7 @@ class IPASystemRecords:
         self.__init_data()
 
     def __get_server_attrs(self, server_result):
-        weight = int(server_result.get('ipaserviceweight', [u'100'])[0])
+        weight = int(server_result.get('ipaserviceweight', ['100'])[0])
         location = server_result.get('ipalocation_location', [None])[0]
         roles = set(server_result.get('enabled_role_servrole', ()))
 
@@ -98,7 +98,7 @@ class IPASystemRecords:
         kwargs = dict(no_members=False)
         if not all_servers:
             # only active, fully installed masters]
-            kwargs["servrole"] = u"IPA master"
+            kwargs["servrole"] = "IPA master"
         servers = self.api_instance.Command.server_find(**kwargs)
 
         for s in servers['result']:
@@ -277,10 +277,10 @@ class IPASystemRecords:
     ):
         update_dict = self.__prepare_records_update_dict(nodes)
         cname_template = {
-            'addattr': [u'objectclass=idnsTemplateObject'],
+            'addattr': ['objectclass=idnsTemplateObject'],
             'setattr': [
-                u'idnsTemplateAttribute;cnamerecord=%s'
-                u'.\{substitutionvariable_ipalocation\}._locations' %
+                r'idnsTemplateAttribute;cnamerecord=%s'
+                r'.\{substitutionvariable_ipalocation\}._locations' %
                 record_name.relativize(self.domain_abs)
             ]
         }
@@ -474,7 +474,7 @@ class IPASystemRecords:
         for rdataset in node:
             for rd in rdataset:
                 records.append(
-                    u'{name} {ttl} {rdclass} {rdtype} {rdata}'.format(
+                    '{name} {ttl} {rdclass} {rdtype} {rdata}'.format(
                         name=name.ToASCII(),
                         ttl=rdataset.ttl,
                         rdclass=rdataclass.to_text(rd.rdclass),
diff --git a/ipaserver/install/adtrustinstance.py b/ipaserver/install/adtrustinstance.py
index 47a5a9290..8699d53e6 100644
--- a/ipaserver/install/adtrustinstance.py
+++ b/ipaserver/install/adtrustinstance.py
@@ -675,7 +675,8 @@ class ADTRUSTInstance(service.Service):
 
         has_dns_lookup_kdc_true = False
         for line in krb5conf:
-            if re.match("^\s*dns_lookup_kdc\s*=\s*[Tt][Rr][Uu][Ee]\s*$", line):
+            regex = r"^\s*dns_lookup_kdc\s*=\s*[Tt][Rr][Uu][Ee]\s*$"
+            if re.match(regex, line):
                 has_dns_lookup_kdc_true = True
                 break
         krb5conf.close()
diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py
index 9920d311c..d0beb5fbe 100644
--- a/ipaserver/install/bindinstance.py
+++ b/ipaserver/install/bindinstance.py
@@ -67,8 +67,8 @@ if six.PY3:
 
 logger = logging.getLogger(__name__)
 
-named_conf_section_ipa_start_re = re.compile('\s*dyndb\s+"ipa"\s+"[^"]+"\s+{')
-named_conf_section_options_start_re = re.compile('\s*options\s+{')
+named_conf_section_ipa_start_re = re.compile(r'\s*dyndb\s+"ipa"\s+"[^"]+"\s+{')
+named_conf_section_options_start_re = re.compile(r'\s*options\s+{')
 named_conf_section_end_re = re.compile('};')
 named_conf_arg_ipa_re = re.compile(
     r'(?P<indent>\s*)(?P<name>\S+)\s"(?P<value>[^"]+)";')
diff --git a/ipaserver/install/dsinstance.py b/ipaserver/install/dsinstance.py
index d92176f67..29ed56788 100644
--- a/ipaserver/install/dsinstance.py
+++ b/ipaserver/install/dsinstance.py
@@ -463,7 +463,7 @@ class DsInstance(service.Service):
                 ('cn', 'config')),
             objectclass=["top", "nsSaslMapping"],
             cn=["Full Principal"],
-            nsSaslMapRegexString=['\(.*\)@\(.*\)'],
+            nsSaslMapRegexString=[r'\(.*\)@\(.*\)'],
             nsSaslMapBaseDNTemplate=[self.suffix],
             nsSaslMapFilterTemplate=['(krbPrincipalName=\\1@\\2)'],
             nsSaslMapPriority=['10'],
diff --git a/ipaserver/install/server/upgrade.py b/ipaserver/install/server/upgrade.py
index 1c6878e02..4253fb319 100644
--- a/ipaserver/install/server/upgrade.py
+++ b/ipaserver/install/server/upgrade.py
@@ -140,7 +140,7 @@ def find_autoredirect(fqdn):
     """
     filename = paths.HTTPD_IPA_REWRITE_CONF
     if os.path.exists(filename):
-        pattern = "^RewriteRule \^/\$ https://%s/ipa/ui \[L,NC,R=301\]" % fqdn
+        pattern = r"^RewriteRule \^/\$ https://%s/ipa/ui \[L,NC,R=301\]" % fqdn
         p = re.compile(pattern)
         for line in fileinput.input(filename):
             if p.search(line):
@@ -157,7 +157,7 @@ def find_version(filename):
     If the file does not exist, returns -1.
     """
     if os.path.exists(filename):
-        pattern = "^[\s#]*VERSION\s+([0-9]+)\s+.*"
+        pattern = r"^[\s#]*VERSION\s+([0-9]+)\s+.*"
         p = re.compile(pattern)
         for line in fileinput.input(filename):
             if p.search(line):
diff --git a/ipaserver/plugins/automember.py b/ipaserver/plugins/automember.py
index ed837d27a..3decbc16c 100644
--- a/ipaserver/plugins/automember.py
+++ b/ipaserver/plugins/automember.py
@@ -70,11 +70,11 @@ EXAMPLES:
  Add the initial rule:
    ipa automember-add --type=hostgroup webservers
    ipa automember-add --type=group devel
-""") + _("""
+""") + _(r"""
  Add a condition to the rule:
    ipa automember-add-condition --key=fqdn --type=hostgroup --inclusive-regex=^web[1-9]+\.example\.com webservers
    ipa automember-add-condition --key=manager --type=group --inclusive-regex=^uid=mscott devel
-""") + _("""
+""") + _(r"""
  Add an exclusive condition to the rule to prevent auto assignment:
    ipa automember-add-condition --key=fqdn --type=hostgroup --exclusive-regex=^web5\.example\.com webservers
 """) + _("""
@@ -95,7 +95,7 @@ EXAMPLES:
       Description: Developers
       GID: 1004200000
       Member users: tuser
-""") + _("""
+""") + _(r"""
  Remove a condition from the rule:
    ipa automember-remove-condition --key=fqdn --type=hostgroup --inclusive-regex=^web[1-9]+\.example\.com webservers
 """) + _("""
diff --git a/ipaserver/plugins/baseldap.py b/ipaserver/plugins/baseldap.py
index 4fbc231a2..d5845ceda 100644
--- a/ipaserver/plugins/baseldap.py
+++ b/ipaserver/plugins/baseldap.py
@@ -200,7 +200,7 @@ def validate_del_attribute(ugettext, attr):
     validate_attribute(ugettext, 'delattr', attr)
 
 def validate_attribute(ugettext, name, attr):
-    m = re.match("\s*(.*?)\s*=\s*(.*?)\s*$", attr)
+    m = re.match(r"\s*(.*?)\s*=\s*(.*?)\s*$", attr)
     if not m or len(m.groups()) != 2:
         raise errors.ValidationError(
             name=name, error=_('Invalid format. Should be name=value'))
@@ -919,7 +919,7 @@ last, after all sets and adds."""),
         elif type(attrs) not in (list, tuple):
             attrs = [attrs]
         for a in attrs:
-            m = re.match("\s*(.*?)\s*=\s*(.*?)\s*$", a)
+            m = re.match(r"\s*(.*?)\s*=\s*(.*?)\s*$", a)
             attr = str(m.group(1)).lower()
             value = m.group(2)
             if attr in self.obj.params and attr not in self.params:
diff --git a/ipaserver/plugins/dns.py b/ipaserver/plugins/dns.py
index 27d1822b5..6d1bacc2d 100644
--- a/ipaserver/plugins/dns.py
+++ b/ipaserver/plugins/dns.py
@@ -1458,7 +1458,7 @@ class TXTRecord(DNSRecord):
 
 
 def _normalize_uri_target(uri_target):
-    """DNS-escape "\ characters and double-quote target."""
+    r"""DNS-escape "\ characters and double-quote target."""
     # is user-provided string is already quoted?
     if uri_target[0:1] == uri_target[-1:] == '"':
         uri_target = uri_target[1:-1]
diff --git a/ipaserver/plugins/hbactest.py b/ipaserver/plugins/hbactest.py
index 698a97af9..ac23027d8 100644
--- a/ipaserver/plugins/hbactest.py
+++ b/ipaserver/plugins/hbactest.py
@@ -42,7 +42,7 @@ except ImportError:
 if six.PY3:
     unicode = str
 
-__doc__ = _("""
+__doc__ = _(r"""
 Simulate use of Host-based access controls
 
 HBAC rules control who can access what services on what hosts.
diff --git a/ipaserver/plugins/host.py b/ipaserver/plugins/host.py
index d7dae570f..2223253ca 100644
--- a/ipaserver/plugins/host.py
+++ b/ipaserver/plugins/host.py
@@ -554,7 +554,7 @@ class host(LDAPObject):
         ),
         Str('macaddress*',
             normalizer=lambda value: value.upper(),
-            pattern='^([a-fA-F0-9]{2}[:|\-]?){5}[a-fA-F0-9]{2}$',
+            pattern=r'^([a-fA-F0-9]{2}[:|\-]?){5}[a-fA-F0-9]{2}$',
             pattern_errmsg=('Must be of the form HH:HH:HH:HH:HH:HH, where '
                             'each H is a hexadecimal character.'),
             label=_('MAC address'),
diff --git a/ipaserver/plugins/permission.py b/ipaserver/plugins/permission.py
index 0a1733b54..2a0b4824f 100644
--- a/ipaserver/plugins/permission.py
+++ b/ipaserver/plugins/permission.py
@@ -390,7 +390,7 @@ class permission(baseldap.LDAPObject):
         # memberof
         memberof = []
         for targetfilter in ipapermtargetfilter:
-            match = re.match('^\(memberof=(.*)\)$', targetfilter, re.I)
+            match = re.match(r'^\(memberof=(.*)\)$', targetfilter, re.I)
             if match:
                 try:
                     dn = DN(match.group(1))
diff --git a/ipatests/pytest_ipa/integration/__init__.py b/ipatests/pytest_ipa/integration/__init__.py
index 0c181fa30..b94b8cb2b 100644
--- a/ipatests/pytest_ipa/integration/__init__.py
+++ b/ipatests/pytest_ipa/integration/__init__.py
@@ -50,9 +50,9 @@ def pytest_addoption(parser):
 
 def _get_logname_from_node(node):
     name = node.nodeid
-    name = re.sub('\(\)/', '', name)      # remove ()/
-    name = re.sub('[()]', '', name)       # and standalone brackets
-    name = re.sub('(/|::)', '-', name)
+    name = re.sub(r'\(\)/', '', name)      # remove ()/
+    name = re.sub(r'[()]', '', name)       # and standalone brackets
+    name = re.sub(r'(/|::)', '-', name)
     return name
 
 
diff --git a/ipatests/test_integration/test_backup_and_restore.py b/ipatests/test_integration/test_backup_and_restore.py
index 49d231b6c..fd7bf47c2 100644
--- a/ipatests/test_integration/test_backup_and_restore.py
+++ b/ipatests/test_integration/test_backup_and_restore.py
@@ -76,7 +76,7 @@ def check_admin_in_cli(host):
     # LDAP do not guarantee any order, so the test cannot assume it. Based on
     # that, the code bellow order the 'Member of groups' field to able to
     # assert it latter.
-    data = dict(re.findall("\W*(.+):\W*(.+)\W*", result.stdout_text))
+    data = dict(re.findall(r"\W*(.+):\W*(.+)\W*", result.stdout_text))
     data["Member of groups"] = ', '.join(sorted(data["Member of groups"]
                                                 .split(", ")))
     result.stdout_text = ''.join([' {}: {}\n'.format(k, v)
diff --git a/ipatests/test_integration/test_external_ca.py b/ipatests/test_integration/test_external_ca.py
index e212b682f..72aa57a0b 100644
--- a/ipatests/test_integration/test_external_ca.py
+++ b/ipatests/test_integration/test_external_ca.py
@@ -51,7 +51,7 @@ def check_CA_flag(host, nssdb=paths.PKI_TOMCAT_ALIAS_DIR,
     text = result.stdout_text
 
     # match CN in cert nickname and C flag in SSL section of NSS flags table
-    match_CA_flag = re.compile('.*{}.*\s+C'.format(cn))
+    match_CA_flag = re.compile(r'.*{}.*\s+C'.format(cn))
     match = re.search(match_CA_flag, text)
 
     return match
diff --git a/ipatests/test_integration/test_legacy_clients.py b/ipatests/test_integration/test_legacy_clients.py
index 916d51abb..830717d96 100644
--- a/ipatests/test_integration/test_legacy_clients.py
+++ b/ipatests/test_integration/test_legacy_clients.py
@@ -154,9 +154,9 @@ class BaseTestLegacyClient:
 
         # Only for POSIX trust testing does the testuser belong to the
         # testgroup
-        group_name = '\(%s\)' % testgroup if self.posix_trust else ''
+        group_name = r'\(%s\)' % testgroup if self.posix_trust else ''
 
-        uid_regex = "uid=%s\(%s\)" % (self.testuser_uid_regex, testuser)
+        uid_regex = r"uid=%s\(%s\)" % (self.testuser_uid_regex, testuser)
         gid_regex = "gid=%s%s" % (self.testuser_gid_regex, group_name)
         groups_regex = "groups=%s%s" % (self.testuser_gid_regex, group_name)
 
@@ -282,9 +282,9 @@ class BaseTestLegacyClient:
 
         # Only for POSIX trust testing does the testuser belong to the
         # testgroup
-        group_name = '\(%s\)' % testgroup if self.posix_trust else ''
+        group_name = r'\(%s\)' % testgroup if self.posix_trust else ''
 
-        uid_regex = "uid=%s\(%s\)" % (self.subdomain_testuser_uid_regex,
+        uid_regex = r"uid=%s\(%s\)" % (self.subdomain_testuser_uid_regex,
                                       testuser)
         gid_regex = "gid=%s%s" % (self.subdomain_testuser_gid_regex,
                                   group_name)
@@ -381,9 +381,9 @@ class BaseTestLegacyClient:
         # Only for POSIX trust testing does the testuser belong to the
         # testgroup
 
-        group_name = '\({}\)'.format(testgroup) if self.posix_trust else ''
+        group_name = r'\({}\)'.format(testgroup) if self.posix_trust else ''
 
-        uid_regex = "uid={0}\({1}\)".format(
+        uid_regex = r"uid={0}\({1}\)".format(
                     self.treedomain_testuser_uid_regex, testuser)
 
         gid_regex = "gid={0}{1}".format(
diff --git a/ipatests/test_integration/test_topology.py b/ipatests/test_integration/test_topology.py
index bc0aabca2..af2e448b7 100644
--- a/ipatests/test_integration/test_topology.py
+++ b/ipatests/test_integration/test_topology.py
@@ -20,8 +20,8 @@ reasoning = "Topology plugin disabled due to domain level 0"
 def find_segment(master, replica):
     result = master.run_command(['ipa', 'topologysegment-find',
                                  DOMAIN_SUFFIX_NAME]).stdout_text
-    segment_re = re.compile('Left node: (?P<left>\S+)\n.*Right node: '
-                            '(?P<right>\S+)\n')
+    segment_re = re.compile(r'Left node: (?P<left>\S+)\n.*Right node: '
+                            r'(?P<right>\S+)\n')
     allsegments = segment_re.findall(result)
     for segment in allsegments:
         if master.hostname in segment and replica.hostname in segment:
diff --git a/ipatests/test_xmlrpc/test_external_members.py b/ipatests/test_xmlrpc/test_external_members.py
index 520db03df..e7263f5cb 100644
--- a/ipatests/test_xmlrpc/test_external_members.py
+++ b/ipatests/test_xmlrpc/test_external_members.py
@@ -21,6 +21,8 @@ Test adding/removing external members (trusted domain objects) to IPA groups.
 These tests are skipped if trust is not established.
 """
 
+from __future__ import unicode_literals
+
 import unittest
 
 from ipalib import api
@@ -41,7 +43,7 @@ def get_trusted_group_name():
         return None
 
     ad_netbios = trusts['result'][0]['ipantflatname']
-    return u'%s\Domain Admins' % ad_netbios
+    return r'%s\Domain Admins' % ad_netbios
 
 
 @pytest.mark.tier1
diff --git a/ipatests/util.py b/ipatests/util.py
index 9ff8585b9..317758e62 100644
--- a/ipatests/util.py
+++ b/ipatests/util.py
@@ -194,7 +194,7 @@ def assert_not_equal(val1, val2):
 
 
 class Fuzzy:
-    """
+    r"""
     Perform a fuzzy (non-strict) equality tests.
 
     `Fuzzy` instances will likely be used when comparing nesting