IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

pylint: fix pointless-statement

Browse Source 
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
This commit is contained in:
Jan Barta 2016-06-03 10:47:39 +02:00 committed by Martin Basti
parent 275e85d076
commit cdecbcd0a1
3 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ipatests/test_ipapython/test_dn.py
View File

@ -138,10 +138,10 @@ class TestAVA(unittest.TestCase):
self.assertEqual(ava1[1], self.value1) self.assertEqual(ava1[1], self.value1)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
ava1['foo'] ava1['foo'] # pylint: disable=pointless-statement
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
ava1[3] ava1[3] # pylint: disable=pointless-statement
def test_properties(self): def test_properties(self):
ava1 = AVA(self.ava1) ava1 = AVA(self.ava1)
@ -500,25 +500,25 @@ class TestRDN(unittest.TestCase):
self.assertEqual(rdn1[0], self.ava1) self.assertEqual(rdn1[0], self.ava1)
self.assertEqual(rdn1[self.ava1.attr], self.ava1.value) self.assertEqual(rdn1[self.ava1.attr], self.ava1.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
rdn1['foo'] rdn1['foo'] # pylint: disable=pointless-statement
self.assertEqual(rdn2[0], self.ava2) self.assertEqual(rdn2[0], self.ava2)
self.assertEqual(rdn2[self.ava2.attr], self.ava2.value) self.assertEqual(rdn2[self.ava2.attr], self.ava2.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
rdn2['foo'] rdn2['foo'] # pylint: disable=pointless-statement
self.assertEqual(rdn3[0], self.ava1) self.assertEqual(rdn3[0], self.ava1)
self.assertEqual(rdn3[self.ava1.attr], self.ava1.value) self.assertEqual(rdn3[self.ava1.attr], self.ava1.value)
self.assertEqual(rdn3[1], self.ava2) self.assertEqual(rdn3[1], self.ava2)
self.assertEqual(rdn3[self.ava2.attr], self.ava2.value) self.assertEqual(rdn3[self.ava2.attr], self.ava2.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
rdn3['foo'] rdn3['foo'] # pylint: disable=pointless-statement
self.assertEqual(rdn1.attr, self.attr1) self.assertEqual(rdn1.attr, self.attr1)
self.assertEqual(rdn1.value, self.value1) self.assertEqual(rdn1.value, self.value1)
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
rdn3[1.0] rdn3[1.0] # pylint: disable=pointless-statement
# Slices # Slices
self.assertEqual(rdn3[0:1], [self.ava1]) self.assertEqual(rdn3[0:1], [self.ava1])
@ -915,22 +915,22 @@ class TestDN(unittest.TestCase):
self.assertEqual(dn1[0], self.rdn1) self.assertEqual(dn1[0], self.rdn1)
self.assertEqual(dn1[self.rdn1.attr], self.rdn1.value) self.assertEqual(dn1[self.rdn1.attr], self.rdn1.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
dn1['foo'] dn1['foo'] # pylint: disable=pointless-statement
self.assertEqual(dn2[0], self.rdn2) self.assertEqual(dn2[0], self.rdn2)
self.assertEqual(dn2[self.rdn2.attr], self.rdn2.value) self.assertEqual(dn2[self.rdn2.attr], self.rdn2.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
dn2['foo'] dn2['foo'] # pylint: disable=pointless-statement
self.assertEqual(dn3[0], self.rdn1) self.assertEqual(dn3[0], self.rdn1)
self.assertEqual(dn3[self.rdn1.attr], self.rdn1.value) self.assertEqual(dn3[self.rdn1.attr], self.rdn1.value)
self.assertEqual(dn3[1], self.rdn2) self.assertEqual(dn3[1], self.rdn2)
self.assertEqual(dn3[self.rdn2.attr], self.rdn2.value) self.assertEqual(dn3[self.rdn2.attr], self.rdn2.value)
with self.assertRaises(KeyError): with self.assertRaises(KeyError):
dn3['foo'] dn3['foo'] # pylint: disable=pointless-statement
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
dn3[1.0] dn3[1.0] # pylint: disable=pointless-statement
def test_assignments(self): def test_assignments(self):
dn = dn2 = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9') dn = dn2 = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9')
@ -1102,7 +1102,7 @@ class TestDN(unittest.TestCase):
# pylint: disable=no-member # pylint: disable=no-member
dn = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9') dn = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9')
with self.assertRaises(AttributeError): with self.assertRaises(AttributeError):
dn.replace dn.replace # pylint: disable=pointless-statement
def test_hashing(self): def test_hashing(self):
# create DN's that are equal but differ in case # create DN's that are equal but differ in case

2
ipatests/test_ipapython/test_ipautil.py
View File

@ -109,7 +109,7 @@ class TestCIDict(object):
nose.tools.assert_equal("VAL3", self.cidict["key3"]) nose.tools.assert_equal("VAL3", self.cidict["key3"])
nose.tools.assert_equal("VAL3", self.cidict["KEY3"]) nose.tools.assert_equal("VAL3", self.cidict["KEY3"])
with nose.tools.assert_raises(KeyError): with nose.tools.assert_raises(KeyError):
self.cidict["key4"] self.cidict["key4"] # pylint: disable=pointless-statement
def test_get(self): def test_get(self):
nose.tools.assert_equal("val1", self.cidict.get("Key1")) nose.tools.assert_equal("val1", self.cidict.get("Key1"))

1
pylintrc
View File

@ -49,7 +49,6 @@ disable=
global-statement, global-statement,
global-variable-not-assigned, global-variable-not-assigned,
no-init, no-init,
pointless-statement,
pointless-string-statement, pointless-string-statement,
protected-access, protected-access,
redefine-in-handler, redefine-in-handler,