mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-02-25 18:55:28 -06:00
Fix E713 test for membership should be 'not in'
Related: https://pagure.io/freeipa/issue/8306 Signed-off-by: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
This commit is contained in:
@@ -533,7 +533,7 @@ class update_dnsserver_configuration_into_ldap(DNSUpdater):
|
||||
return False, []
|
||||
|
||||
result = self.api.Command.server_show(self.api.env.host)['result']
|
||||
if not 'DNS server' in result.get('enabled_role_servrole', []):
|
||||
if 'DNS server' not in result.get('enabled_role_servrole', []):
|
||||
logger.debug('This server is not DNS server, nothing to upgrade')
|
||||
sysupgrade.set_upgrade_state('dns', 'server_config_to_ldap', True)
|
||||
return False, []
|
||||
|
||||
@@ -24,7 +24,7 @@ class update_ldap_server_list(Updater):
|
||||
entry = ldap.get_entry(dn)
|
||||
srvlist = entry.single_value.get('defaultServerList', '')
|
||||
srvlist = srvlist.split()
|
||||
if not self.api.env.host in srvlist:
|
||||
if self.api.env.host not in srvlist:
|
||||
srvlist.append(self.api.env.host)
|
||||
attr = ' '.join(srvlist)
|
||||
entry['defaultServerList'] = attr
|
||||
|
||||
@@ -742,7 +742,7 @@ def ensure_enrolled(installer):
|
||||
|
||||
def promotion_check_ipa_domain(master_ldap_conn, basedn):
|
||||
entry = master_ldap_conn.get_entry(basedn, ['associatedDomain'])
|
||||
if not 'associatedDomain' in entry:
|
||||
if 'associatedDomain' not in entry:
|
||||
raise RuntimeError('IPA domain not found in LDAP.')
|
||||
|
||||
if len(entry['associatedDomain']) > 1:
|
||||
|
||||
Reference in New Issue
Block a user