schema: merge command args and options

Rather than having args and options separately in command schema, merge
them together and use new `positional` param flag to differentiate between
them.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Jan Cholasta
2016-06-16 10:19:25 +02:00
parent 91faf3ecd7
commit d0cfe37a7e
3 changed files with 17 additions and 25 deletions

View File

@@ -176,16 +176,6 @@ class command(metaobject):
label=_("Method name"),
flags={'no_search'},
),
Str(
'args_param*',
label=_("Arguments"),
flags={'no_search'},
),
Str(
'options_param*',
label=_("Options"),
flags={'no_search'},
),
Bool(
'no_cli?',
label=_("Exclude from CLI"),
@@ -222,13 +212,6 @@ class command(metaobject):
if cmd.NO_CLI:
obj['no_cli'] = True
if len(cmd.args):
obj['args_param'] = tuple(unicode(n) for n in cmd.args)
if len(cmd.options):
obj['options_param'] = tuple(
unicode(n) for n in cmd.options if n != 'version')
return obj
def _retrieve(self, name, **kwargs):
@@ -560,6 +543,11 @@ class param(BaseParam):
label=_("Sensitive"),
flags={'no_search'},
),
Bool(
'positional?',
label=_("Positional argument"),
flags={'no_search'},
),
)
@property
@@ -585,6 +573,11 @@ class param(BaseParam):
obj['multivalue'] = True
if param.password:
obj['sensitive'] = True
if isinstance(metaobj, Command):
if param.required and param.name not in metaobj.args:
obj['positional'] = False
elif not param.required and param.name in metaobj.args:
obj['positional'] = True
for key, value in param._Param__clonekw.items():
if key in ('doc',