IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2024-12-22 23:23:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in GetKeytabControl asn1 code

Browse Source 
https://fedorahosted.org/freeipa/ticket/4713

Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Jan Cholasta 2014-11-24 13:57:10 +00:00
parent 66a42e67f3
commit d55936756d
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
asn1/ipa_asn1.c
View File

@ -77,12 +77,12 @@ bool ipaasn1_enc_getktreply(int kvno, struct keys_container *keys,
{ {
GetKeytabControl_t gkctrl = { 0 }; GetKeytabControl_t gkctrl = { 0 };
bool ret = false; bool ret = false;
KrbKey_t *KK;
gkctrl.present = GetKeytabControl_PR_reply; gkctrl.present = GetKeytabControl_PR_reply;
gkctrl.choice.reply.newkvno = kvno; gkctrl.choice.reply.newkvno = kvno;
for (int i = 0; i < keys->nkeys; i++) { for (int i = 0; i < keys->nkeys; i++) {
KrbKey_t *KK;
KK = calloc(1, sizeof(KrbKey_t)); KK = calloc(1, sizeof(KrbKey_t));
if (!KK) goto done; if (!KK) goto done;
KK->key.type = keys->ksdata[i].key.enctype; KK->key.type = keys->ksdata[i].key.enctype;
@ -109,9 +109,18 @@ bool ipaasn1_enc_getktreply(int kvno, struct keys_container *keys,
} }
ret = encode_GetKeytabControl(&gkctrl, buf, len); ret = encode_GetKeytabControl(&gkctrl, buf, len);
KK = NULL;
done: done:
ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_GetKeytabControl, &gkctrl); ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_GetKeytabControl, &gkctrl);
if (KK) {
free(KK->key.value.buf);
if (KK->salt) {
free(KK->salt->value.buf);
free(KK->salt);
}
free(KK);
}
return ret; return ret;
} }