IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

ipa-sam: fix gcc complaints on Rawhide

Browse Source 
In file included from /usr/include/string.h:519,
                  from /usr/include/lber.h:30,
                  from /usr/include/ldap.h:30,
                  from ipa_sam.c:12:
 In function 'strncpy',
     inlined from 'save_sid_to_secret' at ipa_sam.c:4478:2,
     inlined from 'pdb_init_ipasam' at ipa_sam.c:4985:12:
 /usr/include/bits/string_fortified.h:91:10: warning: 'strncpy' specified bound 255 equals destination size [-Wstringop-truncation]
    91 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: https://pagure.io/freeipa/issue/8585
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
This commit is contained in:
Alexander Bokovoy 2020-11-13 14:22:48 +02:00
parent fc11c56544
commit d99b7d0b01
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
daemons/ipa-sam/ipa_sam.c
View File

@ -4441,7 +4441,7 @@ static char *sec_key(TALLOC_CTX *mem_ctx, const char *d)
static NTSTATUS save_sid_to_secret(struct ipasam_private *ipasam_state) static NTSTATUS save_sid_to_secret(struct ipasam_private *ipasam_state)
{ {
char hostname[IPA_HOST_FQDN_LEN]; char hostname[IPA_HOST_FQDN_LEN + 1];
const char *fqdn; const char *fqdn;
char *p; char *p;
TALLOC_CTX *tmp_ctx; TALLOC_CTX *tmp_ctx;
@ -4475,7 +4475,7 @@ static NTSTATUS save_sid_to_secret(struct ipasam_private *ipasam_state)
} }
/* Copy is necessary, otherwise we this will corrupt the static /* Copy is necessary, otherwise we this will corrupt the static
* buffer returned by ipa_gethostfqdn(). */ * buffer returned by ipa_gethostfqdn(). */
strncpy(hostname, fqdn, sizeof(hostname)); strncpy(hostname, fqdn, IPA_HOST_FQDN_LEN);
p = strchr(hostname, '.'); p = strchr(hostname, '.');
if (p != NULL) { if (p != NULL) {
*p = '\0'; *p = '\0';