IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Optimize user-add by caching ldap2.has_upg()

Browse Source 
The method has_upg returns if user private groups are enabled or
disabled. has_upg() is called three times by user-add. The setting is
now cached on the request local variable context to speed up batch
processing of user imports.

context is cleared after every request.

Related: https://pagure.io/freeipa/issue/8134
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
This commit is contained in:
Christian Heimes
2019-12-02 10:25:03 +01:00
parent 28929897ab
commit dcb33e44e7
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ipaserver/plugins/ldap2.py
View File

@@ -250,6 +250,10 @@ class ldap2(CrudBackend, LDAPClient):
If the UPG Definition or its originfilter is not readable, If the UPG Definition or its originfilter is not readable,
an ACI error is raised. an ACI error is raised.
""" """
try:
return context.has_upg
except AttributeError:
pass
upg_dn = DN(('cn', 'UPG Definition'), ('cn', 'Definitions'), ('cn', 'Managed Entries'), upg_dn = DN(('cn', 'UPG Definition'), ('cn', 'Definitions'), ('cn', 'Managed Entries'),
('cn', 'etc'), self.api.env.basedn) ('cn', 'etc'), self.api.env.basedn)
@@ -266,7 +270,10 @@ class ldap2(CrudBackend, LDAPClient):
'Could not read UPG Definition originfilter. ' 'Could not read UPG Definition originfilter. '
'Check your permissions.')) 'Check your permissions.'))
org_filter = upg_entries[0].single_value['originfilter'] org_filter = upg_entries[0].single_value['originfilter']
return '(objectclass=disable)' not in org_filter
has_upg = '(objectclass=disable)' not in org_filter
context.has_upg = has_upg
return has_upg
def get_effective_rights(self, dn, attrs_list): def get_effective_rights(self, dn, attrs_list):
"""Returns the rights the currently bound user has for the given DN. """Returns the rights the currently bound user has for the given DN.