From ded70b6c6ea14458eef35dede5bbc276449f4fe9 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Thu, 17 Dec 2015 01:00:29 +0100 Subject: [PATCH] Enable pylint empty-docstring check Enables check and fixes: ************* Module ipalib.session ipalib/session.py:671: [C0112(empty-docstring), SessionAuthManager] Empty class docstring) ipalib/session.py:705: [C0112(empty-docstring), SessionAuthManager.logout] Empty method docstring) ************* Module ipalib.cli ipalib/cli.py:364: [C0112(empty-docstring), textui.print_entry] Empty method docstring) Reviewed-By: Jan Cholasta --- ipalib/cli.py | 2 -- ipalib/session.py | 6 ------ make-lint | 1 - 3 files changed, 9 deletions(-) diff --git a/ipalib/cli.py b/ipalib/cli.py index f3cd6147f..3b1b5a393 100644 --- a/ipalib/cli.py +++ b/ipalib/cli.py @@ -363,8 +363,6 @@ class textui(backend.Backend): self.print_entry(entry, order, labels, flags, print_all, format, indent) def print_entry(self, entry, order=None, labels=None, flags=None, print_all=True, format='%s: %s', indent=1): - """ - """ if isinstance(entry, (list, tuple)): entry = dict(entry) assert isinstance(entry, dict) diff --git a/ipalib/session.py b/ipalib/session.py index d04b660bd..44c29fe51 100644 --- a/ipalib/session.py +++ b/ipalib/session.py @@ -669,12 +669,8 @@ class AuthManager(object): self.debug('AuthManager.logout.%s:', self.name) class SessionAuthManager(object): - ''' - ''' def __init__(self): - ''' - ''' log_mgr.get_logger(self, True) self.auth_managers = {} @@ -703,8 +699,6 @@ class SessionAuthManager(object): def logout(self, session_data): - ''' - ''' self.debug('SessionAuthManager.logout:') for auth_mgr in self.auth_managers.values(): diff --git a/make-lint b/make-lint index 5a06f0a23..d52bdb630 100755 --- a/make-lint +++ b/make-lint @@ -290,7 +290,6 @@ def main(): linter.set_option('disable', 'bad-mcs-method-argument') linter.set_option('disable', 'bad-whitespace') linter.set_option('disable', 'blacklisted-name') - linter.set_option('disable', 'empty-docstring') linter.set_option('disable', 'invalid-name') linter.set_option('disable', 'line-too-long') linter.set_option('disable', 'missing-docstring')