IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove passwords when running commands including stdout and stderr

Browse Source 
This replaces the old no logging mechanism that only handled not logging
passwords passed on the command-line. The dogtag installer was including
passwords in the output.

This also adds no password logging to the sslget invocations and removes
a couple of extraneous log commands.

ticket 156
This commit is contained in:
Rob Crittenden
2010-08-31 16:50:47 -04:00
parent 99399cc707
commit e05400dad8
2 changed files with 16 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ipaserver/install/cainstance.py
View File

@@ -580,15 +580,8 @@ class CAInstance(service.Service):
args.append("false")
# Define the things we don't want logged
nolog = (('-client_certdb_pwd', 1),
('-admin_password', 1),
('-bind_password', 1),
('-backup_pwd', 1),
('-clone_p12_password', 1),
('-sd_admin_password', 1),
)
nolog = (self.admin_password, self.dm_password,)
logging.debug(args)
ipautil.run(args, nolog=nolog)
if self.external == 1:
@@ -682,8 +675,7 @@ class CAInstance(service.Service):
'-r', '/ca/agent/ca/profileReview?requestId=%s' % self.requestId,
'%s:%d' % (self.host_name, AGENT_SECURE_PORT),
]
logging.debug("running sslget %s" % args)
(stdout, stderr, returncode) = ipautil.run(args)
(stdout, stderr, returncode) = ipautil.run(args, nolog=(self.admin_password,))
data = stdout.split('\r\n')
params = get_defList(data)
@@ -703,8 +695,7 @@ class CAInstance(service.Service):
'-r', '/ca/agent/ca/profileProcess',
'%s:%d' % (self.host_name, AGENT_SECURE_PORT),
]
logging.debug("running sslget %s" % args)
(stdout, stderr, returncode) = ipautil.run(args)
(stdout, stderr, returncode) = ipautil.run(args, nolog=(self.admin_password,))
data = stdout.split('\r\n')
outputList = get_outputList(data)