IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

webui: fix regression: enabled gid field on group add

Browse Source 
GID field should be enabled by default since the default group is posix.

Was caused by option_widget_base not properly reporting value change while
selecting the default value. It has to be notified with delay otherwise the
event is consumed by FieldBinder.

https://fedorahosted.org/freeipa/ticket/4325

Reviewed-By: Endi Sukma Dewata <edewata@redhat.com>
This commit is contained in:
Petr Vobornik 2014-04-24 16:32:07 +02:00
parent 255cbb4976
commit e3840eef09
3 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
install/ui/src/freeipa/group.js
View File

@ -21,6 +21,7 @@
*/
define([
'dojo/on',
'./ipa',
'./jquery',
'./phases',
@ -29,7 +30,7 @@ define([
'./search',
'./association',
'./entity'],
function(IPA, $, phases, reg) {
function(on, IPA, $, phases, reg) {
var exp = IPA.group = {};
@ -197,14 +198,14 @@ IPA.group_adder_dialog = function(spec) {
var init = function() {
var type_field = that.fields.get_field('type');
type_field.widget.value_changed.attach(that.on_type_change);
on(type_field, 'value-change', that.on_type_change);
};
that.on_type_change = function() {
var type_field = that.fields.get_field('type');
var gid_field = that.fields.get_field('gidnumber');
var posix = type_field.save()[0] === 'posix';
var posix = type_field.get_value()[0] === 'posix';
if (!posix) {
gid_field.reset();

2
install/ui/src/freeipa/widget.js
View File

@ -1590,6 +1590,8 @@ IPA.option_widget_base = function(spec, that) {
// select default if none specified
if (that.default_value !== null) {
check(that._selector+'[value="'+that.default_value+'"]');
// default was selected instead of supplied value, hence notify
util.emit_delayed(that, 'value-change', { source: that });
} else {
// otherwise select empty
check(that._selector+'[value=""]');

31
ipatests/test_webui/test_group.py
View File

@ -42,6 +42,37 @@ class test_group(UI_driver):
self.basic_crud(group.ENTITY, group.DATA,
default_facet=group.DEFAULT_FACET)
@screenshot
def test_group_types(self):
"""
Test group types in adder dialog
"""
self.init_app()
pkey = 'itest-group'
data = {
'pkey': pkey,
'add': [
('callback', self.check_posix_enabled, True),
('textbox', 'cn', pkey),
('textarea', 'description', 'test-group desc'),
('radio', 'type', 'normal'),
('callback', self.check_posix_enabled, False),
('radio', 'type', 'posix'),
('callback', self.check_posix_enabled, True),
('radio', 'type', 'external'),
('callback', self.check_posix_enabled, False),
('radio', 'type', 'posix'),
('callback', self.check_posix_enabled, True),
],
}
self.add_record(group.ENTITY, data)
self.delete(group.ENTITY, [data], navigate=False)
def check_posix_enabled(self, enabled):
self.assert_disabled("[name=gidnumber]", negative=enabled)
@screenshot
def test_actions(self):
"""