IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-02-25 18:55:28 -06:00
Code Issues Packages Projects Releases Wiki Activity

perform case-insensitive principal search when canonicalization is requested

Browse Source 
When canonicalization is requested, the krbprincipalname attribute is searched
for case-insensitively.

In the case that krbcanonicalname is not set, the matched alias is returned
with the casing stored in backend, not the one input by client.

Part of https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: David Kupka <dkupka@redhat.com>
Reviewed-By: Simo Sorce <ssorce@redhat.com>
This commit is contained in:
Martin Babinsky 2015-09-08 16:45:23 +02:00 committed by Martin Basti
parent b59e82298c
commit e43231456d
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
daemons/ipa-kdb/ipa_kdb_principals.c
View File

@ -31,7 +31,7 @@
"(objectclass=krbprincipal)" \ "(objectclass=krbprincipal)" \
"(objectclass=ipakrbprincipal))" \ "(objectclass=ipakrbprincipal))" \
"(|(ipakrbprincipalalias=%s)" \ "(|(ipakrbprincipalalias=%s)" \
"(krbprincipalname=%s)))" "(krbprincipalname:caseIgnoreIA5Match:=%s)))"
#define PRINC_SEARCH_FILTER "(&(|(objectclass=krbprincipalaux)" \ #define PRINC_SEARCH_FILTER "(&(|(objectclass=krbprincipalaux)" \
"(objectclass=krbprincipal))" \ "(objectclass=krbprincipal))" \
@ -959,6 +959,17 @@ static krb5_error_code ipadb_find_principal(krb5_context kcontext,
NULL, NULL, &result) != 0) NULL, NULL, &result) != 0)
return KRB5_KDB_INTERNAL_ERROR; return KRB5_KDB_INTERNAL_ERROR;
found = (result == 0); found = (result == 0);
if (found) {
/* replace the incoming principal with the value having
* the correct case. This ensures that valid name/alias
* is returned even if krbCanonicalName is not present
*/
free(*principal);
*principal = strdup(vals[i]->bv_val);
if (!(*principal)) {
return KRB5_KDB_INTERNAL_ERROR;
}
}
} else { } else {
found = (strcmp(vals[i]->bv_val, (*principal)) == 0); found = (strcmp(vals[i]->bv_val, (*principal)) == 0);
} }