DNSSEC: Fix key metadata export

Incorrect SQL join condition could lead to situation where metadata from
ZSK and KSK were interchanged.

https://fedorahosted.org/freeipa/ticket/5273

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Oleg Fayans <ofayans@redhat.com>
This commit is contained in:
Petr Spacek 2015-08-31 18:40:50 +02:00 committed by Martin Basti
parent 025a9b16c8
commit e840061176

View File

@ -175,7 +175,7 @@ def get_ods_keys(zone_name):
# get all keys for given zone ID # get all keys for given zone ID
cur = db.execute("SELECT kp.HSMkey_id, kp.generate, kp.algorithm, dnsk.publish, dnsk.active, dnsk.retire, dnsk.dead, dnsk.keytype " cur = db.execute("SELECT kp.HSMkey_id, kp.generate, kp.algorithm, dnsk.publish, dnsk.active, dnsk.retire, dnsk.dead, dnsk.keytype "
"FROM keypairs AS kp JOIN dnsseckeys AS dnsk ON kp.id = dnsk.id " "FROM keypairs AS kp JOIN dnsseckeys AS dnsk ON kp.id = dnsk.keypair_id "
"WHERE dnsk.zone_id = ?", (zone_id,)) "WHERE dnsk.zone_id = ?", (zone_id,))
keys = {} keys = {}
for row in cur: for row in cur: