parameters: move the confirm kwarg to Param

Whether a parameter is treated like password is determined by the
`password` class attribute defined in the Param class. Whether the CLI will
asks for confirmation of a password parameter depends on the value of the
`confirm` kwarg of the Password class.

Move the `confirm` kwarg from the Password class to the Param class, so
that it can be used by any Param subclass which has the `password` class
attribute set to True.

This fixes confirmation of the --key option of otptoken-add, which is a
Bytes subclass with `password` set to True.

https://fedorahosted.org/freeipa/ticket/6174

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: David Kupka <dkupka@redhat.com>
This commit is contained in:
Jan Cholasta authored and David Kupka committed 2016-08-10 08:51:39 +02:00
1 parent 771dea5c6b
commit e9c1d21b9f
3 files changed
+3 -9

No files matched your search

+1 -1
View File
@@ -167,7 +167,7 @@ class _SchemaPlugin(object):
elif key in ('cli_metavar',
'cli_name'):
kwargs[key] = str(value)
elif key == 'confirm' and issubclass(cls, Password):
elif key == 'confirm':
kwargs[key] = value
elif key == 'default':
default = value