From ea0e6a3663f579280eb8a7a7cbff9f278de2e3b8 Mon Sep 17 00:00:00 2001 From: Stanislav Levin Date: Sun, 16 Sep 2018 23:14:45 +0300 Subject: [PATCH] Add a title to 'remove' dialog for details of 'HBAC' entity To improve translation quality the title of 'Remove' dialog, which is initialized within details of the entity, should be specified explicitly in the spec and should be an entire sentence. Fixes: https://pagure.io/freeipa/issue/7702 Reviewed-By: Serhii Tsymbaliuk --- install/ui/src/freeipa/hbac.js | 6 ++++-- ipaserver/plugins/internal.py | 8 ++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/install/ui/src/freeipa/hbac.js b/install/ui/src/freeipa/hbac.js index 674de79d4..193b89c39 100644 --- a/install/ui/src/freeipa/hbac.js +++ b/install/ui/src/freeipa/hbac.js @@ -153,7 +153,8 @@ return { name: 'description', width: '100px' } - ] + ], + remove_title: '@i18n:objects.hbacsvc.remove_from_hbacsvcgroups', } ], standard_association_facets: true, @@ -215,7 +216,8 @@ return { name: 'description', width: '100px' } - ] + ], + remove_title: '@i18n:objects.hbacsvcgroup.remove_hbacsvcs', } ], standard_association_facets: true, diff --git a/ipaserver/plugins/internal.py b/ipaserver/plugins/internal.py index d82ec25a5..a23b3268a 100644 --- a/ipaserver/plugins/internal.py +++ b/ipaserver/plugins/internal.py @@ -670,9 +670,17 @@ class i18n_messages(Command): }, "hbacsvc": { "remove": _("Remove HBAC services"), + "remove_from_hbacsvcgroups": _( + "Remove HBAC service '${primary_key}' from HBAC service " + "groups" + ), }, "hbacsvcgroup": { "remove": _("Remove HBAC service groups"), + "remove_hbacsvcs": _( + "Remove HBAC services from HBAC service group " + "'${primary_key}'" + ), "services": _("Services"), }, "hbactest": {