IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2025-01-12 17:21:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

ui_tests: checkbox click fix

Browse Source 
We check a box with clicking on label by default however sometimes
when a label is too short (1-2 letters) we are hitting an issue
that the checkbox obscures the label.

https://pagure.io/freeipa/issue/7547

Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
This commit is contained in:
Michal Reznik 2018-05-10 14:35:21 +02:00
parent 23c23a3cc1
commit ef3f0851f4
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ipatests/test_webui/ui_driver.py
View File

@ -42,6 +42,7 @@ try:
from selenium.common.exceptions import InvalidElementStateException from selenium.common.exceptions import InvalidElementStateException
from selenium.common.exceptions import StaleElementReferenceException from selenium.common.exceptions import StaleElementReferenceException
from selenium.common.exceptions import WebDriverException from selenium.common.exceptions import WebDriverException
from selenium.common.exceptions import ElementClickInterceptedException
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
from selenium.webdriver.common.keys import Keys from selenium.webdriver.common.keys import Keys
from selenium.webdriver.common.by import By from selenium.webdriver.common.by import By
@ -912,15 +913,21 @@ class UI_driver(object):
s += "[@value='%s']" % value s += "[@value='%s']" % value
opts = self.find(s, "xpath", parent, many=True) opts = self.find(s, "xpath", parent, many=True)
label = None label = None
checkbox = None
# Select only the one which matches exactly the name # Select only the one which matches exactly the name
for o in opts: for o in opts:
n = o.get_attribute("name") n = o.get_attribute("name")
if n == name or re.match("^%s\d+$" % name, n): if n == name or re.match("^%s\d+$" % name, n):
s = "label[for='%s']" % o.get_attribute("id") s = "label[for='%s']" % o.get_attribute("id")
label = self.find(s, By.CSS_SELECTOR, parent, strict=True) label = self.find(s, By.CSS_SELECTOR, parent, strict=True)
checkbox = o
break break
assert label is not None, "Option not found: %s" % name assert label is not None, "Option not found: %s" % name
try:
label.click() label.click()
except ElementClickInterceptedException:
checkbox.click()
def select_combobox(self, name, value, parent=None, combobox_input=None): def select_combobox(self, name, value, parent=None, combobox_input=None):
""" """