mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2026-08-13 06:25:00 -05:00
Remove duplicate and unused utility code
IPA has some unused code from abandoned features (Radius, ipa 1.x user
input, commant-line tab completion), as well as some duplicate utilities.
This patch cleans up the utility modules.
Duplicate code consolidated into ipapython.ipautil:
{ipalib.util,ipaserver.ipautil,ipapython.ipautil}.realm_to_suffix
{ipaserver,ipapython}.ipautil.CIDict
(with style improvements from the ipaserver version)
{ipapython.entity,ipaserver.ipautil}.utf8_encode_value
{ipapython.entity,ipaserver.ipautil}.utf8_encode_values
ipalib.util.get_fqdn was removed in favor of the same function in
ipaserver.install.installutils
Removed unused code:
ipalib.util:
load_plugins_in_dir
import_plugins_subpackage
make_repr (was imported but unused; also removed from tests)
ipapython.ipautil:
format_list
parse_key_value_pairs
read_pairs_file
read_items_file
user_input_plain
AttributeValueCompleter
ItemCompleter
ipaserver.ipautil:
get_gsserror (a different version exists in ipapython.ipautil)
ipaserver.ipautil ended up empty and is removed entirely.
https://fedorahosted.org/freeipa/ticket/2650
This commit is contained in:
committed by
Martin Kosek
parent
c02fcf5d34
commit
f19218f7d8
@@ -21,11 +21,13 @@
|
||||
Joining an IPA domain
|
||||
"""
|
||||
|
||||
import krbV
|
||||
|
||||
from ipalib import api, util
|
||||
from ipalib import Command, Str
|
||||
from ipalib import errors
|
||||
import krbV
|
||||
from ipalib import _
|
||||
from ipaserver.install import installutils
|
||||
|
||||
def get_realm():
|
||||
"""
|
||||
@@ -52,7 +54,7 @@ class join(Command):
|
||||
validate_host,
|
||||
cli_name='hostname',
|
||||
doc=_("The hostname to register as"),
|
||||
default_from=lambda: unicode(util.get_fqdn()),
|
||||
default_from=lambda: unicode(installutils.get_fqdn()),
|
||||
autofill=True,
|
||||
#normalizer=lamda value: value.lower(),
|
||||
),
|
||||
|
||||
Reference in New Issue
Block a user