IntenseWebs/freeipa
3
0
Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2024-12-23 07:33:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

pylint: make unsupported-assignment-operation check local

Browse Source 
unsupported-assignment-operation is useful at times, make it only
local, not global.

https://pagure.io/freeipa/issue/6874

Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
This commit is contained in:
Stanislav Laznicka 2017-08-22 14:06:22 +02:00
parent 33f13b6df9
commit f2701f3a0b
6 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
freeipa.spec.in
View File

@ -175,7 +175,7 @@ BuildRequires: python-gssapi >= 1.2.0-5
%if 0%{?fedora} >= 26 %if 0%{?fedora} >= 26
BuildRequires: python2-pylint BuildRequires: python2-pylint
%else %else
BuildRequires: pylint >= 1.6 BuildRequires: pylint >= 1.7
%endif %endif
# workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506 # workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506
BuildRequires: python2-polib BuildRequires: python2-polib
@ -214,7 +214,7 @@ BuildRequires: python2-augeas
# 1.6: x509.Name.rdns (https://github.com/pyca/cryptography/issues/3199) # 1.6: x509.Name.rdns (https://github.com/pyca/cryptography/issues/3199)
BuildRequires: python3-cryptography >= 1.6 BuildRequires: python3-cryptography >= 1.6
BuildRequires: python3-gssapi >= 1.2.0 BuildRequires: python3-gssapi >= 1.2.0
BuildRequires: python3-pylint >= 1.6 BuildRequires: python3-pylint >= 1.7
# workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506 # workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506
BuildRequires: python3-polib BuildRequires: python3-polib
BuildRequires: python3-libipa_hbac BuildRequires: python3-libipa_hbac

2
ipalib/cli.py
View File

@ -999,7 +999,9 @@ class Collector(object):
value = v + (value,) value = v + (value,)
else: else:
value = (v, value) value = (v, value)
# pylint: disable=unsupported-assignment-operation
self.__options[name] = value self.__options[name] = value
# pylint: enable=unsupported-assignment-operation
object.__setattr__(self, name, value) object.__setattr__(self, name, value)
def __todict__(self): def __todict__(self):

2
ipalib/config.py
View File

@ -273,7 +273,9 @@ class Env(object):
if type(value) not in (unicode, int, float, bool, type(None), DN): if type(value) not in (unicode, int, float, bool, type(None), DN):
raise TypeError(key, value) raise TypeError(key, value)
object.__setattr__(self, key, value) object.__setattr__(self, key, value)
# pylint: disable=unsupported-assignment-operation
self.__d[key] = value self.__d[key] = value
# pylint: enable=unsupported-assignment-operation
def __getitem__(self, key): def __getitem__(self, key):
""" """

2
ipaserver/plugins/schema.py
View File

@ -377,8 +377,10 @@ class topic_(MetaObject):
'full_name': topic_full_name, 'full_name': topic_full_name,
} }
topics.append(topic) topics.append(topic)
# pylint: disable=unsupported-assignment-operation
topics_by_key[topic_name] = topic topics_by_key[topic_name] = topic
topics_by_key[topic_full_name] = topic topics_by_key[topic_full_name] = topic
# pylint: enable=unsupported-assignment-operation
for package in self.api.packages: for package in self.api.packages:
module_name = '.'.join((package.__name__, topic_name)) module_name = '.'.join((package.__name__, topic_name))

3
ipatests/test_ipapython/test_dn.py
View File

@ -528,6 +528,7 @@ class TestRDN(unittest.TestCase):
def test_assignments(self): def test_assignments(self):
rdn = RDN((self.attr1, self.value1)) rdn = RDN((self.attr1, self.value1))
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
# pylint: disable=unsupported-assignment-operation
rdn[0] = self.ava2 rdn[0] = self.ava2
def test_iter(self): def test_iter(self):
@ -954,8 +955,10 @@ class TestDN(unittest.TestCase):
def test_assignments(self): def test_assignments(self):
dn = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9') dn = DN('t=0,t=1,t=2,t=3,t=4,t=5,t=6,t=7,t=8,t=9')
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
# pylint: disable=unsupported-assignment-operation
dn[0] = RDN('t=a') dn[0] = RDN('t=a')
with self.assertRaises(TypeError): with self.assertRaises(TypeError):
# pylint: disable=unsupported-assignment-operation
dn[0:1] = [RDN('t=a'), RDN('t=b')] dn[0:1] = [RDN('t=a'), RDN('t=b')]
def test_iter(self): def test_iter(self):

1
pylintrc
View File

@ -92,7 +92,6 @@ disable=
useless-super-delegation, # new in pylint 1.7 useless-super-delegation, # new in pylint 1.7
redefined-argument-from-local, # new in pylint 1.7 redefined-argument-from-local, # new in pylint 1.7
consider-merging-isinstance, # new in pylint 1.7 consider-merging-isinstance, # new in pylint 1.7
unsupported-assignment-operation # new in pylint 1.7
[REPORTS] [REPORTS]