From f67268db6855738350481491119b9be29ba1f22d Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Mon, 22 Apr 2013 17:09:47 +0200 Subject: [PATCH] Improve error message on failed Kerberos authentication When ipa client installation fails due to failed Kerberos authentication, make sure that the message about the failed authentication is displayed last. This makes it clear to the user that this was the reason for failed installation. https://fedorahosted.org/freeipa/ticket/3573 Reviewed-By: Petr Viktorin --- ipa-client/ipa-install/ipa-client-install | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipa-client/ipa-install/ipa-client-install b/ipa-client/ipa-install/ipa-client-install index 0d6037bd1..7cc0c3397 100755 --- a/ipa-client/ipa-install/ipa-client-install +++ b/ipa-client/ipa-install/ipa-client-install @@ -2292,9 +2292,9 @@ def install(options, env, fstore, statestore): stdin=stdin, env=env) if returncode != 0: + print_port_conf_info() root_logger.error("Kerberos authentication failed") root_logger.info("%s", stdout) - print_port_conf_info() return CLIENT_INSTALL_ERROR elif options.keytab: join_args.append("-f") @@ -2306,10 +2306,10 @@ def install(options, env, fstore, statestore): raiseonerr=False) if returncode != 0: + print_port_conf_info() root_logger.error("Kerberos authentication failed " "using keytab: %s", options.keytab) root_logger.info("%s", stdout) - print_port_conf_info() return CLIENT_INSTALL_ERROR else: root_logger.error("Keytab file could not be found: %s"