mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-02-25 18:55:28 -06:00
DNS install check: Fix overlapping DNS zone from the master itself
The change to allow overlapping zone to be from the master itself has introduced two issues: The check for the master itself should only executed if options.force and options.allow_zone_overlap are both false and the reverse zone check later on was still handling ValueError instead of dnsutil.DNSZoneAlreadyExists. Both issues have been fixed and the deployment with existing name servers is properly working again. Fixes: https://pagure.io/freeipa/issue/8150 Signed-off-by: Thomas Woerner <twoerner@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
This commit is contained in:
@@ -135,7 +135,7 @@ def install_check(standalone, api, replica, options, hostname):
|
||||
logger.warning("%s Please make sure that the domain is "
|
||||
"properly delegated to this IPA server.",
|
||||
e)
|
||||
|
||||
else:
|
||||
hst = dnsutil.DNSName(hostname).make_absolute().to_text()
|
||||
if hst not in e.kwargs['ns']:
|
||||
raise ValueError(str(e))
|
||||
@@ -143,7 +143,7 @@ def install_check(standalone, api, replica, options, hostname):
|
||||
for reverse_zone in options.reverse_zones:
|
||||
try:
|
||||
dnsutil.check_zone_overlap(reverse_zone)
|
||||
except ValueError as e:
|
||||
except dnsutil.DNSZoneAlreadyExists as e:
|
||||
if options.force or options.allow_zone_overlap:
|
||||
logger.warning('%s', str(e))
|
||||
else:
|
||||
|
||||
Reference in New Issue
Block a user