ipalib: Load ipaserver plugins when api.env.in_server is True

https://fedorahosted.org/freeipa/ticket/3090
https://fedorahosted.org/freeipa/ticket/5073

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>

daemons/dnssec/ipa-dnskeysyncd

@@ -17,7 +17,6 @@ from ipapython.dn import DN
 from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython import ipaldap
 from ipapython import ipautil
-from ipaserver.plugins.ldap2 import ldap2
 from ipaplatform.paths import paths
 
 from ipapython.dnssec.keysyncer import KeySyncer

install/tools/ipa-replica-manage

@@ -31,7 +31,6 @@ from ipapython import ipautil
 from ipaserver.install import replication, dsinstance, installutils
 from ipaserver.install import bindinstance, cainstance, certs
 from ipaserver.install import opendnssecinstance, dnskeysyncinstance
-from ipaserver.plugins import ldap2
 from ipapython import version, ipaldap
 from ipalib import api, errors, util
 from ipalib.constants import CACERT

ipalib/__init__.py

@@ -905,7 +905,7 @@ class API(plugable.API):
     def bootstrap(self, parser=None, **overrides):
         super(API, self).bootstrap(parser, **overrides)
 
-        if self.env.context in ('server', 'lite'):
+        if self.env.in_server:
             self.packages.append('ipaserver')
         if self.env.context in ('installer', 'updates'):
             self.packages.append('ipaserver/install/plugins')

ipalib/plugins/baseuser.py

@@ -38,8 +38,6 @@ from ipapython.ipavalidate import Email
 from ipalib.capabilities import client_has_capability
 from ipalib.util import (normalize_sshpubkey, validate_sshpubkey,
     convert_sshpubkey_post)
-if api.env.in_server and api.env.context in ['lite', 'server']:
-    from ipaserver.plugins.ldap2 import ldap2
 
 __doc__ = _("""
 Baseuser

ipalib/plugins/stageuser.py

@@ -42,8 +42,6 @@ from ipapython.ipavalidate import Email
 from ipalib.capabilities import client_has_capability
 from ipalib.util import (normalize_sshpubkey, validate_sshpubkey,
     convert_sshpubkey_post)
-if api.env.in_server and api.env.context in ['lite', 'server']:
-    from ipaserver.plugins.ldap2 import ldap2
 
 __doc__ = _("""
 Stageusers

ipalib/plugins/user.py

@@ -44,7 +44,7 @@ from ipapython.ipavalidate import Email
 from ipalib.capabilities import client_has_capability
 from ipalib.util import (normalize_sshpubkey, validate_sshpubkey,
     convert_sshpubkey_post)
-if api.env.in_server and api.env.context in ['lite', 'server']:
+if api.env.in_server:
     from ipaserver.plugins.ldap2 import ldap2
 
 __doc__ = _("""

ipapython/dnssec/ldapkeydb.py

@@ -11,7 +11,6 @@ import ipalib
 from ipapython.dn import DN
 from ipapython import ipaldap
 from ipapython import ipautil
-from ipaserver.plugins.ldap2 import ldap2
 from ipaplatform.paths import paths
 
 from abshsm import attrs_name2id, attrs_id2name, bool_attr_names, populate_pkcs11_metadata, AbstractHSM

ipaserver/dcerpc.py

@@ -31,7 +31,6 @@ from ipapython import ipautil
 from ipapython.ipa_log_manager import *
 from ipapython.dn import DN
 from ipaserver.install import installutils
-from ipaserver.plugins import ldap2
 from ipalib.util import normalize_name
 
 import os, string, struct, copy

ipaserver/install/bindinstance.py

@@ -29,7 +29,6 @@ import ldap
 
 import installutils
 import service
-from ipaserver.plugins import ldap2
 from ipaserver.install.cainstance import IPA_CA_RECORD
 from ipapython import sysrestore, ipautil, ipaldap
 from ipapython.ipa_log_manager import *

ipaserver/install/ipa_server_certinstall.py

@@ -31,7 +31,7 @@ from ipapython.ipautil import user_input, write_tmp_file
 from ipalib import api, errors
 from ipalib.constants import CACERT
 from ipaserver.install import certs, dsinstance, httpinstance, installutils
-from ipaserver.plugins.ldap2 import ldap2
+
 
 class ServerCertInstall(admintool.AdminTool):
     command_name = 'ipa-server-certinstall'

ipaserver/install/ipa_server_upgrade.py

@@ -41,7 +41,6 @@ class ServerUpgrade(admintool.AdminTool):
         super(ServerUpgrade, self).run()
 
         api.bootstrap(in_server=True, context='updates')
-        import ipaserver.plugins.dogtag  # ensure profile backend gets loaded
         api.finalize()
 
         try:

ipaserver/install/ldapupdate.py

@@ -45,7 +45,6 @@ from ipaplatform import services
 from ipapython.dn import DN
 from ipapython.ipa_log_manager import *
 from ipapython.ipautil import wait_for_open_socket
-from ipaserver.plugins import ldap2
 
 UPDATES_DIR=paths.UPDATES_DIR
 

ipaserver/install/plugins/update_managed_permissions.py

@@ -91,7 +91,6 @@ from ipalib.plugins.permission import permission, permission_del
 from ipalib.aci import ACI
 from ipalib import Updater
 from ipapython import ipautil
-from ipaserver.plugins.ldap2 import ldap2
 
 register = Registry()
 

ipaserver/install/server/install.py

@@ -592,9 +592,6 @@ def install_check(installer):
         api.env.ca_host = host_name
 
     api.bootstrap(**cfg)
-    if setup_ca:
-        # ensure profile backend is available
-        import ipaserver.plugins.dogtag
     api.finalize()
 
     if setup_ca:

ipaserver/rpcserver.py

@@ -748,7 +748,8 @@ class jsonserver_session(jsonserver, KerberosSession):
 
     def __init__(self):
         super(jsonserver_session, self).__init__()
-        auth_mgr = AuthManagerKerb(self.__class__.__name__)
+        name = '{0}_{1}'.format(self.__class__.__name__, id(self))
+        auth_mgr = AuthManagerKerb(name)
         session_mgr.auth_mgr.register(auth_mgr.name, auth_mgr)
 
     def _on_finalize(self):
@@ -1200,7 +1201,8 @@ class xmlserver_session(xmlserver, KerberosSession):
 
     def __init__(self):
         super(xmlserver_session, self).__init__()
-        auth_mgr = AuthManagerKerb(self.__class__.__name__)
+        name = '{0}_{1}'.format(self.__class__.__name__, id(self))
+        auth_mgr = AuthManagerKerb(name)
         session_mgr.auth_mgr.register(auth_mgr.name, auth_mgr)
 
     def _on_finalize(self):

makeaci

@@ -95,6 +95,7 @@ def main(options):
         basedn=DN('dc=ipa,dc=example'),
         realm='IPA.EXAMPLE',
     )
+    from ipaserver.plugins import ldap2
     from ipaserver.install.plugins.update_managed_permissions import (
         update_managed_permissions)
     from ipalib.plugins.permission import permission