Convert string values to boolean when generating environment

ipalib/config.py

@@ -25,25 +25,41 @@ DEFAULT_CONF='/etc/ipa/ipa.conf'
 
 def generate_env(d={}):
     default = dict(
-        server_context = True,
+        basedn = 'dc=example,dc=com',
-        query_dns = True,
+        container_user = 'cn=users,cn=accounts',
-        verbose = False,
-        interactive = True,
-        server = LazyIter(get_servers),
-        realm = LazyProp(get_realm),
         domain = LazyProp(get_domain),
-        container_user='cn=users,cn=accounts',
+        interactive = True,
-        basedn='dc=example,dc=com',
+        query_dns = True,
+        realm = LazyProp(get_realm),
+        server_context = True,
+        server = LazyIter(get_servers),
+        verbose = False,
     )
     for key, value in d.iteritems():
-        if key in default and type(default[key]) in (LazyIter, LazyProp):
+        if key in default:
+            if isinstance(default[key], (LazyIter, LazyProp)):
                 default[key].set_value(value)
+            else:
+                default[key] = convert_val(type(default[key]), value)
         else:
              default[key] = value
 
     return default
 
 
+# TODO: Add a validation function
+def convert_val(target_type, value):
+    bool_true = ('true', 'yes', 'on')
+    bool_false = ('false', 'no', 'off')
+
+    if target_type == bool and isinstance(value, basestring):
+        if value.lower() in bool_true:
+            return True
+        elif value.lower() in bool_false:
+            return False
+    return target_type(value)
+
+
 class LazyProp(object):
     def __init__(self, func, value=None):
         assert isinstance(func, types.FunctionType)
@@ -73,6 +89,8 @@ class LazyIter(LazyProp):
                 yield item
 
 
+# TODO: Make it possible to use var = 'foo, bar' without
+#       turning it into ("'foo", "bar'")
 def read_config(config_file=None):
     assert config_file == None or isinstance(config_file, (basestring, file))
 

ipalib/plugins/f_user.py

@@ -47,6 +47,7 @@ class envtest(frontend.Command):
                 print ""
             else:
                 print "  %s: %s" % (var, val)
+        return {}
 api.register(envtest)
 
 

tests/test_ipalib/test_config.py

@@ -37,8 +37,11 @@ def test_generate_env():
         query_dns = False,
         server = ('first', 'second'),
         realm = 'myrealm',
+        # test right conversions
+        server_context = 'off',
     )
     d = config.generate_env(env)
+    assert d['server_context'] == False
     assert d['query_dns'] == False
 
     # Make sure the servers is overwrote properly (that it is still LazyProp)