Commit Graph

40 Commits

Author SHA1 Message Date
Endi S. Dewata
b2cd8f0abf Fixed missing permission filter field.
Due to a recent change, all dialog boxes are now reset initially. The
IPA.target_section has been modified to show the default target (i.e.
filter) and the fields properly when reset.

Ticket #1748
2011-09-01 14:12:20 +00:00
Endi S. Dewata
d08dcb40e1 Fixed facet group labels.
The facet group labels have been modified according to UXD spec.
Some facet groups will have more descriptive labels. Some others
will not have any labels because the facet tab is self-explanatory.

Ticket #1423, #1561
2011-08-08 12:00:07 -04:00
Adam Young
b36df6e9b9 removing setters setup and init
change widget and widget unit tests to hold on to entity, not entity name.
    Replacing entity_name with entity.name  in most places.
       The one exception is columns for table_widget.
       Widgets that refer to other entities have to have late resolution of the entity object, due to circular dependencies.

    cleanup entity assignment.
    removed template and layout,
    merged setup into create
    adder dialogs adjust height for external
    removed init from widget, isection, association, facet, host and service

    Make unit tests use factory.
    fix functional tests to click find link correctly.
    tweak to activation test, but still broken.
    moved initialization code to the end
    use --all for hbacrule find, so the type shows up now

    fixed dns exception code and exception handling for get_entity
    replace metadata look up with value from entity.
    fixed author lines
    removed duplicate columns in managed by facets.
    tweak to nav fix in order to initialize tab.
    more defensive code
    update metadata for true false
    one line init for entity_name in widget
    move init code to end of constructor functions
    moved constants to start of function for adder_dialog
    external fields for dialogs initialized at dialog creation
    sudo sections: move add fields and columns to widget definition.

   The parameter validation in IPA.column ...This is precondition checking.  Note that it merely throws an exception if the entity_name is not set.  I want this stuff at the top of the function so that it is obvious to people looking to use them what is required.  I added a comment to make this clear, but I'd like to keep precondition checking at the top of the function.

   decreased the scope of the pkey_name and moved the initiailzation fof columns into the setup_column function for association_tables

   return false at the end of click handler

   removed blank labels in sudo command section

   fix radio buttons for sudo category

   fixed table side for adder dialogs with external fields
    comments for future direction with add_columns

    https://fedorahosted.org/freeipa/ticket/1451
    https://fedorahosted.org/freeipa/ticket/1462
    https://fedorahosted.org/freeipa/ticket/1493
    https://fedorahosted.org/freeipa/ticket/1497
    https://fedorahosted.org/freeipa/ticket/1532
    https://fedorahosted.org/freeipa/ticket/1534
2011-07-28 14:17:25 -04:00
Endi S. Dewata
571274e978 Entity select widget improvements
The IPA.entity_select_widget has been modified into a searchable and
editable drop down list. The base functionality has been extracted
into IPA.combobox_widget.

Ticket #1361
2011-07-18 14:47:57 -04:00
Adam Young
800cb7f46e identify target as section for permissions 2011-06-27 12:14:49 -04:00
Adam Young
dbeae4e3f4 test dirty onchange
instead of blindly setting dirty, check if the filed has a different value than it originally did.

https://fedorahosted.org/freeipa/ticket/1337
2011-06-16 20:29:14 +00:00
Adam Young
4080a03051 dialog scrolling table
Tables on the dialog page need to have the scrolling set but should not resize with the main window, since their window is a JQuery UI dialog.
2011-06-03 19:54:14 +00:00
Endi S. Dewata
aa29a8a769 Added Update and Reset buttons into Dirty dialog.
The Dirty dialogs have been combined into IPA.dirty_dialog. It
provides the Update and Reset buttons with customizable callback.

Previously the widget's dirty status is computed by comparing the
old values with the new values. This method is sometimes inaccurate,
so the is_dirty() method has been modified to simply return a flag
which is set to true if the widget is changed.

Ticket #896.
2011-05-27 13:06:57 -04:00
Endi S. Dewata
3528b4eca3 Moved adder dialog box into entity.
The adder dialog box definition has been moved from search facet
into entity to make it accessible from other facets.
2011-04-21 19:43:54 +00:00
Martin Kosek
d9c1761234 Remove unwanted trimming in text fields
UI trims whitespace at the beginning or at the end when user data
are being saved. This confuses is_dirty function which incorrectly
recognizes given field as modified.

This patch fixes this issue for both general text fields and
ACI filter field.

https://fedorahosted.org/freeipa/ticket/1096
2011-04-21 19:03:03 +00:00
Adam Young
6948c0813d code review fixes
this version includes using spec for detail_facets
2011-03-31 17:29:33 -04:00
Adam Young
4270e26adb define entities using builder and more declarative syntax
merged hbac and sudo in to single files

associaton facet and table supports linking
2011-03-31 17:29:33 -04:00
Endi S. Dewata
cb5e709e7d Fixed undefined label in permission adder dialog box.
The IPA.rights_widget was fixed to invoke the base init() method
to load the i18n labels properly.

Ticket 1113
2011-03-29 17:52:19 -04:00
Endi S. Dewata
4a8c43aa32 I18n update.
Hard-coded messages through out the code have been replaced by i18n
messages obtained from json_metadata and i18n_messages.
2011-02-21 15:36:32 -05:00
Endi S. Dewata
eb8f091c9b Fixed association facets.
The association config has been removed because it incorrectly assumes there is only one association between two entities. Now each association is defined separately using association facets.

The service.py has been modified to specify the correct relationships. The API.txt has been updated.

https://fedorahosted.org/freeipa/ticket/960
2011-02-15 17:45:46 -05:00
Adam Young
d14ef576c3 column formatting Allow optional formatting for columns Provide Data formate for host modificaiton
date format
2011-02-11 15:04:31 -05:00
Adam Young
6f6d50f37f target section without radio buttons ACI target section refactored into an array of widget-like objects. The radio buttons have been replaced by a select box. THe select is not visible on the details page. 2011-02-11 15:04:31 -05:00
Endi S. Dewata
8d597dcbb0 Moved add dialog into search facet.
Previously the add dialog is added into entity. The dialog is only
used by the search facet, so it's now moved into the search facet.
2011-02-09 19:46:49 -05:00
Endi S. Dewata
348d734c59 Restructuring details page.
Previously the IPA.details_list_section can only be used with widgets
that generates <dd> tag because it uses the following structure:

<dl>
  <dt>Telephone Number:</dt>
  <span name="teleponenumber">
    <dd>111-1111</dd>
    <dd>222-2222</dd>
  </span>
</dl>

The <dd> tag was previously used to handle multi-valued attributes.
Since multi-valued attributes are now handled by the recently added
IPA.multivalued_text_widget, the structure can be changed as follows:

<dl>
  <dt>Telephone Number:</dt>
  <dd>
    <span name="telephonenumber">
      <div>111-1111</div>
      <div>222-2222</div>
    </span>
  </dd>
</dl>

This allows IPA.details_list_section to be used with any widgets
without requiring the <dd> tag.
2011-02-07 11:31:17 -05:00
Endi S. Dewata
d389e054f6 Added undo for permission target.
https://fedorahosted.org/freeipa/ticket/885
2011-02-02 15:56:50 -05:00
Adam Young
ec59e618da use entity select widget for permissions
https://fedorahosted.org/freeipa/ticket/879
2011-02-01 14:56:41 -05:00
Endi S. Dewata
8cff0812d5 Fixed attribute name for delegation member group. 2011-02-01 12:03:45 -05:00
Endi S. Dewata
613a3d0f56 Added undo for permission rights.
https://fedorahosted.org/freeipa/ticket/884
2011-02-01 08:30:35 -05:00
Adam Young
f85771b2a7 aci association fixes
declarative priv definition
fixes role_add_privilege and privilege_add_permisison
2011-01-31 23:09:13 -05:00
Endi S. Dewata
a629f3f4c7 Removed permission description from UI
https://fedorahosted.org/freeipa/ticket/877
2011-01-31 15:06:47 -05:00
Adam Young
de28abc236 delegation work around
Since the delegation enityt is using membergroup as the property name at this stage, we can use that as the value until the pluing is consistant
2011-01-29 23:16:08 -05:00
Adam Young
20e742d355 populate attribute table for delegation add 2011-01-29 22:08:27 -05:00
Endi S. Dewata
8df5202940 Fixed permission reset and is_dirty.
The reset and is_dirty functionality for permission has been fixed.
New widgets have been created for select and a collection of checkboxes.
New test data files have been added for each target type.
2011-01-29 21:23:01 -05:00
Adam Young
e633dd81dd placeholder function
ipa_target_section does not overload is_dirty, and it alwayrs returns true, meaning you can never leave the page once you visit it.

THis commit pushes a simple placeholder function that always returns fales.  Follow on work will be required to correctly inplement the is_dirty functonality
2011-01-29 14:24:00 -05:00
Endi S. Dewata
e806f32cae Add permission dialog adjustments.
The IPA.dialog has been modified to support sections. The add
dialog for permission has been modified to include the target
section. The base dialog classes have been moved from widget.js
into a new file called dialog.js.

This patch also includes ayoung's fix for parameter name and
format for the permission attributes.

https://fedorahosted.org/freeipa/ticket/791
2011-01-29 13:36:03 -05:00
Adam Young
fd1d0857b5 unmatched aciattrs
instead of reporting an error on unmatched aciattrs, append them to the table.
2011-01-28 17:01:19 -05:00
Endi S. Dewata
b96138ba56 Fixed delegation UI issues
This patch fixes several issues in delegation UI:

When adding a new delegation, only the first attribute selected
was saved. Now all attributes will be saved properly.

When loading the details page, the custom widgets did not store
the original values properly so is_dirty() did not work correctly.
Now this has been fixed except for the memberof attribute because
of these issues:
 - https://fedorahosted.org/freeipa/ticket/869
 - https://fedorahosted.org/freeipa/ticket/870

When saving the details page, the attrs were saved as an array
which was rejected by the server. Now it is stored as comma-
separated list.
2011-01-28 14:15:43 -05:00
Adam Young
c75f332af9 aci rights widget
Fixes is_dirty and save

https://fedorahosted.org/freeipa/ticket/77
https://fedorahosted.org/freeipa/ticket/667
2011-01-28 10:37:49 -05:00
Adam Young
114c238a9b entity filter text 2011-01-28 10:37:49 -05:00
Adam Young
b1c4fc3e6d reset target section target section needed to cache results for use in results moved load logic into reset and load now calls reset 2011-01-27 16:53:02 -05:00
Adam Young
c3e0658790 declarative for aci
A couple of the ACI definitions were incorrect, and the end result was that fields were not getting initialized.  USing the declarative approach cleaned up the cause.

Also fixed a few broken unit tests
2011-01-27 16:49:11 -05:00
Adam Young
f904df0f0d declarative defintions
Delay the creation of entities until after ipa init is called
made the user and group entity definitions declarative
removed unused facet from groups
adjusted unit tests

made review changes:

factories are now in an associative array
entity init called right after factory
init dialogs in entity init
fixed type on search
2011-01-27 16:46:44 -05:00
Adam Young
5ca58d58b3 target style cleanup
Target section had radio buttonsreversed, and a few other style changes
Note that this has the styling removed for the aci-target dl items
2011-01-26 16:23:12 -05:00
Adam Young
32c74fccef aci attribute table two columns 2011-01-25 13:11:43 -05:00
Adam Young
b9ad279ad2 rename static to ui
Directory rename
2011-01-20 14:12:47 +00:00