IntenseWebs/freeipa
3
0 Fork 0
mirror of https://salsa.debian.org/freeipa-team/freeipa.git synced 2026-10-25 22:50:12 -05:00
Code Issues Packages Projects Releases Wiki Activity
9,339 Commits 11 Branches 63 Tags
278fa29906093ead4977ae68eb3bf37613329102
Commit Graph
648 Commits
Author SHA1 Message Date
Jan Cholasta 13b010685b frontend: remove the unused Command.soft_validate method 
https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Jan Cholasta 2f6b333187 frontend: re-raise remote RequirementError using CLI name in CLI 
https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Jan Cholasta e0275abe6f rpc: include structured error information in responses 
Include keyword arguments of exceptions in RPC responses. This is limited
to JSON-RPC, as XML-RPC does not support additional data in error
responses.

Include keyword arguments of messages in RPC responses.

Include keyword arguments of exceptions in batch command result.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Jan Cholasta 861294c0d6 parameters: remove unused ConversionError and ValidationError arguments 
Do not set the `value`, `index` and `rule` arguments when raising
ConversionError and ValidationError. The arguments are unused and are not
specified consistently accross the framework and plugins.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-25 16:06:26 +02:00
Lenka Doudova d71de186cc Test: Maximum username length higher than 255 cannot be set 
https://fedorahosted.org/freeipa/ticket/5774

Reviewed-By: Ganna Kaihorodova <gkaihoro@redhat.com>
 2016-05-24 10:39:14 +02:00
Peter Lacko 144a367d35 Ping module tests. 
Test for ping module rewritten using non-declarative way.
No new functionality has been added.

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-18 17:19:05 +02:00
Oleg Fayans 84e5065b39 Added necessary A record for the replica to root zone 
A master can only be delegated a zone authority, if this zone contains A
records of the master and ALL replicas

https://fedorahosted.org/freeipa/ticket/5848

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-11 13:19:13 +02:00
Oleg Fayans 5567dff4b4 A workaround for ticket N 5348 
A freshly created dnssec-enabled zone does not always display the signature
until you restart named-pkcs11. Added restarting of this service after each
dnssec-enabled zone.

https://fedorahosted.org/freeipa/ticket/5348

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-11 13:16:43 +02:00
Petr Viktorin 7d4d819b90 test_cert_plugin: Encode 'certificate' for comparison with 'usercertificate' 
The 'certificate' option is Str, but 'usercertificate' is Bytes.
Decode before comparing one with the other.

Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-10 12:41:15 +02:00
Petr Viktorin 20a6a42567 test_add_remove_cert_cmd: Use bytes for base64.b64encode() 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin bdee890014 radiusproxy plugin tests: Expect bytes, not text, for ipatokenradiussecret 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 14aba1c7c1 range plugin tests: Use bytes with MockLDAP under Python 3 
Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 095d0cb7af xmlrpc_test: Expect bytes rather than strings for binary attributes 
The attributes krbextradata, krbprincipalkey, and userpassword contain
binary data.

Part of the work for: https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin 6406c7a593 xmlrpc_test: Rename exception instance before working with it 
Python 3 unsets the exception variable at the end of an "except"
block to prevent reference cycles and speed up garbage collection.

Store the exception under a different name in order to use it later.

Part of the work for https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Petr Viktorin f753ad322d test_xmlrpc: Use absolute imports 
In Python 3, a module from the current package can be imported
either with the absolute name or by using an explicit relative import.

Part of the work for https://fedorahosted.org/freeipa/ticket/4985

Reviewed-By: Martin Basti <mbasti@redhat.com>
Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-05-05 16:42:46 +02:00
Martin Basti b87a825d74 fix stageuser tests (removal of has_keytab and has_password from find) 
User tests has been fixed, but stageuser tests was forgotten, this
commit fixes it.

https://fedorahosted.org/freeipa/ticket/5281

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-05-05 15:20:19 +02:00
Lenka Doudova 847c950408 Test fix: Cleanup for host certificate 
This fix provides means to remove certificates from host that were added during tests, but not removed.

Ticket: https://fedorahosted.org/freeipa/ticket/5839
Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-05-03 17:12:45 +02:00
Martin Basti fe2ce02a6f Performace: don't download password attributes in host/user-find 
For each entry in user/host-find was executed an extra search for password
attributes what has significant impact on performance (for 2000 users
there were 2000 additional searches)

http://www.freeipa.org/page/V4/Performance_Improvements

https://fedorahosted.org/freeipa/ticket/5281

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-04-22 13:28:57 +02:00
Milan Kubík 0472300dff ipatests: Add test case for requesting a certificate with full principal. 
https://fedorahosted.org/freeipa/ticket/5733

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-21 17:06:54 +02:00
Milan Kubík b0b9972213 ipatests: fix for change_principal context manager 
The context manager was leaving API object disconnected when
an exception was raised inside of it. This led to resource leak
in the tests.

https://fedorahosted.org/freeipa/ticket/5733

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-21 17:06:54 +02:00
Oleg Fayans 1c79c1ea2d Bugfixes in managed topology tests 
Fixed a false negative related to replication taking some time: added
wait_for_replication call before checking for new object in replicas.

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-20 17:59:11 +02:00
Oleg Fayans 1974f20aec Improve reporting of failed tests in topology test suite 
https://fedorahosted.org/freeipa/ticket/5772

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-20 17:59:11 +02:00
Filip Skola 5dfaeca7ce Refactor test_automember_plugin, create AutomemberTracker 
Reviewed-By: Ales 'alich' Marecek <amarecek@redhat.com>
 2016-04-19 10:35:13 +02:00
Oleg Fayans c061172792 Add test if replica is working after domain upgrade 
Corresponds to the testcase described in
http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan#Test_case:
_Replica_created_using_old_workflow_is_functional_after_domain_upgrade

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-15 15:44:09 +02:00
Lenka Doudova 6468a39850 WebUI: Test creating user without private group 
Test for option to create a user without private group in web UI.

Covers ticket https://fedorahosted.org/freeipa/ticket/5804

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-04-15 10:17:20 +02:00
Martin Babinsky 62bb478e11 specify type of exceeded limit when warning about truncated search results 
API commands inheriting from LDAPSearch should mention which limit was
exceeded in the warning message sent with truncated results.

https://fedorahosted.org/freeipa/ticket/5677

Reviewed-By: Petr Spacek <pspacek@redhat.com>
 2016-04-13 17:52:22 +02:00
Oleg Fayans 280f1ed85f Fixed a failure in legacy_client tests 
https://fedorahosted.org/freeipa/ticket/5800

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-13 16:05:12 +02:00
Oleg Fayans ab3b4a92a8 Added 5 more tests to Replica Promotion testsuite 
The following testcases were automated:
1. Test one command replica installation
2. Test csreplica-manage-(del, connect, disconnect) are disabled in domain
level 1
3. Client enrollment and replica promotion by an unprivileged user are
prohibited
4. Replica uninstallation is prohibited if it disconnects a part of existing
topology (is possible only with --ignore-topology-disconnect option)
https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
 2016-04-06 16:02:55 +02:00
Oleg Fayans f836ee7b9c Added a kdestroy call to clean ccache at master/client uninstallation 
https://fedorahosted.org/freeipa/ticket/5741

Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
 2016-04-06 15:59:22 +02:00
Filip Skola 49c015b2ed Refactor test_hostgroup_plugin 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-24 14:38:22 +01:00
Filip Skola ab3f652dc1 Refactor test_nesting, create HostGroupTracker 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-24 14:36:55 +01:00
Oleg Fayans 2fa0952603 Fixed a bug with prepare_host failing upon existing ipatests folder 
https://fedorahosted.org/freeipa/ticket/5748

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-23 17:19:21 +01:00
Oleg Fayans 7289ad16cb Reverted changes in mh fixture causing some tests to fail 
Some integration tests expect the members of topology to have the testfolder.
The testfolder however was created during master and client installations. In
case the client is not intalled from the very beginning of the test execution,
the test would complain about missing testfolder.

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-23 17:19:21 +01:00
Martin Basti ae5bf8291f Fix stageuser-activate - managers test 
https://fedorahosted.org/freeipa/ticket/5481

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-03-23 16:38:26 +01:00
Oleg Fayans d58cd04e8a rewrite a misprocessed teardown_method method as a custom decorator 
teardown_method is a standard pytest method used to put any code to be executed
after each test method is executed. While treated correctly by our integration
tests, this method is misinterpreted by in-tree tests in the following way:
in-tree tests try to execute it even if all the test methods are skipped due to
test resources being not configured. This causes the tests, that otherwise would
have been skipped, to fail

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-23 12:46:23 +01:00
Oleg Fayans c204290038 Added copyright info to replica promotion tests 
https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-22 13:48:45 +01:00
Christian Heimes 49be6c8d3c Move user/group constants for PKI and DS into ipaplatform 
https://fedorahosted.org/freeipa/ticket/5619

Reviewed-By: David Kupka <dkupka@redhat.com>
Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
 2016-03-22 10:40:44 +01:00
Martin Basti da0318d4d7 Pylint: remove unnecessary-semicolon 
Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
 2016-03-22 10:20:51 +01:00
Martin Basti d46cd5d956 Pylint: enable reimported check 
Fixes current reimports and enables pylint check for them

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
 2016-03-22 10:20:51 +01:00
Martin Basti 491447cc5a pylint: remove bare except 
Bare except should not be used.

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
 2016-03-22 10:20:51 +01:00
Martin Basti fb3a5d5a9c Use platform path constant for SSSD log dir 
The path to SSSD log directory is platform specific and should be in
ipaplatform module.

Reviewed-By: David Kupka <dkupka@redhat.com>
 2016-03-16 09:31:02 +01:00
Oleg Fayans 578cff9567 Workaround for ticket 5627 
https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-11 17:27:45 +01:00
Oleg Fayans b5807fd9b6 Made apply_common_fixes call at replica installation independent on domain_level 
Besides added obligatory domain/realm-specific commandline options
 to replica installation

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-11 17:27:45 +01:00
Oleg Fayans b4071c542f Removed a constantly failing call to prepare_host 
prepare_host is executed from within each of install_master, install_replica
and install_client in tasks.py anyway, so no need to call it here also.
Besindes this call kept failing when IntegrationTest wes initialized more than
once during the test execution.

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-11 17:27:45 +01:00
Oleg Fayans ddadbf8274 Enabled setting domain level explicitly in test class 
Needed for replica promotion tests

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-11 17:27:45 +01:00
Oleg Fayans 0b1fe08f1d Integration tests for replica promotion feature 
http://www.freeipa.org/page/V4/Replica_Promotion/Test_plan

https://fedorahosted.org/freeipa/ticket/5723

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-11 17:27:45 +01:00
Lenka Doudova 904db149e9 WebUI test: ID views 
Provides missing test coverage for ID views web UI.

Reviewed-By: Pavel Vomacka <pvomacka@redhat.com>
 2016-03-11 11:52:25 +01:00
Martin Babinsky abe3abb466 test_cert_plugin: use only first part of the hostname to construct short name 
The short hostname construction for the negative test case in
test_cert_plugin::test_cert_find suite could not work when domain name was
different as hostname of the test runner, leading to test failure. A more
naive approach works better in this case.

https://fedorahosted.org/freeipa/ticket/5688

Reviewed-By: Martin Basti <mbasti@redhat.com>
 2016-03-08 20:22:55 +01:00
Filip Skola de63e16922 Refactor test_group_plugin, use GroupTracker for tests 
Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-08 16:32:11 +01:00
Martin Basti a63ce1fe22 CI: allow customized DS install test to work with domain levels 
Test will use tasks methods instead of custom commands to be able work
with domain levels.

https://fedorahosted.org/freeipa/ticket/5606

Reviewed-By: Milan Kubik <mkubik@redhat.com>
 2016-03-03 17:26:56 +01:00