Commit Graph

4304 Commits

Author SHA1 Message Date
Martin Kosek
45212301f2 Install tools crash when password prompt is interrupted
When getpass.getpass() function is interrupted via CTRL+D, EOFError
exception is thrown. Most of the install tools are not prepared for
this event and crash with this exception. Make sure that it is
handled properly and nice error message is printed.

https://fedorahosted.org/freeipa/ticket/1916
2011-10-06 08:28:34 +02:00
Nalin Dahyabhai
5de97801aa - note that PKCS#12 files also contain private keys, and that the "pkinit" options refer to the KDC's credentials 2011-10-04 23:00:08 -04:00
Jan Cholasta
428d8c4a2d Work around pkisilent bugs.
Check directory manager password and certificate subject base for
invalid characters.
(https://bugzilla.redhat.com/show_bug.cgi?id=658641)

Shell-escape pkisilent command-line arguments.
(https://bugzilla.redhat.com/show_bug.cgi?id=741180)

ticket 1636
2011-10-04 20:13:11 -04:00
Sumit Bose
5bc8323964 ipa-pwd-extop: allow password change on all connections with SSF>1
Instead of checking the individual SSFs for SASL, SSL/TLS and LDAPI connection
the global SSF is checked for password changes and enrollments.

https://fedorahosted.org/freeipa/ticket/1877
2011-10-05 17:20:37 +02:00
Alexander Bokovoy
92ee5ee90d Fix 'referenced before assignment' warning 2011-10-05 15:04:20 +02:00
Alexander Bokovoy
12ac2bd20a Setup and restore ntp configuration on the client side properly
When setting up the client-side NTP configuration, make sure that /etc/ntp/step-tickers
point to IPA NTP server as well.
When restoring the client during ipa-client-install --uninstall, make sure NTP configuration
is fully restored and NTP service is disabled if it was disabled before the installation.

https://fedorahosted.org/freeipa/ticket/1770
2011-10-05 12:52:52 +02:00
Jan Cholasta
087251c88b Add a function for formatting network locations of the form host:port for use in URLs.
If the host part is a literal IPv6 address, it must be enclosed in square
brackets (RFC 2732).

ticket 1869
2011-10-05 10:58:42 +02:00
Nalin Dahyabhai
49de0c0575 list users from nested groups, too 2011-10-05 09:07:01 +02:00
Alexander Bokovoy
39a64a5272 Configure pam_krb5 on the client only if sssd is not configured
https://fedorahosted.org/freeipa/ticket/1775
2011-10-04 17:00:48 +02:00
Rob Crittenden
bc83472b5b Migration: don't assume there is only one naming context, add logging.
We can't assume that there will be only one naming context. Look at each
one until we find an IPA one.

Add logging so you can know that a migration attempt fails and why.

https://fedorahosted.org/freeipa/ticket/1834
https://fedorahosted.org/freeipa/ticket/1835
2011-10-04 16:14:25 +02:00
Alexander Bokovoy
8f5d806b81 Unroll StrEnum values when displaying help
https://fedorahosted.org/freeipa/ticket/1848
2011-10-03 16:40:57 -04:00
Rob Crittenden
844d4ff8bf Require current password when using passwd to change your own password.
Add a new required parameter, current_password. In order to ask this
first I added a new parameter option, sortorder. The lower the value the
earlier it will be prompted for.

I also changed the way autofill works. It will attempt to get the default
and if it doesn't get anything will continue prompting interactively.

Since current_password is required I'm passing a magic value that
means changing someone else's password. We need to pass something
since current_password is required.

The python-ldap passwd command doesn't seem to use the old password at
all so I do a simple bind to validate it.

https://fedorahosted.org/freeipa/ticket/1808
2011-10-04 15:16:38 +02:00
Martin Kosek
651534087c Be more clear about selfsign option
Installing IPA server --selfsign option is currently a one-way ticket
to server with limited certificate capabilities. Make sure that user
really want to install it by implementing the following steps:

- moving the option to the bottom of certificate options section
- adding a warning to ipa-server-install man page
- adding a warning to ipa-server-install help
- adding a warning to ipa-server-install configuration summary
  when one runs ipa-server-install

https://fedorahosted.org/freeipa/ticket/1908
2011-10-04 11:01:10 +02:00
Endi S. Dewata
a013597e7c Disable sudo options Delete button if nothing selected.
The Delete button for sudo options in sudo rule details page now
will only work if there is at least one row selected.

Ticket #1896
2011-10-03 15:16:15 +02:00
Endi S. Dewata
af8350c327 I18n clean-up.
The hard-coded 'undo' and 'undo all' labels have been moved into
internal.py to allow translation.

Ticket #1897
2011-10-03 15:13:53 +02:00
Martin Kosek
46c16ed6ec migrate process cannot handle multivalued pkey attribute
When group/user is migrated, the attribute used for RDN may be
multivalued. Make sure that we pick the value used in the RDN
which should be the unique one and not just the first one.

https://fedorahosted.org/freeipa/ticket/1892
2011-10-03 10:48:02 +02:00
Endi S. Dewata
aaa7c05f50 Fixed missing default shell field.
The config default page has been fixed to provide a field for the
ipadefaultloginshell attribute.

Ticket #1895
2011-09-30 12:58:39 -05:00
Martin Kosek
848d37c092 ipa-client assumes a single namingcontext
When LDAP server contains more that one suffixes, the ipa client
installation does not detect it as IPA server and fails to install.
Fix ipa server discovery so that it correctly searches all naming
contexts for the IPA one.

https://fedorahosted.org/freeipa/ticket/1868
2011-09-30 16:54:30 +02:00
Simo Sorce
8fb70fd249 ipa-client-install: Fix joining when LDAP access is restricted
Fixes: https://fedorahosted.org/freeipa/ticket/1881
2011-09-30 16:42:43 +02:00
Martin Kosek
f9e277b9fb Fix HBAC tests hostnames
Make HBAC test hosts compliant with hostname restrictions placed
in ticket 1780.
2011-09-30 12:25:27 +02:00
Martin Kosek
7c884f1205 Fix LDAPCreate search failure
LDAPCreate reports "search criteria was not specific enough" when LDAP
object created in LDAPCreate shares its container with other LDAP objects
and there is one with the same name and RDN attribute.

Pass objectclass to find_entry_by_attr() function used to retrieve
newly created object for POST_CALLBACK to identify correct LDAP
object.

https://fedorahosted.org/freeipa/ticket/1864
2011-09-30 12:24:39 +02:00
Petr Vobornik
1e2c056283 Fixed: Some widgets do not have space for validation error message
https://fedorahosted.org/freeipa/ticket/1454

The following widgets should call create_error_link() to create a space to show validation error messages:

  IPA.checkbox_widget
  IPA.checkboxes_widget
  IPA.radio_widget
  IPA.select_widget
  IPA.table_widget
  IPA.attributes_widget
  IPA.rights_widget
  IPA.target_section (it's a widget)

Solution:
 * added call to checkbox, checkboxes, radio, select, table, attributes widget
 * rights_widget inherits it from checkboxes_widget.
 * target_section IS NOT a widget as it doesn't inherit from widget. It's still a section, which shows different widgets based on its state.
 * table_widget displays error_link between pagination and summary.

Additional:
 * added padding and unified font-weight for error message
2011-09-29 16:58:53 +00:00
Endi S. Dewata
a60ee8b781 Disable enroll button if nothing selected.
A new IPA.dialog_button class has been added to encapsulate the
buttons in the dialog box so they can be managed more easily.

The adder dialog has been modified to disable the enroll button if
there is no entries selected.

Ticket #1856
2011-09-29 16:58:20 +00:00
Endi S. Dewata
91de76f8b1 Fixed tab and dialog widths.
The width of the 1st level tab has been modified to expand according
to the size of the tab label.

The width of the adder dialogs have been increased to allow longer
button labels.

Ticket #1825
2011-09-29 16:58:05 +00:00
Endi S. Dewata
ce431be795 Updated color scheme.
The UI background has been replaced with new images from UXD.

Ticket #1842
2011-09-28 14:09:18 +00:00
Rob Crittenden
08ec4b0ddf Detect CA installation type in ipa-replica-prepare and ipa-ca-install.
ipa-ca-install can only add a dogtag CA to an IPA install.

ipa-replica-prepare can only be run on the initial master with a
selfsign backend.

https://fedorahosted.org/freeipa/ticket/1756
https://fedorahosted.org/freeipa/ticket/1757
2011-09-27 17:51:44 +02:00
Petr Vobornik
84744a2591 Fixed: Enrolment dialog offers to add entity to reflexive association.
https://fedorahosted.org/freeipa/ticket/1883

It's a regression introduced by patch for #1797

Reproduce:

 * show user group foo
 * click on user groups tab
 * click on enroll button

Result:
User group 'foo' is listed in available list.

Expected result:
User group 'foo' is not listed in available list.
2011-09-27 14:44:38 +00:00
Endi S. Dewata
df16d4aff7 Fixed duplicate entries in enrollment dialog.
The IPA.association_adder_dialog has been modified not to show
search results that are already selected to prevent duplicates.

Ticket #1859
2011-09-27 14:44:33 +00:00
Rob Crittenden
a27a820221 Add regular expression pattern to host names.
Limit hostnames to letters, digits and - with a maximum length of 255

https://fedorahosted.org/freeipa/ticket/1780
2011-09-27 16:08:40 +02:00
Rob Crittenden
2be04c6e7f Include failed service and service groups in hbac rule management
hbacrule-service-add/remove failures weren't being displayed because
no label was defined.

https://fedorahosted.org/freeipa/ticket/1863
https://fedorahosted.org/freeipa/ticket/1865
2011-09-27 15:57:24 +02:00
Martin Kosek
c0f3c318da Fix error messages in hbacrule
Fix NotFound error messages in hbacrule commands so that the text is
consistent with the rest of the framework.

https://fedorahosted.org/freeipa/ticket/1861
2011-09-27 15:37:24 +02:00
Martin Kosek
d6d73fd8a8 Revert "Always require SSL in the Kerberos authorization block."
This patch broke installation of a new master. Reverting until
we develop a better solution.

This reverts commit 384d4e8f50.
2011-09-27 08:56:50 +02:00
Jan Cholasta
63182c963b Validate name_from_ip parameter of dnszone.
ticket 1627
2011-09-27 08:44:03 +02:00
Endi S. Dewata
ef2faa6e37 Fixed add/delete arrows position.
The IPA.adder_dialog has been modified such that it shows the >>
arrow first then the << arrow.

Ticket #1858
2011-09-26 16:41:00 +00:00
Jan Cholasta
f4089adf77 Fix ipa-replica-prepare always warning the user about not using the system hostname.
ticket 1717
2011-09-26 17:11:17 +02:00
Petr Vobornik
09dc3562f2 Fixed: Column header for attributes table should be full width
https://fedorahosted.org/freeipa/ticket/1841

The column header for the attributes table (IPA.attributes_widget) does not cover the entire width of the table. This problem appears in the adder dialog and details page for permissions, self-service permissions, and delegations.
2011-09-26 14:58:06 +00:00
Marko Myllynen
5915e478ec Don't remove /tmp when removing temp cert dir
If /tmp happens to be empty os.removedirs() happily removes it...

https://fedorahosted.org/freeipa/ticket/1843
2011-09-22 22:03:12 -04:00
Rob Crittenden
384d4e8f50 Always require SSL in the Kerberos authorization block.
This also corrects a slight bug where if add is True then we always
re-update the file.

https://fedorahosted.org/freeipa/ticket/1755
2011-09-23 20:41:17 +02:00
Endi S. Dewata
060eea5f03 Fixed problem displaying special characters.
Some jQuery objects in various locations have been modified to use
text() to show values obtained from the server (except messages).
The text() will automatically encode special characters.

Ticket #1798
2011-09-23 15:29:26 +00:00
Rob Crittenden
ad37727150 Don't log one-time password in logs when configuring client.
https://fedorahosted.org/freeipa/ticket/1801
2011-09-23 15:31:58 +02:00
Endi S. Dewata
e254ea5d30 Fixed problem on combobox with search limit.
The IPA.combobox_widget has been modified such that if the drop-down
list doesn't contain the stored value (due to search limit) it will
not select anything from the list.

The widget has also been modified not to select the value that matches
the filter automatically because that might not be the user's intention.

Ticket #1819
2011-09-23 13:15:41 +00:00
Endi S. Dewata
c6f5806ed8 Removed undo flags from dialog field specs.
Since the undo flag is now automatically set to false in dialogs,
it's no longer necessary to specify it in the field specs.

Ticket #1394
2011-09-23 13:13:50 +00:00
Endi S. Dewata
eb9d9634da Modified dialog to use sections.
The IPA.dialog has been modified to store sections instead of fields.
If there is no sections specified, it will create a default section.

The adder dialog for automount map has been modified such that the
fields related to indirect map are stored in a section which will
only be visible when the map type is set to indirect.

The adder dialog for host has been modified such that it uses a
custom section for hostname and DNS zone and standard section for
the other fields.

Ticket #1394
2011-09-23 13:13:46 +00:00
Rob Crittenden
b8461e8d56 Shut down duplicated file handle when HTTP response code is not 200.
httplib purposely keeps the socket open as a file on failed requests. We
need to close this file otherwise nss_shutdown() will fail.

https://fedorahosted.org/freeipa/ticket/1807
2011-09-23 10:49:59 +02:00
Endi S. Dewata
e4f40a98a6 Fixed problem enrolling member with the same name.
The IPA.association_adder_dialog has been modified to use an exclusion
list to hide entries that are already enrolled.

The IPA.adder_dialog has been modified to store the columns directly
in the available & selected tables.

Ticket #1797
2011-09-22 17:05:51 +00:00
Endi S. Dewata
e5ef7fa817 Fixed problem enabling/disabling DNS zone.
The details facet for DNS zone has been modified to use dnszone-
enable/disable for idnszoneactive and dnszone-mod for other fields.

Ticket #1813
2011-09-22 17:05:22 +00:00
Simo Sorce
a7b6a6e498 ipa-pwd-extop: Enforce old password checks
If a user is changing his own password, then require the old password to be
sent for validation purposes.

https://fedorahosted.org/freeipa/ticket/1814
2011-09-21 18:10:44 -04:00
Rob Crittenden
fb6abb2acc Normalize uid in user principal to lower-case and do validation
Use same normalization and validation in passwd plugin and add some
tests for invalid principals

https://fedorahosted.org/freeipa/ticket/1778
2011-09-22 15:41:33 +02:00
Simo Sorce
355b93ecf3 ipa-pwd-extop: Fix segfault in password change.
Do not pass an empty buffer to ber_init() as it will assert.
Check before hand and return an error.
2011-09-21 16:04:39 -04:00
Martin Kosek
798490ffb6 Fix /usr/bin/ipa dupled server list
Fix get_url_list() so that the configured master server is there
just once. This fix lets /usr/bin/ipa try connecting to all IPA
masters just once and not print confusing server list with
dupled master.

https://fedorahosted.org/freeipa/ticket/1817
2011-09-22 15:09:48 +02:00