Commit Graph

4137 Commits

Author SHA1 Message Date
Adam Young
d32b44be6a enable proxy for dogtag
Dogtag is going to be proxied through httpd.  To make this work, it has to support renegotiation of the SSL
connection.  This patch enables renegotiate in the nss configuration file during during apache configuration,
as well as modifies libnss to set the appropriate optins on the ssl connection in order to  renegotiate.

The IPA install uses the internal ports instead of proxying through
httpd since  httpd is not set up yet.

IPA needs to Request the certificate through a port that uses authentication.  On the Dogtag side, they provide an additional mapping for this:   /ca/eeca/ca as opposed tp /ca/ee/ca  just for this purpose.

https://fedorahosted.org/freeipa/ticket/1334

add flag to pkicreate in order to enable using proxy.

add the proxy file in  /etc/http/conf.d/

Signed-off-by: Simo Sorce <ssorce@redhat.com>
2011-08-29 17:05:44 -04:00
Rob Crittenden
91c9e83209 Add common is_installed() fn, better uninstall logging, check for errors.
The installer and ipactl used two different methods to determine
whether IPA was configured, unify them.

When uninstalling report any thing that looks suspicious and warn
that a re-install may fail. This includes any remaining 389-ds instances
and any state or files that remains after all the module uninstallers
are complete.

Add wrappers for removing files and directories to log failures.

https://fedorahosted.org/freeipa/ticket/1715
2011-08-29 16:49:52 -04:00
Rob Crittenden
28e6d137af Set min nvr of pki-ca to 9.0.12 for fix in BZ 700505
https://fedorahosted.org/freeipa/ticket/1686
2011-08-28 20:54:40 -04:00
Petr Vobornik
7d33e5bc3f Modifying sudo options refreshes the whole page
https://fedorahosted.org/freeipa/ticket/1689

Currently adding or deleting sudo options will refresh the entire page. It's not a problem but the code could be optimized to refresh only the sudo options table
2011-08-29 15:22:20 +00:00
Martin Kosek
f1b93c5b0b ipa-client-install breaks network configuration
Do not forget to add new line in updated /etc/sysconfig/network
configuration. Move the actual change of the hostname after the
user confirmation about proceeding with installation. It confused
users when the hostname change occurred before this prompt.

https://fedorahosted.org/freeipa/ticket/1724
2011-08-29 10:39:52 +02:00
Rob Crittenden
c3ee9b3208 Remove 389-ds upgrade state during uninstall
When we perform an upgrade 389-ds is set to listen only on its
ldapi port. Theoretically it should be restored to the previous
state regardless of whether the upgrades were successful or not.

To be sure that a subsequent re-install will be successful go ahead
and remove the state for these options. Think of it as wearing a
belt and suspenders. Otherwise a re-install could return an error
message that IPA is already configured.

https://fedorahosted.org/freeipa/ticket/1667
2011-08-25 20:53:37 -04:00
Rob Crittenden
a622096254 Remove more 389-ds files/directories on uninstallation.
We were orphaning a few files/directories when uninstalling 389-instances
both for IPA and dogtag. This should remove everything but the logs.

ticket https://fedorahosted.org/freeipa/ticket/1700
2011-08-25 20:51:44 -04:00
Rob Crittenden
aad2aecb34 Disable reverse lookups in ipa-join and ipa-getkeytab
This prevents broken DNS from causing enrollment problems.

https://fedorahosted.org/freeipa/ticket/1693
2011-08-25 20:43:33 -04:00
Endi S. Dewata
fc898bc607 Fixed host keytab status after setting OTP.
The host details page has been modified to update the keytab status
based on the data returned by the host-mod command for setting OTP.

Ticket #1710
2011-08-26 15:19:47 +00:00
Endi S. Dewata
5c84e8f5fa Fixed host OTP status.
The host details page has been modified to show the status of the OTP.
Setting a new OTP is now done using a dialog box.

Ticket #1710
2011-08-26 15:19:43 +00:00
John Dennis
5716177458 ticket 1669 - improve i18n docstring extraction
This patch reverts the use of pygettext for i18n string extraction. It
was originally introduced because the help documentation for commands
are in the class docstring and module docstring.

Docstrings are a Python construct whereby any string which immediately
follows a class declaration, function/method declaration or appears
first in a module is taken to be the documentation for that
object. Python automatically assigns that string to the __doc__
variable associated with the object. Explicitly assigning to the
__doc__ variable is equivalent and permitted.

We mark strings in the source for i18n translation by embedding them
in _() or ngettext(). Specialized extraction tools (e.g. xgettext)
scan the source code looking for strings with those markers and
extracts the string for inclusion in a translation catalog.

It was mistakingly assumed one could not mark for translation Python
docstrings. Since some docstrings are vital for our command help
system some method had to be devised to extract docstrings for the
translation catalog. pygettext has the ability to locate and extract
docstrings and it was introduced to acquire the documentation for our
commands located in module and class docstrings.

However pygettext was too large a hammer for this task, it lacked any
fined grained ability to extract only the docstrings we were
interested in. In practice it extracted EVERY docstring in each file
it was presented with. This caused a large number strings to be
extracted for translation which had no reason to be translated, the
string might have been internal code documentation never meant to be
seen by users. Often the superfluous docstrings were long, complex and
likely difficult to translate. This placed an unnecessary burden on
our volunteer translators.

Instead what is needed is some method to extract only those strings
intended for translation. We already have such a mechanism and it is
already widely used, namely wrapping strings intended for translation
in calls to _() or _negettext(), i.e. marking a string for i18n
translation. Thus the solution to the docstring translation problem is
to mark the docstrings exactly as we have been doing, it only requires
that instead of a bare Python docstring we instead assign the marked
string to the __doc__ variable. Using the hypothetical class foo as
an example.

class foo(Command):
    '''
    The foo command takes out the garbage.
    '''

Would become:

class foo(Command):
    __doc__ = _('The foo command takes out the garbage.')

But which docstrings need to be marked for translation? The makeapi
tool knows how to iterate over every command in our public API. It was
extended to validate every command's documentation and report if any
documentation is missing or not marked for translation. That
information was then used to identify each docstring in the code which
needed to be transformed.

In summary what this patch does is:

* Remove the use of pygettext (modification to install/po/Makefile.in)

* Replace every docstring with an explicit assignment to __doc__ where
  the rhs of the assignment is an i18n marking function.

* Single line docstrings appearing in multi-line string literals
  (e.g. ''' or """) were replaced with single line string literals
  because the multi-line literals were introducing unnecessary
  whitespace and newlines in the string extracted for translation. For
  example:

  '''
  The foo command takes out the garbage.
  '''

  Would appear in the translation catalog as:

"\n
  The foo command takes out the garbage.\n
  "

  The superfluous whitespace and newlines are confusing to translators
  and requires us to strip leading and trailing whitespace from the
  translation at run time.

* Import statements were moved from below the docstring to above
  it. This was necessary because the i18n markers are imported
  functions and must be available before the the doc is
  parsed. Technically only the import of the i18n markers had to
  appear before the doc but stylistically it's better to keep all the
  imports together.

* It was observed during the docstring editing process that the
  command documentation was inconsistent with respect to the use of
  periods to terminate a sentence. Some doc had a trailing period,
  others didn't. Consistency was enforced by adding a period to end of
  every docstring if one was missing.
2011-08-24 23:15:25 -04:00
John Dennis
1a3a47e71c ticket 1706 - internationalize cli help framework
In cli.py is a framework for printing out help information. The
command documentation being displayed is internationalized, however
the text generated by the help framework itself is not
internationalized.

The strings output by the help subsystem need to be internationalized.
2011-08-24 23:06:59 -04:00
John Dennis
15bf6d2f91 ticket 1705 - internationalize help topics
* Wrap each topic description in _()

* Replace the use of if 'topic' in dir(module) with the more
  Pythonic and efficient getattr(module, 'topic', None)

* Make sure to invoke unicode on the value returned from _()
  otherwise you'll get a GettextFactory instance, not a string

* Clean up trailing whitespace errors
2011-08-24 23:05:48 -04:00
John Dennis
01ea14e3f5 ticket 1707 - add documentation validation to makeapi tool
Iterate over all API commands and perform the following validation:

* Every command must have documentation
  and it must be marked for international translation

* Every module hosting a command must have documentation
  and it must be marked for international translation

* Every module topic must be marked for international translation

For every error found emit a diagnostic.
Emit a summary of total errors found.

Return error flag if errors found, zero otherwise.
2011-08-24 23:04:12 -04:00
Rob Crittenden
4a9319a2a9 Retrieve password/keytab state when modifying a host.
ticket https://fedorahosted.org/freeipa/ticket/1714
2011-08-25 16:38:48 +00:00
Petr Vobornik
ddb31f5443 Modify serial associator to use batch
https://fedorahosted.org/freeipa/ticket/1688

The serial associator is used to execute a command multiple times with different parameters. This is used for adding/removing a user into/from multiple groups. It has some issues:

Each command is executed one-by-one, so it could be slow.
  * If there's a failure the rest of the commands will not be executed.
  * This can be fixed by putting the commands into a batch and execute them at once.
2011-08-25 15:57:51 +00:00
Endi S. Dewata
beac7e2bbf Fixed default map type in automount map adder dialog.
The adder dialog for automount map has been modified to select the
direct map by default.

Ticket #1698
2011-08-25 14:11:27 +00:00
Rob Crittenden
33fb16067a Add option to only prompt once for passwords, use in entitle_register
A Password param always prompted to confirm the entered password.
This doesn't make sense if you want to prompt for a password to another
system like we do with entitlements. This adds a new boolean option to
control the Password prompt parameter.

https://fedorahosted.org/freeipa/ticket/1695
2011-08-24 15:26:20 -04:00
Rob Crittenden
5d9203bb88 Add label for HBAC services to show as members
https://fedorahosted.org/freeipa/ticket/1711
2011-08-24 15:24:43 -04:00
Rob Crittenden
40c60c89ef Add additional pam ftp services to HBAC, and a ftp HBAC service group
This adds proftpd, pure-ftpd, vsftpd and gssftp.

https://fedorahosted.org/freeipa/ticket/1703
2011-08-24 15:22:14 -04:00
Petr Vobornik
a6cf44bd65 Validation of details facet before update https://fedorahosted.org/freeipa/ticket/1676 The ticket is a duplicate of server error, but it revealed few UI errors.
Newly performs validation of details facet before update. If validation fails, notification dialog is shown and command isn't executed.
Fixed integer minimum and maximum value checking.
Read-only and non-writable fields are no longer considered required.
2011-08-25 00:51:28 +00:00
Endi S. Dewata
5ba0be24e8 Fixed command partial failure handling.
When a command returns a partial failure it should be treated as a
success but the failures should still be displayed.

Ticket #1628
2011-08-24 15:10:06 +00:00
Petr Vobornik
37cef6f60d Show error in adding associations
https://fedorahosted.org/freeipa/ticket/1628
2011-08-24 15:10:01 +00:00
Rob Crittenden
be7de56e5d Change the way has_keytab is determined, also check for password.
We need an indicator to see if a keytab has been set on host and
service entries. We also need a way to know if a one-time password is
set on a host.

This adds an ACI that grants search on userPassword and
krbPrincipalKey so we can do an existence search on them. This way
we can tell if the attribute is set and create a fake attribute
accordingly.

When a userPassword is set on a host a keytab is generated against
that password so we always set has_keytab to False if a password
exists. This is fine because when keytab gets generated for the
host the password is removed (hence one-time).

This adds has_keytab/has_password to the user, host and service plugins.

ticket https://fedorahosted.org/freeipa/ticket/1538
2011-08-24 14:12:10 +02:00
Rob Crittenden
ae06f7b68e Fix thread deadlock by using pthreads library instead of NSPR.
The 389-ds team is in the process of exposing slapi_rwlock which we
will switch to when it is available.

https://fedorahosted.org/freeipa/ticket/1630
2011-08-24 13:59:27 +02:00
Rob Crittenden
5767c293c7 Suppress 389-ds debug output when starting services
If the user wants the output they can pass the --debug flag to ipactl.

https://fedorahosted.org/freeipa/ticket/1402
2011-08-24 13:54:26 +02:00
Endi S. Dewata
ffebf37639 Removed unnecessary HBAC/sudo rule category modification.
Since the Add/Delete links in the association table are disabled when
the category is set to 'all', it's no longer necessary to check the
category before showing the add/delete dialogs and modify the category
before adding entries. Thus, the IPA.rule_association_table_widget is
no longer needed.

Ticket #1692
2011-08-23 22:23:31 +00:00
Jan Cholasta
c4f04dd858 Verify that the external CA certificate files are correct.
ticket 1572
2011-08-23 01:23:50 -04:00
Jan Cholasta
028a87b0da Add subscription-manager dependency for RHEL.
ticket 1664
2011-08-23 00:30:32 -04:00
Jr Aquino
eb804d4cb3 Improve sudorule documentation
Added brief explanations for the various Sudo components in the
top level doc.  Added doc entries for RunAs User and RunAs
Group.

https://fedorahosted.org/freeipa/ticket/1657
2011-08-23 00:24:40 -04:00
Endi S. Dewata
68a345712c Updated add and delete association dialog titles.
The association table widget and facet have been modified to accept
titles for the add and delete dialogs. The table and facet definitions
have been modified to specify the appropriate titles.

Some unused code have been removed.

Ticket #1629
2011-08-23 16:12:05 +00:00
Jan Cholasta
7879079ce2 Search for users in all the naming contexts present on the directory server.
ticket 1655, 1656
2011-08-22 19:04:41 -04:00
Rob Crittenden
3a9f626f03 Fix wording in examples of delegation plugin.
https://fedorahosted.org/freeipa/ticket/1013
2011-08-19 02:55:09 -04:00
Rob Crittenden
c39321d35c Do batch logging on successful commands too, not just failures.
This was an oversight for previous logging patch, ticket 1598
2011-08-19 02:54:22 -04:00
Petr Vobornik
9363260ca0 Uncheck checkboxes in association after deletion
https://fedorahosted.org/freeipa/ticket/1639
2011-08-19 20:56:06 +00:00
Rob Crittenden
4797cddbd0 Log each command in a batch separately.
This also fixes command logging in general, it wasn't working in most
cases as a regression in ticket 1322.

https://fedorahosted.org/freeipa/ticket/1598
2011-08-19 01:21:35 -04:00
Jan Cholasta
159c13a550 Add option to install without the automatic redirect to the Web UI.
ticket 1570
2011-08-18 23:24:38 -04:00
Martin Kosek
2e9d614cab Fix automountlocation-import conflicts
Do not fail import operation with DuplicateEntry when imported
maps/keys conflict with maps/keys pre-created by
automountlocation-add command. Currently, this applies for map
'auto.direct' and key '/-'.

https://fedorahosted.org/freeipa/ticket/1551
2011-08-18 22:49:09 -04:00
Endi S. Dewata
24d3d02693 Replaced page dirty dialog title.
The title of page dirty dialog has been changed to 'Unsaved Changes'.

Ticket #1653
2011-08-19 16:45:52 +00:00
Endi S. Dewata
1603eb03f3 Removed 'Hide already enrolled' checkbox.
The 'Hide already enrolled' has been removed from the enrollment
dialog because it is checked by default and entries that are already
enrolled cannot be enrolled again.

Ticket #1638
2011-08-19 16:45:47 +00:00
Jan Cholasta
48eb95c5a4 Verify that passwords specified through command line options of ipa-server-install meet the length requirement.
ticket 1621
2011-08-18 20:54:06 -04:00
Martin Kosek
6aa0b57440 Fix automountkey-mod
Fix automountkey-mod so that automountkey attribute is correctly
updated. Add this test case to the unit tests.

Make automountkey required for automountkey-mod, otherwise it would
cause internal server error.

Make --newinfo optional so that automountkey may be just renamed
without changing its info attribute.

https://fedorahosted.org/freeipa/ticket/1528
2011-08-18 20:35:24 -04:00
Jan Cholasta
704732630c Make sure messagebus is running prior to starting certmonger.
ticket 1580
2011-08-18 20:16:01 -04:00
Rob Crittenden
21441f0680 Add information on setting api.env.host in the ipactl.8 man page
ticket https://fedorahosted.org/freeipa/ticket/1390
2011-08-19 08:39:10 +02:00
Endi S. Dewata
4691f1eda8 Fixed inconsistent layout for password reset dialog.
The dialog box for resetting user password has been modified to use
the standard layout.

Ticket #1641
2011-08-18 20:38:48 +00:00
John Dennis
c94ebfcb84 ticket 1650 - compute accurate translation statistics
ticket 1650 (https://fedorahosted.org/freeipa/ticket/1650) has
an extensive discussion of the issues, please refer to that.

This patch does the following:

* does not count fuzzy translations when computing translation
  statistics via the "msg-stats" make target in install/po

* adds a new make target called "pull-po" which pulls updated po files
  from Transifex (configure.ac includes some trailing whitespace fixes)

* turns off the generation of fuzzy translation suggestions during the
  message merge phase.
2011-08-18 14:26:10 +02:00
John Dennis
3d9ccdbedb ticket 1661 - Update all po files
After updating po's current translation status is:

ipa.pot has 1329 messages. There are 21 po translation files.
as:          0/1329   0.0%  1329 untranslated,     0 fuzzy
bn_IN:      13/1329   1.0%  1316 untranslated,     0 fuzzy
zh_CN:     133/1329  10.0%  1196 untranslated,     0 fuzzy
zh_TW:       0/1329   0.0%  1329 untranslated,     0 fuzzy
nl:          1/1329   0.1%  1328 untranslated,     0 fuzzy
fr:          0/1329   0.0%  1329 untranslated,     0 fuzzy
de:         27/1329   2.0%  1302 untranslated,     0 fuzzy
el:          0/1329   0.0%  1329 untranslated,     0 fuzzy
gu:          0/1329   0.0%  1329 untranslated,     0 fuzzy
id:         89/1329   6.7%  1240 untranslated,     0 fuzzy
ja_JP:       0/1329   0.0%  1329 untranslated,     0 fuzzy
ja:          0/1329   0.0%  1329 untranslated,     0 fuzzy
kn:        243/1329  18.3%  1086 untranslated,     0 fuzzy
fa:          0/1329   0.0%  1329 untranslated,     0 fuzzy
pl:        492/1329  37.0%   837 untranslated,     0 fuzzy
pt_BR:       0/1329   0.0%  1329 untranslated,     0 fuzzy
pt:          0/1329   0.0%  1329 untranslated,     0 fuzzy
ru:        162/1329  12.2%  1167 untranslated,     0 fuzzy
es:       1329/1329 100.0%     0 untranslated,     0 fuzzy
sv:          0/1329   0.0%  1329 untranslated,     0 fuzzy
uk:       1329/1329 100.0%     0 untranslated,     0 fuzzy
2011-08-18 13:20:57 +02:00
John Dennis
a3742dd465 ticket 1660 - update LINGUAS file, add missing po files
Our LINGUAS file and the set of po files have diverged from what's on
Transifex. We should update the LINGUAS file to match the set of
translations on Transifex and add po files currently on Transifex but
not in our git repo to our git repo.
2011-08-18 13:20:21 +02:00
John Dennis
302bbb9eea ticket 1659 - invalid i18n string in dns.py
dns.py at line 976 has an invalid i18n string and cannot be processed
during message extraction causing message catalog generation to fail.

The format parameters are trapped inside the i18n string. Also it's
not necessary to promote the i18n string literal to unicode via the u
prefix because the _() function returns unicode.
2011-08-18 13:19:22 +02:00
Alexander Bokovoy
821fa37cb2 Propagate environment when it is required.
https://fedorahosted.org/freeipa/ticket/1549
https://fedorahosted.org/freeipa/ticket/1550
2011-08-17 02:05:52 -04:00