mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2024-12-27 09:21:59 -06:00
ba12165eaf
This is the first time running Pylint-2.4 over the whole IPA codebase.
```
Pylint on /usr/bin/python is running, please wait ...
internal error with sending report for module ['ipaserver/plugins/serverroles.py']
maximum recursion depth exceeded while calling a Python object
************* Module ipatests.test_integration.base
ipatests/test_integration/base.py:84: [W0125(using-constant-test), IntegrationTest.install] Using a conditional statement with a constant value)
************* Module ipaserver.install.ipa_cacert_manage
ipaserver/install/ipa_cacert_manage.py:522: [R1724(no-else-continue), CACertManage.delete] Unnecessary "elif" after "continue")
```
The latest Pylint (via the Tox task) checks only:
```
{envsitepackagesdir}/ipaclient \
{envsitepackagesdir}/ipalib \
{envsitepackagesdir}/ipapython
```
, while the distro-Pylint runs over all project but it is not fresh.
That's why these warnings/errors weren't exposed before now.
Concerning `internal error`: a fix was accepted by upstream:
https://github.com/PyCQA/pylint/issues/3245, but wasn't released yet.
Until that is done, Pylint just warns.
Related: https://pagure.io/freeipa/issue/8116
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
108 lines
3.3 KiB
Python
108 lines
3.3 KiB
Python
# Authors:
|
|
# Petr Viktorin <pviktori@redhat.com>
|
|
#
|
|
# Copyright (C) 2013 Red Hat
|
|
# see file 'COPYING' for use and warranty information
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""Base class for FreeIPA integration tests"""
|
|
|
|
import pytest
|
|
import subprocess
|
|
|
|
from ipatests.pytest_ipa.integration import tasks
|
|
from pytest_sourceorder import ordered
|
|
|
|
|
|
@ordered
|
|
@pytest.mark.usefixtures('mh')
|
|
@pytest.mark.usefixtures('integration_logs')
|
|
class IntegrationTest:
|
|
num_replicas = 0
|
|
num_clients = 0
|
|
num_ad_domains = 0
|
|
num_ad_subdomains = 0
|
|
num_ad_treedomains = 0
|
|
required_extra_roles = []
|
|
topology = None
|
|
domain_level = None
|
|
fips_mode = None
|
|
|
|
@classmethod
|
|
def host_by_role(cls, role):
|
|
for domain in cls.get_domains():
|
|
try:
|
|
return domain.host_by_role(role)
|
|
except LookupError:
|
|
pass
|
|
raise LookupError(role)
|
|
|
|
@classmethod
|
|
def get_all_hosts(cls):
|
|
return ([cls.master] + cls.replicas + cls.clients +
|
|
[cls.host_by_role(r) for r in cls.required_extra_roles])
|
|
|
|
@classmethod
|
|
def get_domains(cls):
|
|
return [cls.domain] + cls.ad_domains
|
|
|
|
@classmethod
|
|
def enable_fips_mode(cls):
|
|
for host in cls.get_all_hosts():
|
|
if not host.is_fips_mode:
|
|
host.enable_userspace_fips()
|
|
|
|
@classmethod
|
|
def disable_fips_mode(cls):
|
|
for host in cls.get_all_hosts():
|
|
if host.is_userspace_fips:
|
|
host.disable_userspace_fips()
|
|
|
|
@classmethod
|
|
def install(cls, mh):
|
|
if cls.domain_level is not None:
|
|
domain_level = cls.domain_level
|
|
else:
|
|
domain_level = cls.master.config.domain_level
|
|
|
|
if cls.master.config.fips_mode: # pylint: disable=using-constant-test
|
|
cls.fips_mode = True
|
|
if cls.fips_mode:
|
|
cls.enable_fips_mode()
|
|
|
|
if cls.topology is None:
|
|
return
|
|
else:
|
|
tasks.install_topo(cls.topology,
|
|
cls.master, cls.replicas,
|
|
cls.clients, domain_level)
|
|
@classmethod
|
|
def uninstall(cls, mh):
|
|
for replica in cls.replicas:
|
|
try:
|
|
tasks.run_server_del(
|
|
cls.master, replica.hostname, force=True,
|
|
ignore_topology_disconnect=True, ignore_last_of_role=True)
|
|
except subprocess.CalledProcessError:
|
|
# If the master has already been uninstalled,
|
|
# this call may fail
|
|
pass
|
|
tasks.uninstall_master(replica)
|
|
tasks.uninstall_master(cls.master)
|
|
for client in cls.clients:
|
|
tasks.uninstall_client(client)
|
|
if cls.fips_mode:
|
|
cls.disable_fips_mode()
|