freeipa/ipapython/install
Rob Crittenden 68c7b03689 Return a value if exceptions are raised in server uninstall
The AdminTool class purports to "call sys.exit() with the return
value" but most of the run implementations returned no value, or
the methods they called returned nothing so there was nothing to
return, so this was a no-op.

The fix is to capture and bubble up the return values which will
return 1 if any exceptions are caught.

This potentially affects other users in that when executing the
steps of an installer or uninstaller the highest return code
will be the exit value of that installer.

Don't use the Continuous class because it doesn't add any
value and makes catching the exceptions more difficult.

https://pagure.io/freeipa/issue/7330

Signed-off-by: Rob Crittenden rcritten@redhat.com
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
2018-03-19 17:38:41 +01:00
..
__init__.py install: Introduce installer framework ipapython.install 2015-06-08 15:34:11 +00:00
cli.py Return a value if exceptions are raised in server uninstall 2018-03-19 17:38:41 +01:00
common.py Return a value if exceptions are raised in server uninstall 2018-03-19 17:38:41 +01:00
core.py Return a value if exceptions are raised in server uninstall 2018-03-19 17:38:41 +01:00
typing.py install: use standard Python classes to declare knob types 2016-11-11 12:17:25 +01:00
util.py install.util: disable no-value-for-parameter 2017-09-08 15:42:07 +02:00