mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2024-12-25 08:21:05 -06:00
b4fc6f4ba8
Issue: * There was no caching policy specified. * -> Browsers use their own default policy. * -> After upgrade, some Web UI files might have been actualized some not. * -> With schema change may result into weird bugs in Web UI Solution considerations: 1. Detect server version change and hard-reload at runtime Detection is easy. Problem is the reload. Obvious candidate 'window.location.reload(true)' works in Firefox but not in Chrome because expected behavior when parameter is used is not in standard and therefore Chromium/WebKit authors did not implement it. 2. Application Cache HTML 5 technology which lets web apps to run offline. Besides weird issues with event handlers which I encountered, this would be an ideal candidate. Simple change of manifest file would lead to reload of all files (requires reload of page to used the new files). Showstopper was usage with untrusted certificate. If user did not add exception for the cert or its CA and would visit the page for a second time, all AJAX calls would fail. 3. Set Expires to now() for everything Web UI rarely changes so this is an overkill. Setting it to different value is not a solution either. We can't predict when the upgrade will happen and when new Web UI will be needed. Solution: * Implemented a mini loader which loads basic resources. Dojo loader takes action after Dojo is loaded. * The loader adds a version parameter (?v=__NUM_VERSION__) to all requests. * Version is defined in the loader. It's set to current in `make version-update`. * All static pages use this loader to fetch their resources. * Version is also passed to dojo loader as cache-bust for the same effect. * Expire header was set to 'access time plus 1 year' for /ui folder. Exceptions are HTML files and loader (set to immediate expiration). Possible issues: * Images are cached but not requested with version param. * Images with version and without are considered different * -> We would have to attach version to all URIs - in CSS and in JS. But we should avoid changing jQuery UI CSS. * Proposed solution is to change image name when changing image. Image change is done rarely. * Version is set by build and therefore updated just on server update. It might cause trouble with different update schedule of plugins. * No action taken to address this issue yet. * We might leave it on plugin devs (own .conf in /etc/httpd/conf.d/) * or set expires to now for all plugins * running `make version-update` is required in order to use static version of UI for testing https://fedorahosted.org/freeipa/ticket/3798
140 lines
6.2 KiB
Plaintext
140 lines
6.2 KiB
Plaintext
#
|
|
# Configuration File for JavaScript Lint 0.3.0
|
|
# Developed by Matthias Miller (http://www.JavaScriptLint.com)
|
|
#
|
|
# This configuration file can be used to lint a collection of scripts, or to enable
|
|
# or disable warnings for scripts that are linted via the command line.
|
|
#
|
|
|
|
### Warnings
|
|
# Enable or disable warnings based on requirements.
|
|
# Use "+WarningName" to display or "-WarningName" to suppress.
|
|
#
|
|
+no_return_value # function {0} does not always return a value
|
|
+duplicate_formal # duplicate formal argument {0}
|
|
+equal_as_assign # test for equality (==) mistyped as assignment (=)?{0}
|
|
+var_hides_arg # variable {0} hides argument
|
|
+redeclared_var # redeclaration of {0} {1}
|
|
+anon_no_return_value # anonymous function does not always return a value
|
|
+missing_semicolon # missing semicolon
|
|
+meaningless_block # meaningless block; curly braces have no impact
|
|
+comma_separated_stmts # multiple statements separated by commas (use semicolons?)
|
|
+unreachable_code # unreachable code
|
|
+missing_break # missing break statement
|
|
+missing_break_for_last_case # missing break statement for last case in switch
|
|
+comparison_type_conv # comparisons against null, 0, true, false, or an empty string allowing implicit type conversion (use === or !==)
|
|
+inc_dec_within_stmt # increment (++) and decrement (--) operators used as part of greater statement
|
|
+useless_void # use of the void type may be unnecessary (void is always undefined)
|
|
+multiple_plus_minus # unknown order of operations for successive plus (e.g. x+++y) or minus (e.g. x---y) signs
|
|
+use_of_label # use of label
|
|
-block_without_braces # block statement without curly braces
|
|
+leading_decimal_point # leading decimal point may indicate a number or an object member
|
|
+trailing_decimal_point # trailing decimal point may indicate a number or an object member
|
|
+octal_number # leading zeros make an octal number
|
|
+nested_comment # nested comment
|
|
+misplaced_regex # regular expressions should be preceded by a left parenthesis, assignment, colon, or comma
|
|
+ambiguous_newline # unexpected end of line; it is ambiguous whether these lines are part of the same statement
|
|
+empty_statement # empty statement or extra semicolon
|
|
-missing_option_explicit # the "option explicit" control comment is missing
|
|
+partial_option_explicit # the "option explicit" control comment, if used, must be in the first script tag
|
|
+dup_option_explicit # duplicate "option explicit" control comment
|
|
+useless_assign # useless assignment
|
|
+ambiguous_nested_stmt # block statements containing block statements should use curly braces to resolve ambiguity
|
|
+ambiguous_else_stmt # the else statement could be matched with one of multiple if statements (use curly braces to indicate intent)
|
|
+missing_default_case # missing default case in switch statement
|
|
+duplicate_case_in_switch # duplicate case in switch statements
|
|
+default_not_at_end # the default case is not at the end of the switch statement
|
|
+legacy_cc_not_understood # couldn't understand control comment using /*@keyword@*/ syntax
|
|
+jsl_cc_not_understood # couldn't understand control comment using /*jsl:keyword*/ syntax
|
|
+useless_comparison # useless comparison; comparing identical expressions
|
|
+with_statement # with statement hides undeclared variables; use temporary variable instead
|
|
+trailing_comma_in_array # extra comma is not recommended in array initializers
|
|
+assign_to_function_call # assignment to a function call
|
|
+parseint_missing_radix # parseInt missing radix parameter
|
|
|
|
|
|
### Output format
|
|
# Customize the format of the error message.
|
|
# __FILE__ indicates current file path
|
|
# __FILENAME__ indicates current file name
|
|
# __LINE__ indicates current line
|
|
# __ERROR__ indicates error message
|
|
#
|
|
# Visual Studio syntax (default):
|
|
+output-format __FILE__(__LINE__): __ERROR__
|
|
# Alternative syntax:
|
|
#+output-format __FILE__:__LINE__: __ERROR__
|
|
|
|
|
|
### Context
|
|
# Show the in-line position of the error.
|
|
# Use "+context" to display or "-context" to suppress.
|
|
#
|
|
+context
|
|
|
|
|
|
### Semicolons
|
|
# By default, assignments of an anonymous function to a variable or
|
|
# property (such as a function prototype) must be followed by a semicolon.
|
|
#
|
|
+lambda_assign_requires_semicolon
|
|
|
|
|
|
### Control Comments
|
|
# Both JavaScript Lint and the JScript interpreter confuse each other with the syntax for
|
|
# the /*@keyword@*/ control comments and JScript conditional comments. (The latter is
|
|
# enabled in JScript with @cc_on@). The /*jsl:keyword*/ syntax is preferred for this reason,
|
|
# although legacy control comments are enabled by default for backward compatibility.
|
|
#
|
|
+legacy_control_comments
|
|
|
|
|
|
### JScript Function Extensions
|
|
# JScript allows member functions to be defined like this:
|
|
# function MyObj() { /*constructor*/ }
|
|
# function MyObj.prototype.go() { /*member function*/ }
|
|
#
|
|
# It also allows events to be attached like this:
|
|
# function window::onload() { /*init page*/ }
|
|
#
|
|
# This is a Microsoft-only JavaScript extension. Enable this setting to allow them.
|
|
#
|
|
-jscript_function_extensions
|
|
|
|
|
|
### Defining identifiers
|
|
# By default, "option explicit" is enabled on a per-file basis.
|
|
# To enable this for all files, use "+always_use_option_explicit"
|
|
#-always_use_option_explicit
|
|
+always_use_option_explicit
|
|
|
|
# Define certain identifiers of which the lint is not aware.
|
|
# (Use this in conjunction with the "undeclared identifier" warning.)
|
|
#
|
|
# Common uses for webpages might be:
|
|
+define window
|
|
+define document
|
|
+define alert
|
|
+define $
|
|
+define JSON
|
|
+define jQuery
|
|
+define define
|
|
+define require
|
|
+define ipa_loader
|
|
|
|
### Files
|
|
# Specify which files to lint
|
|
# Use "+recurse" to enable recursion (disabled by default).
|
|
# To add a set of files, use "+process FileName", "+process Folder\Path\*.js",
|
|
# or "+process Folder\Path\*.htm".
|
|
#
|
|
|
|
+process index.html
|
|
+process src/libs/browser.js
|
|
+process src/libs/jquery.ordered-map.js
|
|
+process src/freeipa/*.js
|
|
+process src/freeipa/_base/*.js
|
|
+process src/freeipa/navigation/*.js
|
|
+process src/freeipa/widgets/*.js
|
|
+process src/*.js
|
|
+process ./*.js |