mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2025-02-25 18:55:28 -06:00
9df6a4ed8c
We have a larger goal of replacing all DN creation via string formatting/concatenation with DN object operations because string operations are not a safe way to form a DN nor to compare a DN. This work needs to be broken into smaller chunks for easier review and testing. Addressing the unit tests first makes sense because we don't want to be modifying both the core code and the tests used to verify the core code simultaneously. If we modify the unittests first with existing core code and no regressions are found then we can move on to modifying parts of the core code with the belief the unittests can validate the changes in the core code. Also by doing the unittests first we also help to validate the DN objects are working correctly (although they do have an extensive unittest). The fundamental changes are: * replace string substitution & concatenation with DN object constructor * when comparing dn's the comparision is done after promotion to a DN object, then two DN objects are compared * when a list of string dn's are to be compared a new list is formed where each string dn is replaced by a DN object * because the unittest framework accepts a complex data structure of expected values where dn's are represeted as strings the unittest needs to express the expected value of a dn as a callable object (e.g. a lambda expression) which promotes the dn string to a DN object in order to do the comparision.
226 lines
7.7 KiB
Python
226 lines
7.7 KiB
Python
# Authors:
|
|
# Rob Crittenden <rcritten@redhat.com>
|
|
#
|
|
# Copyright (C) 2011 Red Hat
|
|
# see file 'COPYING' for use and warranty information
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
"""
|
|
Test the modlist replace logic. Some attributes require a MOD_REPLACE
|
|
while others are fine using ADD/DELETE.
|
|
|
|
Note that member management in other tests also exercises the
|
|
gen_modlist code.
|
|
"""
|
|
|
|
from ipalib import api, errors
|
|
from tests.test_xmlrpc import objectclasses
|
|
from xmlrpc_test import Declarative, fuzzy_digits, fuzzy_uuid
|
|
from ipalib.dn import *
|
|
|
|
user1=u'tuser1'
|
|
|
|
|
|
class test_replace(Declarative):
|
|
|
|
cleanup_commands = [
|
|
('user_del', [user1], {}),
|
|
]
|
|
|
|
tests = [
|
|
|
|
dict(
|
|
desc='Create %r with 2 e-mail accounts' % user1,
|
|
command=(
|
|
'user_add', [user1], dict(givenname=u'Test', sn=u'User1',
|
|
mail=[u'test1@example.com', u'test2@example.com'])
|
|
),
|
|
expected=dict(
|
|
value=user1,
|
|
summary=u'Added user "tuser1"',
|
|
result=dict(
|
|
gecos=[u'Test User1'],
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
krbprincipalname=[u'tuser1@' + api.env.realm],
|
|
loginshell=[u'/bin/sh'],
|
|
objectclass=objectclasses.user,
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
displayname=[u'Test User1'],
|
|
cn=[u'Test User1'],
|
|
initials=[u'TU'],
|
|
mail=[u'test1@example.com', u'test2@example.com'],
|
|
ipauniqueid=[fuzzy_uuid],
|
|
krbpwdpolicyreference=lambda x: [DN(i) for i in x] == \
|
|
[DN(('cn','global_policy'),('cn',api.env.realm),('cn','kerberos'),
|
|
api.env.basedn)],
|
|
mepmanagedentry=lambda x: [DN(i) for i in x] == \
|
|
[DN(('cn',user1),('cn','groups'),('cn','accounts'),
|
|
api.env.basedn)],
|
|
memberof_group=[u'ipausers'],
|
|
dn=lambda x: DN(x) == \
|
|
DN(('uid','tuser1'),('cn','users'),('cn','accounts'),
|
|
api.env.basedn),
|
|
),
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Drop one e-mail account, add another to %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(mail=[u'test1@example.com', u'test3@example.com'])
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
mail=[u'test1@example.com', u'test3@example.com'],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Set mail to a new single value %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(mail=u'test4@example.com')
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
mail=[u'test4@example.com'],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Set mail to three new values %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(mail=[u'test5@example.com', u'test6@example.com', u'test7@example.com'])
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
mail=[u'test6@example.com', u'test7@example.com', u'test5@example.com'],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Remove all mail values %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(mail=u'')
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Ensure single-value mods work too, replace initials %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(initials=u'ABC')
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
initials=[u'ABC'],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
|
|
dict(
|
|
desc='Drop a single-value attribute %r' % user1,
|
|
command=(
|
|
'user_mod', [user1], dict(initials=u'')
|
|
),
|
|
expected=dict(
|
|
result=dict(
|
|
givenname=[u'Test'],
|
|
homedirectory=[u'/home/tuser1'],
|
|
loginshell=[u'/bin/sh'],
|
|
sn=[u'User1'],
|
|
uid=[user1],
|
|
uidnumber=[fuzzy_digits],
|
|
gidnumber=[fuzzy_digits],
|
|
memberof_group=[u'ipausers'],
|
|
nsaccountlock=False,
|
|
),
|
|
summary=u'Modified user "tuser1"',
|
|
value=user1,
|
|
),
|
|
),
|
|
|
|
]
|