mirror of
https://salsa.debian.org/freeipa-team/freeipa.git
synced 2024-12-23 15:40:01 -06:00
35c36f9b4e
The ipa-advise command should not fail with error in command. Related: https://pagure.io/freeipa/issue/6044 Signed-off-by: Anuja More <amore@redhat.com> Reviewed-By: Sudhir Menon <sumenon@redhat.com>
188 lines
6.8 KiB
Python
188 lines
6.8 KiB
Python
# Authors:
|
|
# Gabe Alford <redhatrises@gmail.com>
|
|
#
|
|
# Copyright (C) 2013 Red Hat
|
|
# see file 'COPYING' for use and warranty information
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
import re
|
|
|
|
from ipalib.constants import IPAAPI_USER
|
|
from ipaplatform.paths import paths
|
|
from ipaplatform.constants import constants
|
|
|
|
from ipatests.create_external_ca import ExternalCA
|
|
from ipatests.pytest_ipa.integration import tasks
|
|
from ipatests.test_integration.base import IntegrationTest
|
|
|
|
|
|
def run_advice(master, advice_id, advice_regex, raiseerr=True):
|
|
# Obtain the advice from the server
|
|
tasks.kinit_admin(master)
|
|
result = master.run_command(['ipa-advise', advice_id],
|
|
raiseonerr=raiseerr)
|
|
|
|
if not result.stdout_text:
|
|
advice = result.stderr_text
|
|
else:
|
|
advice = result.stdout_text
|
|
|
|
assert re.search(advice_regex, advice, re.S)
|
|
|
|
|
|
class TestAdvice(IntegrationTest):
|
|
"""
|
|
Tests ipa-advise output.
|
|
"""
|
|
topology = 'line'
|
|
num_replicas = 0
|
|
num_clients = 1
|
|
|
|
def execute_advise(self, host, advice_id, *args):
|
|
# ipa-advise script is only available on a server
|
|
tasks.kinit_admin(self.master)
|
|
advice = self.master.run_command(['ipa-advise', advice_id])
|
|
# execute script on host (client or master)
|
|
if host is not self.master:
|
|
tasks.kinit_admin(host)
|
|
filename = tasks.upload_temp_contents(host, advice.stdout_text)
|
|
cmd = ['sh', filename]
|
|
cmd.extend(args)
|
|
try:
|
|
result = host.run_command(cmd)
|
|
finally:
|
|
host.run_command(['rm', '-f', filename])
|
|
return advice, result
|
|
|
|
def test_invalid_advice(self):
|
|
advice_id = r'invalid-advise-param'
|
|
advice_regex = r"invalid[\s]+\'advice\'.*"
|
|
run_advice(self.master, advice_id, advice_regex, raiseerr=False)
|
|
|
|
def test_advice_FreeBSDNSSPAM(self):
|
|
advice_id = 'config-freebsd-nss-pam-ldapd'
|
|
advice_regex = r"\#\!\/bin\/sh.*" \
|
|
r"pkg_add[\s]+\-r[\s]+nss\-pam\-ldapd[\s]+curl.*" \
|
|
r"\/usr\/local\/etc\/rc\.d\/nslcd[\s]+restart"
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_GenericNSSPAM(self):
|
|
advice_id = 'config-generic-linux-nss-pam-ldapd'
|
|
advice_regex = (
|
|
r"\#\!\/bin\/sh.*"
|
|
r"apt\-get[\s]+\-y[\s]+install[\s]+curl[\s]+openssl[\s]+"
|
|
r"libnss\-ldapd[\s]+libpam\-ldapd[\s]+nslcd.*"
|
|
r"service[\s]+nscd[\s]+stop[\s]+\&\&[\s]+service[\s]+"
|
|
r"nslcd[\s]+restart"
|
|
)
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_GenericSSSDBefore19(self):
|
|
advice_id = r'config-generic-linux-sssd-before-1-9'
|
|
advice_regex = r"\#\!\/bin\/sh.*" \
|
|
r"apt\-get[\s]+\-y[\s]+install sssd curl openssl.*" \
|
|
r"service[\s]+sssd[\s]+start"
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_RedHatNSS(self):
|
|
advice_id = 'config-redhat-nss-ldap'
|
|
advice_regex = (
|
|
r"\#\!\/bin\/sh.*"
|
|
r"yum[\s]+install[\s]+\-y[\s]+curl[\s]+openssl[\s]+nss_ldap"
|
|
r"[\s]+authconfig.*authconfig[\s]+\-\-updateall"
|
|
r"[\s]+\-\-enableldap[\s]+\-\-enableldaptls"
|
|
r"[\s]+\-\-enableldapauth[\s]+"
|
|
r"\-\-ldapserver=.*[\s]+\-\-ldapbasedn=.*"
|
|
)
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_RedHatNSSPAM(self):
|
|
advice_id = 'config-redhat-nss-pam-ldapd'
|
|
advice_regex = r"\#\!\/bin\/sh.*" \
|
|
r"yum[\s]+install[\s]+\-y[\s]+curl[\s]+openssl[\s]+" \
|
|
r"nss\-pam\-ldapd[\s]+pam_ldap[\s]+authconfig.*" \
|
|
r"authconfig[\s]+\-\-updateall[\s]+\-\-enableldap"\
|
|
r"[\s]+\-\-enableldaptls[\s]+\-\-enableldapauth[\s]+" \
|
|
r"\-\-ldapserver=.*[\s]+\-\-ldapbasedn=.*"
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_RedHatSSSDBefore19(self):
|
|
advice_id = 'config-redhat-sssd-before-1-9'
|
|
advice_regex = (
|
|
r"\#\!\/bin\/sh.*"
|
|
r"yum[\s]+install[\s]+\-y[\s]+sssd[\s]+authconfig[\s]+"
|
|
r"curl[\s]+openssl.*service[\s]+sssd[\s]+start"
|
|
)
|
|
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
# trivial checks
|
|
def test_advice_enable_admins_sudo(self):
|
|
advice_id = 'enable_admins_sudo'
|
|
advice_regex = r"\#\!\/bin\/sh.*"
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
def test_advice_config_server_for_smart_card_auth(self):
|
|
advice_id = 'config_server_for_smart_card_auth'
|
|
advice_regex = r"\#\!\/bin\/sh.*"
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
ca_pem = ExternalCA().create_ca()
|
|
ca_file = tasks.upload_temp_contents(self.master, ca_pem)
|
|
try:
|
|
self.execute_advise(self.master, advice_id, ca_file)
|
|
except Exception:
|
|
# debug: sometimes ipa-certupdate times out in
|
|
# "Resubmitting certmonger request"
|
|
self.master.run_command(['getcert', 'list'])
|
|
raise
|
|
finally:
|
|
self.master.run_command(['rm', '-f', ca_file])
|
|
sssd_conf = self.master.get_file_contents(
|
|
paths.SSSD_CONF, encoding='utf-8'
|
|
)
|
|
assert constants.HTTPD_USER in sssd_conf
|
|
assert IPAAPI_USER in sssd_conf
|
|
|
|
def test_advice_config_client_for_smart_card_auth(self):
|
|
advice_id = 'config_client_for_smart_card_auth'
|
|
advice_regex = r"\#\!\/bin\/sh.*"
|
|
run_advice(self.master, advice_id, advice_regex)
|
|
|
|
client = self.clients[0]
|
|
|
|
ca_pem = ExternalCA().create_ca()
|
|
ca_file = tasks.upload_temp_contents(client, ca_pem)
|
|
try:
|
|
self.execute_advise(client, advice_id, ca_file)
|
|
finally:
|
|
client.run_command(['rm', '-f', ca_file])
|
|
|
|
def test_ipa_advise(self):
|
|
"""Test ipa-advise is not failing with error.
|
|
|
|
The command should not fail with error in command.
|
|
|
|
Related: https://pagure.io/freeipa/issue/6044
|
|
"""
|
|
test = self.master.run_command(["ipa-advise"], raiseonerr=False)
|
|
error = "object of type 'type' has no len()"
|
|
assert error not in (test.stdout_text + test.stderr_text)
|