2016-03-06 03:47:39 -08:00
|
|
|
package sqlstore
|
|
|
|
|
|
|
|
|
|
import (
|
2021-07-16 12:40:03 +02:00
|
|
|
"context"
|
2018-11-12 20:01:53 +01:00
|
|
|
"strings"
|
2016-04-01 17:34:30 -07:00
|
|
|
"time"
|
|
|
|
|
|
2020-02-29 13:35:15 +01:00
|
|
|
"github.com/grafana/grafana/pkg/models"
|
2016-03-06 03:47:39 -08:00
|
|
|
)
|
|
|
|
|
|
2021-07-16 12:40:03 +02:00
|
|
|
func (ss *SQLStore) GetPreferencesWithDefaults(ctx context.Context, query *models.GetPreferencesWithDefaultsQuery) error {
|
|
|
|
|
return ss.WithDbSession(ctx, func(dbSession *DBSession) error {
|
|
|
|
|
params := make([]interface{}, 0)
|
|
|
|
|
filter := ""
|
2020-09-07 16:19:33 +02:00
|
|
|
|
2021-07-16 12:40:03 +02:00
|
|
|
if len(query.User.Teams) > 0 {
|
|
|
|
|
filter = "(org_id=? AND team_id IN (?" + strings.Repeat(",?", len(query.User.Teams)-1) + ")) OR "
|
|
|
|
|
params = append(params, query.User.OrgId)
|
|
|
|
|
for _, v := range query.User.Teams {
|
|
|
|
|
params = append(params, v)
|
|
|
|
|
}
|
2018-11-12 20:01:53 +01:00
|
|
|
}
|
2016-04-02 13:54:06 -07:00
|
|
|
|
2021-07-16 12:40:03 +02:00
|
|
|
filter += "(org_id=? AND user_id=? AND team_id=0) OR (org_id=? AND team_id=0 AND user_id=0)"
|
|
|
|
|
params = append(params, query.User.OrgId)
|
|
|
|
|
params = append(params, query.User.UserId)
|
|
|
|
|
params = append(params, query.User.OrgId)
|
|
|
|
|
prefs := make([]*models.Preferences, 0)
|
|
|
|
|
err := dbSession.Where(filter, params...).
|
|
|
|
|
OrderBy("user_id ASC, team_id ASC").
|
|
|
|
|
Find(&prefs)
|
2016-04-02 13:54:06 -07:00
|
|
|
|
2021-07-16 12:40:03 +02:00
|
|
|
if err != nil {
|
|
|
|
|
return err
|
2016-04-02 13:54:06 -07:00
|
|
|
}
|
2021-07-16 12:40:03 +02:00
|
|
|
|
|
|
|
|
res := &models.Preferences{
|
|
|
|
|
Theme: ss.Cfg.DefaultTheme,
|
|
|
|
|
Timezone: ss.Cfg.DateFormats.DefaultTimezone,
|
2021-10-18 10:27:14 -03:00
|
|
|
WeekStart: ss.Cfg.DateFormats.DefaultWeekStart,
|
2021-07-16 12:40:03 +02:00
|
|
|
HomeDashboardId: 0,
|
2022-03-17 12:07:20 +00:00
|
|
|
JsonData: &models.PreferencesJsonData{},
|
2016-04-02 13:54:06 -07:00
|
|
|
}
|
2021-07-16 12:40:03 +02:00
|
|
|
|
|
|
|
|
for _, p := range prefs {
|
|
|
|
|
if p.Theme != "" {
|
|
|
|
|
res.Theme = p.Theme
|
|
|
|
|
}
|
|
|
|
|
if p.Timezone != "" {
|
|
|
|
|
res.Timezone = p.Timezone
|
|
|
|
|
}
|
2021-10-18 10:27:14 -03:00
|
|
|
if p.WeekStart != "" {
|
|
|
|
|
res.WeekStart = p.WeekStart
|
|
|
|
|
}
|
2021-07-16 12:40:03 +02:00
|
|
|
if p.HomeDashboardId != 0 {
|
|
|
|
|
res.HomeDashboardId = p.HomeDashboardId
|
|
|
|
|
}
|
2022-03-17 12:07:20 +00:00
|
|
|
if p.JsonData != nil {
|
|
|
|
|
res.JsonData = p.JsonData
|
|
|
|
|
}
|
2016-04-02 13:54:06 -07:00
|
|
|
}
|
|
|
|
|
|
2021-07-16 12:40:03 +02:00
|
|
|
query.Result = res
|
|
|
|
|
return nil
|
|
|
|
|
})
|
2016-04-02 13:54:06 -07:00
|
|
|
}
|
|
|
|
|
|
2021-11-02 13:41:45 +01:00
|
|
|
func (ss *SQLStore) GetPreferences(ctx context.Context, query *models.GetPreferencesQuery) error {
|
|
|
|
|
return ss.WithDbSession(ctx, func(sess *DBSession) error {
|
|
|
|
|
var prefs models.Preferences
|
|
|
|
|
exists, err := sess.Where("org_id=? AND user_id=? AND team_id=?", query.OrgId, query.UserId, query.TeamId).Get(&prefs)
|
2016-03-06 11:42:15 -08:00
|
|
|
|
2021-11-02 13:41:45 +01:00
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2016-03-06 12:32:22 -08:00
|
|
|
|
2021-11-02 13:41:45 +01:00
|
|
|
if exists {
|
|
|
|
|
query.Result = &prefs
|
|
|
|
|
} else {
|
|
|
|
|
query.Result = new(models.Preferences)
|
|
|
|
|
}
|
2016-03-06 11:42:15 -08:00
|
|
|
|
2021-11-02 13:41:45 +01:00
|
|
|
return nil
|
|
|
|
|
})
|
2016-03-06 11:42:15 -08:00
|
|
|
}
|
|
|
|
|
|
2021-11-02 13:41:45 +01:00
|
|
|
func (ss *SQLStore) SavePreferences(ctx context.Context, cmd *models.SavePreferencesCommand) error {
|
|
|
|
|
return ss.WithTransactionalDbSession(ctx, func(sess *DBSession) error {
|
2020-02-29 13:35:15 +01:00
|
|
|
var prefs models.Preferences
|
2018-11-12 20:01:53 +01:00
|
|
|
exists, err := sess.Where("org_id=? AND user_id=? AND team_id=?", cmd.OrgId, cmd.UserId, cmd.TeamId).Get(&prefs)
|
2018-04-23 19:28:54 +02:00
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
2016-03-15 22:49:52 +01:00
|
|
|
|
|
|
|
|
if !exists {
|
2020-02-29 13:35:15 +01:00
|
|
|
prefs = models.Preferences{
|
2016-03-15 22:49:52 +01:00
|
|
|
UserId: cmd.UserId,
|
|
|
|
|
OrgId: cmd.OrgId,
|
2018-11-12 20:01:53 +01:00
|
|
|
TeamId: cmd.TeamId,
|
2016-03-15 22:49:52 +01:00
|
|
|
HomeDashboardId: cmd.HomeDashboardId,
|
|
|
|
|
Timezone: cmd.Timezone,
|
2021-10-18 10:27:14 -03:00
|
|
|
WeekStart: cmd.WeekStart,
|
2016-03-15 22:49:52 +01:00
|
|
|
Theme: cmd.Theme,
|
2016-03-16 23:35:06 -07:00
|
|
|
Created: time.Now(),
|
|
|
|
|
Updated: time.Now(),
|
2022-03-17 12:07:20 +00:00
|
|
|
JsonData: &models.PreferencesJsonData{},
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if cmd.Navbar != nil {
|
|
|
|
|
prefs.JsonData.Navbar = *cmd.Navbar
|
2016-03-15 22:49:52 +01:00
|
|
|
}
|
2022-04-12 11:42:42 +02:00
|
|
|
|
|
|
|
|
if cmd.QueryHistory != nil {
|
|
|
|
|
prefs.JsonData.QueryHistory = *cmd.QueryHistory
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-15 22:49:52 +01:00
|
|
|
_, err = sess.Insert(&prefs)
|
|
|
|
|
return err
|
2016-03-06 12:32:22 -08:00
|
|
|
}
|
2022-03-17 12:07:20 +00:00
|
|
|
// Wrap this in an if statement to maintain backwards compatibility
|
|
|
|
|
if cmd.Navbar != nil {
|
|
|
|
|
if prefs.JsonData == nil {
|
|
|
|
|
prefs.JsonData = &models.PreferencesJsonData{}
|
|
|
|
|
}
|
|
|
|
|
if cmd.Navbar.SavedItems != nil {
|
|
|
|
|
prefs.JsonData.Navbar.SavedItems = cmd.Navbar.SavedItems
|
|
|
|
|
}
|
|
|
|
|
}
|
2022-04-12 11:42:42 +02:00
|
|
|
|
|
|
|
|
if cmd.QueryHistory != nil {
|
|
|
|
|
if prefs.JsonData == nil {
|
|
|
|
|
prefs.JsonData = &models.PreferencesJsonData{}
|
|
|
|
|
}
|
|
|
|
|
if cmd.QueryHistory.HomeTab != "" {
|
|
|
|
|
prefs.JsonData.QueryHistory.HomeTab = cmd.QueryHistory.HomeTab
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 22:42:49 +02:00
|
|
|
prefs.HomeDashboardId = cmd.HomeDashboardId
|
2021-11-11 11:13:01 +01:00
|
|
|
prefs.Timezone = cmd.Timezone
|
2021-10-18 10:27:14 -03:00
|
|
|
prefs.WeekStart = cmd.WeekStart
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 22:42:49 +02:00
|
|
|
prefs.Theme = cmd.Theme
|
|
|
|
|
prefs.Updated = time.Now()
|
|
|
|
|
prefs.Version += 1
|
2018-09-16 12:37:08 +02:00
|
|
|
_, err = sess.ID(prefs.Id).AllCols().Update(&prefs)
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 22:42:49 +02:00
|
|
|
return err
|
2016-03-06 03:47:39 -08:00
|
|
|
})
|
|
|
|
|
}
|
2022-03-17 12:07:20 +00:00
|
|
|
|
|
|
|
|
func (ss *SQLStore) PatchPreferences(ctx context.Context, cmd *models.PatchPreferencesCommand) error {
|
|
|
|
|
return ss.WithTransactionalDbSession(ctx, func(sess *DBSession) error {
|
|
|
|
|
var prefs models.Preferences
|
|
|
|
|
exists, err := sess.Where("org_id=? AND user_id=? AND team_id=?", cmd.OrgId, cmd.UserId, cmd.TeamId).Get(&prefs)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if !exists {
|
|
|
|
|
prefs = models.Preferences{
|
|
|
|
|
UserId: cmd.UserId,
|
|
|
|
|
OrgId: cmd.OrgId,
|
|
|
|
|
TeamId: cmd.TeamId,
|
|
|
|
|
Created: time.Now(),
|
|
|
|
|
JsonData: &models.PreferencesJsonData{},
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if cmd.Navbar != nil {
|
|
|
|
|
if prefs.JsonData == nil {
|
|
|
|
|
prefs.JsonData = &models.PreferencesJsonData{}
|
|
|
|
|
}
|
|
|
|
|
if cmd.Navbar.SavedItems != nil {
|
|
|
|
|
prefs.JsonData.Navbar.SavedItems = cmd.Navbar.SavedItems
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-04-12 11:42:42 +02:00
|
|
|
if cmd.QueryHistory != nil {
|
|
|
|
|
if prefs.JsonData == nil {
|
|
|
|
|
prefs.JsonData = &models.PreferencesJsonData{}
|
|
|
|
|
}
|
|
|
|
|
if cmd.QueryHistory.HomeTab != "" {
|
|
|
|
|
prefs.JsonData.QueryHistory.HomeTab = cmd.QueryHistory.HomeTab
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-03-17 12:07:20 +00:00
|
|
|
if cmd.HomeDashboardId != nil {
|
|
|
|
|
prefs.HomeDashboardId = *cmd.HomeDashboardId
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if cmd.Timezone != nil {
|
|
|
|
|
prefs.Timezone = *cmd.Timezone
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if cmd.WeekStart != nil {
|
|
|
|
|
prefs.WeekStart = *cmd.WeekStart
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if cmd.Theme != nil {
|
|
|
|
|
prefs.Theme = *cmd.Theme
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
prefs.Updated = time.Now()
|
|
|
|
|
prefs.Version += 1
|
|
|
|
|
|
|
|
|
|
if exists {
|
|
|
|
|
_, err = sess.ID(prefs.Id).AllCols().Update(&prefs)
|
|
|
|
|
} else {
|
|
|
|
|
_, err = sess.Insert(&prefs)
|
|
|
|
|
}
|
|
|
|
|
return err
|
|
|
|
|
})
|
|
|
|
|
}
|