2015-02-27 06:45:00 -06:00
|
|
|
package plugins
|
|
|
|
|
|
|
|
import (
|
2017-12-11 08:05:06 -06:00
|
|
|
"context"
|
2015-02-27 06:45:00 -06:00
|
|
|
"encoding/json"
|
|
|
|
"errors"
|
2017-08-31 07:05:52 -05:00
|
|
|
"fmt"
|
2016-03-13 13:21:44 -05:00
|
|
|
"io/ioutil"
|
2015-02-27 06:45:00 -06:00
|
|
|
"os"
|
2015-02-27 15:29:00 -06:00
|
|
|
"path"
|
2015-02-27 06:45:00 -06:00
|
|
|
"path/filepath"
|
2016-01-09 16:34:20 -06:00
|
|
|
"reflect"
|
2015-11-19 09:50:17 -06:00
|
|
|
"strings"
|
2018-04-27 08:11:55 -05:00
|
|
|
"time"
|
2015-02-27 06:45:00 -06:00
|
|
|
|
2019-05-13 01:45:54 -05:00
|
|
|
"github.com/grafana/grafana/pkg/infra/log"
|
2020-01-15 06:10:48 -06:00
|
|
|
"github.com/grafana/grafana/pkg/infra/metrics"
|
2020-01-08 10:43:28 -06:00
|
|
|
"github.com/grafana/grafana/pkg/plugins/backendplugin"
|
2018-04-27 08:11:55 -05:00
|
|
|
"github.com/grafana/grafana/pkg/registry"
|
2015-02-27 15:29:00 -06:00
|
|
|
"github.com/grafana/grafana/pkg/setting"
|
2015-10-07 23:22:09 -05:00
|
|
|
"github.com/grafana/grafana/pkg/util"
|
2019-10-11 14:02:15 -05:00
|
|
|
"github.com/grafana/grafana/pkg/util/errutil"
|
|
|
|
"golang.org/x/xerrors"
|
2015-02-27 06:45:00 -06:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2017-12-20 09:24:49 -06:00
|
|
|
DataSources map[string]*DataSourcePlugin
|
|
|
|
Panels map[string]*PanelPlugin
|
|
|
|
StaticRoutes []*PluginStaticRoute
|
|
|
|
Apps map[string]*AppPlugin
|
|
|
|
Plugins map[string]*PluginBase
|
2018-01-09 07:56:23 -06:00
|
|
|
PluginTypes map[string]interface{}
|
2018-05-24 08:26:27 -05:00
|
|
|
Renderer *RendererPlugin
|
2019-10-29 11:22:31 -05:00
|
|
|
Transform *TransformPlugin
|
2016-04-11 11:21:48 -05:00
|
|
|
|
|
|
|
GrafanaLatestVersion string
|
|
|
|
GrafanaHasUpdate bool
|
2016-06-06 16:06:44 -05:00
|
|
|
plog log.Logger
|
2015-02-27 06:45:00 -06:00
|
|
|
)
|
|
|
|
|
|
|
|
type PluginScanner struct {
|
2020-01-13 13:18:45 -06:00
|
|
|
pluginPath string
|
|
|
|
errors []error
|
|
|
|
backendPluginManager backendplugin.Manager
|
2020-03-25 06:25:39 -05:00
|
|
|
cfg *setting.Cfg
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
|
|
|
|
2017-12-11 08:05:06 -06:00
|
|
|
type PluginManager struct {
|
2020-01-13 13:18:45 -06:00
|
|
|
BackendPluginManager backendplugin.Manager `inject:""`
|
2020-03-25 06:25:39 -05:00
|
|
|
Cfg *setting.Cfg `inject:""`
|
2020-01-13 13:18:45 -06:00
|
|
|
log log.Logger
|
2017-12-11 08:05:06 -06:00
|
|
|
}
|
|
|
|
|
2018-04-27 08:11:55 -05:00
|
|
|
func init() {
|
|
|
|
registry.RegisterService(&PluginManager{})
|
2017-12-11 08:05:06 -06:00
|
|
|
}
|
|
|
|
|
2018-04-27 08:11:55 -05:00
|
|
|
func (pm *PluginManager) Init() error {
|
|
|
|
pm.log = log.New("plugins")
|
2016-06-06 16:06:44 -05:00
|
|
|
plog = log.New("plugins")
|
|
|
|
|
2018-01-09 07:56:23 -06:00
|
|
|
DataSources = map[string]*DataSourcePlugin{}
|
|
|
|
StaticRoutes = []*PluginStaticRoute{}
|
|
|
|
Panels = map[string]*PanelPlugin{}
|
|
|
|
Apps = map[string]*AppPlugin{}
|
|
|
|
Plugins = map[string]*PluginBase{}
|
2016-01-09 16:34:20 -06:00
|
|
|
PluginTypes = map[string]interface{}{
|
2017-12-15 10:17:58 -06:00
|
|
|
"panel": PanelPlugin{},
|
|
|
|
"datasource": DataSourcePlugin{},
|
|
|
|
"app": AppPlugin{},
|
2018-05-24 08:26:27 -05:00
|
|
|
"renderer": RendererPlugin{},
|
2019-10-29 11:22:31 -05:00
|
|
|
"transform": TransformPlugin{},
|
2016-01-09 16:34:20 -06:00
|
|
|
}
|
2015-11-19 05:55:13 -06:00
|
|
|
|
2018-04-27 08:11:55 -05:00
|
|
|
pm.log.Info("Starting plugin search")
|
2019-10-11 14:02:15 -05:00
|
|
|
plugDir := path.Join(setting.StaticRootPath, "app/plugins")
|
|
|
|
if err := pm.scan(plugDir); err != nil {
|
|
|
|
return errutil.Wrapf(err, "Failed to scan main plugin directory '%s'", plugDir)
|
|
|
|
}
|
2016-02-10 04:03:12 -06:00
|
|
|
|
2020-04-07 02:04:24 -05:00
|
|
|
pm.log.Info("Checking Bundled Plugins")
|
|
|
|
plugDir = path.Join(setting.HomePath, "plugins-bundled")
|
|
|
|
if _, err := os.Stat(plugDir); !os.IsNotExist(err) {
|
|
|
|
if err := pm.scan(plugDir); err != nil {
|
|
|
|
return errutil.Wrapf(err, "failed to scan bundled plugin directory '%s'", plugDir)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-10 04:03:12 -06:00
|
|
|
// check if plugins dir exists
|
|
|
|
if _, err := os.Stat(setting.PluginsPath); os.IsNotExist(err) {
|
|
|
|
if err = os.MkdirAll(setting.PluginsPath, os.ModePerm); err != nil {
|
2018-01-09 07:56:23 -06:00
|
|
|
plog.Error("Failed to create plugin dir", "dir", setting.PluginsPath, "error", err)
|
2016-02-10 04:03:12 -06:00
|
|
|
} else {
|
2016-06-06 16:06:44 -05:00
|
|
|
plog.Info("Plugin dir created", "dir", setting.PluginsPath)
|
2019-10-11 14:02:15 -05:00
|
|
|
if err := pm.scan(setting.PluginsPath); err != nil {
|
|
|
|
return errutil.Wrapf(err, "Failed to scan configured plugin directory '%s'",
|
|
|
|
setting.PluginsPath)
|
|
|
|
}
|
2016-02-10 04:03:12 -06:00
|
|
|
}
|
|
|
|
} else {
|
2019-10-11 14:02:15 -05:00
|
|
|
if err := pm.scan(setting.PluginsPath); err != nil {
|
|
|
|
return errutil.Wrapf(err, "Failed to scan configured plugin directory '%s'",
|
|
|
|
setting.PluginsPath)
|
|
|
|
}
|
2016-02-10 04:03:12 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// check plugin paths defined in config
|
2019-10-11 14:02:15 -05:00
|
|
|
if err := pm.checkPluginPaths(); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2016-02-09 15:10:36 -06:00
|
|
|
|
|
|
|
for _, panel := range Panels {
|
|
|
|
panel.initFrontendPlugin()
|
|
|
|
}
|
2018-01-09 07:56:23 -06:00
|
|
|
|
2017-12-15 10:17:58 -06:00
|
|
|
for _, ds := range DataSources {
|
|
|
|
ds.initFrontendPlugin()
|
2016-02-09 15:10:36 -06:00
|
|
|
}
|
2018-01-09 07:56:23 -06:00
|
|
|
|
2016-02-09 15:10:36 -06:00
|
|
|
for _, app := range Apps {
|
|
|
|
app.initApp()
|
|
|
|
}
|
|
|
|
|
2020-01-15 06:10:48 -06:00
|
|
|
for _, p := range Plugins {
|
2020-04-09 02:00:16 -05:00
|
|
|
if p.IsCorePlugin {
|
|
|
|
p.Signature = PluginSignatureInternal
|
|
|
|
} else {
|
|
|
|
p.Signature = GetPluginSignatureState(p)
|
2020-01-15 06:10:48 -06:00
|
|
|
metrics.SetPluginBuildInformation(p.Id, p.Type, p.Info.Version)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-27 08:11:55 -05:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (pm *PluginManager) Run(ctx context.Context) error {
|
|
|
|
pm.updateAppDashboards()
|
|
|
|
pm.checkForUpdates()
|
|
|
|
|
|
|
|
ticker := time.NewTicker(time.Minute * 10)
|
2018-04-27 14:22:29 -05:00
|
|
|
run := true
|
|
|
|
|
|
|
|
for run {
|
2018-04-27 08:11:55 -05:00
|
|
|
select {
|
|
|
|
case <-ticker.C:
|
|
|
|
pm.checkForUpdates()
|
|
|
|
case <-ctx.Done():
|
2018-04-27 14:22:29 -05:00
|
|
|
run = false
|
2018-04-27 08:11:55 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-27 14:22:29 -05:00
|
|
|
return ctx.Err()
|
2015-11-19 09:50:17 -06:00
|
|
|
}
|
|
|
|
|
2019-10-11 14:02:15 -05:00
|
|
|
func (pm *PluginManager) checkPluginPaths() error {
|
2018-04-30 09:21:04 -05:00
|
|
|
for _, section := range setting.Raw.Sections() {
|
2019-10-11 14:02:15 -05:00
|
|
|
if !strings.HasPrefix(section.Name(), "plugin.") {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
path := section.Key("path").String()
|
|
|
|
if path == "" {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := pm.scan(path); err != nil {
|
|
|
|
return errutil.Wrapf(err, "Failed to scan directory configured for plugin '%s': '%s'",
|
|
|
|
section.Name(), path)
|
2015-11-19 09:50:17 -06:00
|
|
|
}
|
|
|
|
}
|
2019-10-11 14:02:15 -05:00
|
|
|
|
2015-11-19 09:50:17 -06:00
|
|
|
return nil
|
2015-02-27 15:29:00 -06:00
|
|
|
}
|
|
|
|
|
2019-10-11 14:02:15 -05:00
|
|
|
// scan a directory for plugins.
|
|
|
|
func (pm *PluginManager) scan(pluginDir string) error {
|
2015-02-27 06:45:00 -06:00
|
|
|
scanner := &PluginScanner{
|
2020-01-13 13:18:45 -06:00
|
|
|
pluginPath: pluginDir,
|
|
|
|
backendPluginManager: pm.BackendPluginManager,
|
2020-03-25 06:25:39 -05:00
|
|
|
cfg: pm.Cfg,
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
|
|
|
|
2015-10-07 23:22:09 -05:00
|
|
|
if err := util.Walk(pluginDir, true, true, scanner.walker); err != nil {
|
2019-10-11 14:02:15 -05:00
|
|
|
if xerrors.Is(err, os.ErrNotExist) {
|
|
|
|
pm.log.Debug("Couldn't scan dir '%s' since it doesn't exist")
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if xerrors.Is(err, os.ErrPermission) {
|
|
|
|
pm.log.Debug("Couldn't scan dir '%s' due to lack of permissions")
|
|
|
|
return nil
|
|
|
|
}
|
2016-01-07 01:51:31 -06:00
|
|
|
if pluginDir != "data/plugins" {
|
2019-10-11 14:02:15 -05:00
|
|
|
pm.log.Warn("Could not scan dir", "pluginDir", pluginDir, "err", err)
|
2016-01-07 01:51:31 -06:00
|
|
|
}
|
2015-02-27 06:45:00 -06:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(scanner.errors) > 0 {
|
2019-10-18 07:39:38 -05:00
|
|
|
pm.log.Warn("Some plugins failed to load", "errors", scanner.errors)
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-03-13 06:31:44 -05:00
|
|
|
// GetDatasource returns a datasource based on passed pluginID if it exists
|
|
|
|
//
|
|
|
|
// This function fetches the datasource from the global variable DataSources in this package.
|
|
|
|
// Rather then refactor all dependencies on the global variable we can use this as an transition.
|
|
|
|
func (pm *PluginManager) GetDatasource(pluginID string) (*DataSourcePlugin, bool) {
|
|
|
|
ds, exist := DataSources[pluginID]
|
|
|
|
return ds, exist
|
|
|
|
}
|
|
|
|
|
2015-11-19 09:50:17 -06:00
|
|
|
func (scanner *PluginScanner) walker(currentPath string, f os.FileInfo, err error) error {
|
2019-07-29 03:44:58 -05:00
|
|
|
// We scan all the subfolders for plugin.json (with some exceptions) so that we also load embedded plugins, for
|
|
|
|
// example https://github.com/raintank/worldping-app/tree/master/dist/grafana-worldmap-panel worldmap panel plugin
|
|
|
|
// is embedded in worldping app.
|
2015-02-27 06:45:00 -06:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2019-07-29 03:44:58 -05:00
|
|
|
if f.Name() == "node_modules" || f.Name() == "Chromium.app" {
|
2019-01-28 15:37:44 -06:00
|
|
|
return util.ErrWalkSkipDir
|
2016-02-09 11:17:32 -06:00
|
|
|
}
|
|
|
|
|
2015-02-27 06:45:00 -06:00
|
|
|
if f.IsDir() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-03-25 06:25:39 -05:00
|
|
|
if !scanner.cfg.FeatureToggles["tracingIntegration"] {
|
|
|
|
// Do not load tracing datasources if
|
|
|
|
prefix := path.Join(setting.StaticRootPath, "app/plugins/datasource")
|
|
|
|
if strings.Contains(currentPath, path.Join(prefix, "jaeger")) || strings.Contains(currentPath, path.Join(prefix, "zipkin")) {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-27 06:45:00 -06:00
|
|
|
if f.Name() == "plugin.json" {
|
2015-11-19 09:50:17 -06:00
|
|
|
err := scanner.loadPluginJson(currentPath)
|
2015-02-27 06:45:00 -06:00
|
|
|
if err != nil {
|
2016-02-10 04:03:12 -06:00
|
|
|
log.Error(3, "Plugins: Failed to load plugin json file: %v, err: %v", currentPath, err)
|
2015-02-27 06:45:00 -06:00
|
|
|
scanner.errors = append(scanner.errors, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2015-11-19 09:50:17 -06:00
|
|
|
func (scanner *PluginScanner) loadPluginJson(pluginJsonFilePath string) error {
|
|
|
|
currentDir := filepath.Dir(pluginJsonFilePath)
|
|
|
|
reader, err := os.Open(pluginJsonFilePath)
|
2015-02-27 06:45:00 -06:00
|
|
|
if err != nil {
|
2015-02-27 15:29:00 -06:00
|
|
|
return err
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
defer reader.Close()
|
|
|
|
|
|
|
|
jsonParser := json.NewDecoder(reader)
|
2016-01-09 16:34:20 -06:00
|
|
|
pluginCommon := PluginBase{}
|
2016-01-08 16:15:44 -06:00
|
|
|
if err := jsonParser.Decode(&pluginCommon); err != nil {
|
2015-02-27 15:29:00 -06:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2016-01-08 16:15:44 -06:00
|
|
|
if pluginCommon.Id == "" || pluginCommon.Type == "" {
|
|
|
|
return errors.New("Did not find type and id property in plugin.json")
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
|
|
|
|
2016-01-09 16:34:20 -06:00
|
|
|
var loader PluginLoader
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 15:42:49 -05:00
|
|
|
pluginGoType, exists := PluginTypes[pluginCommon.Type]
|
|
|
|
if !exists {
|
2016-02-12 18:01:03 -06:00
|
|
|
return errors.New("Unknown plugin type " + pluginCommon.Type)
|
2015-12-03 01:52:37 -06:00
|
|
|
}
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 15:42:49 -05:00
|
|
|
loader = reflect.New(reflect.TypeOf(pluginGoType)).Interface().(PluginLoader)
|
2015-12-03 01:52:37 -06:00
|
|
|
|
2019-08-22 00:04:02 -05:00
|
|
|
// External plugins need a module.js file for SystemJS to load
|
2019-09-24 00:54:28 -05:00
|
|
|
if !strings.HasPrefix(pluginJsonFilePath, setting.StaticRootPath) && !scanner.IsBackendOnlyPlugin(pluginCommon.Type) {
|
2019-08-22 00:04:02 -05:00
|
|
|
module := filepath.Join(filepath.Dir(pluginJsonFilePath), "module.js")
|
|
|
|
if _, err := os.Stat(module); os.IsNotExist(err) {
|
|
|
|
plog.Warn("Plugin missing module.js",
|
|
|
|
"name", pluginCommon.Name,
|
|
|
|
"warning", "Missing module.js, If you loaded this plugin from git, make sure to compile it.",
|
|
|
|
"path", module)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-10-11 14:02:15 -05:00
|
|
|
if _, err := reader.Seek(0, 0); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2020-01-13 13:18:45 -06:00
|
|
|
return loader.Load(jsonParser, currentDir, scanner.backendPluginManager)
|
2015-02-27 06:45:00 -06:00
|
|
|
}
|
2016-03-13 13:21:44 -05:00
|
|
|
|
2019-09-24 00:54:28 -05:00
|
|
|
func (scanner *PluginScanner) IsBackendOnlyPlugin(pluginType string) bool {
|
2019-10-29 11:22:31 -05:00
|
|
|
return pluginType == "renderer" || pluginType == "transform"
|
2019-09-24 00:54:28 -05:00
|
|
|
}
|
|
|
|
|
2017-08-31 07:05:52 -05:00
|
|
|
func GetPluginMarkdown(pluginId string, name string) ([]byte, error) {
|
2016-03-13 13:21:44 -05:00
|
|
|
plug, exists := Plugins[pluginId]
|
|
|
|
if !exists {
|
|
|
|
return nil, PluginNotFoundError{pluginId}
|
|
|
|
}
|
|
|
|
|
2017-08-31 07:05:52 -05:00
|
|
|
path := filepath.Join(plug.PluginDir, fmt.Sprintf("%s.md", strings.ToUpper(name)))
|
|
|
|
if _, err := os.Stat(path); os.IsNotExist(err) {
|
|
|
|
path = filepath.Join(plug.PluginDir, fmt.Sprintf("%s.md", strings.ToLower(name)))
|
2016-03-13 13:21:44 -05:00
|
|
|
}
|
|
|
|
|
2017-08-31 07:05:52 -05:00
|
|
|
if _, err := os.Stat(path); os.IsNotExist(err) {
|
|
|
|
return make([]byte, 0), nil
|
2016-03-13 13:21:44 -05:00
|
|
|
}
|
|
|
|
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 15:42:49 -05:00
|
|
|
data, err := ioutil.ReadFile(path)
|
|
|
|
if err != nil {
|
2016-03-13 13:21:44 -05:00
|
|
|
return nil, err
|
|
|
|
}
|
Outdent code after if block that ends with return (golint)
This commit fixes the following golint warnings:
pkg/bus/bus.go:64:9: if block ends with a return statement, so drop this else and outdent its block
pkg/bus/bus.go:84:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:137:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:177:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:183:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:199:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:208:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/components/dynmap/dynmap.go:236:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:242:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:257:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:263:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:278:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:284:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:299:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:331:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:350:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:356:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:366:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:390:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:396:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:405:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:427:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:433:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:442:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:459:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:465:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:474:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:491:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:497:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:506:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:523:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:529:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:538:12: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:555:9: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:561:10: if block ends with a return statement, so drop this else and outdent its block
pkg/components/dynmap/dynmap.go:570:12: if block ends with a return statement, so drop this else and outdent its block
pkg/login/ldap.go:55:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/login/ldap_test.go:372:10: if block ends with a return statement, so drop this else and outdent its block
pkg/middleware/middleware_test.go:213:12: if block ends with a return statement, so drop this else and outdent its block
pkg/plugins/dashboard_importer.go:153:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:39:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/dashboards_updater.go:121:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:210:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/plugins/plugins.go:235:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/eval_context.go:111:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:92:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:98:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifier.go:122:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:108:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:118:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/rule.go:121:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/alerting/notifiers/telegram.go:94:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/annotation.go:34:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/annotation.go:99:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/dashboard_test.go:107:13: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/plugin_setting.go:78:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/preferences.go:91:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/user.go:50:10: if block ends with a return statement, so drop this else and outdent its block
pkg/services/sqlstore/migrator/migrator.go:106:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/services/sqlstore/migrator/postgres_dialect.go:48:10: if block ends with a return statement, so drop this else and outdent its block
pkg/tsdb/time_range.go:59:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/time_range.go:67:9: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
pkg/tsdb/cloudwatch/metric_find_query.go:225:9: if block ends with a return statement, so drop this else and outdent its block
pkg/util/filepath.go:68:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
2018-04-27 15:42:49 -05:00
|
|
|
return data, nil
|
2016-03-13 13:21:44 -05:00
|
|
|
}
|