2022-04-22 08:33:13 -05:00
|
|
|
import { UrlQueryMap } from '@grafana/data';
|
|
|
|
|
|
|
|
import { VariableRefresh } from './types';
|
2021-06-16 01:36:25 -05:00
|
|
|
import {
|
|
|
|
containsVariable,
|
|
|
|
ensureStringValues,
|
|
|
|
findTemplateVarChanges,
|
|
|
|
getCurrentText,
|
|
|
|
getVariableRefresh,
|
|
|
|
isAllVariable,
|
|
|
|
} from './utils';
|
2020-08-24 02:29:21 -05:00
|
|
|
|
|
|
|
describe('isAllVariable', () => {
|
|
|
|
it.each`
|
2021-02-05 00:16:06 -06:00
|
|
|
variable | expected
|
|
|
|
${null} | ${false}
|
|
|
|
${undefined} | ${false}
|
|
|
|
${{}} | ${false}
|
|
|
|
${{ current: {} }} | ${false}
|
|
|
|
${{ current: { text: '' } }} | ${false}
|
|
|
|
${{ current: { text: null } }} | ${false}
|
|
|
|
${{ current: { text: undefined } }} | ${false}
|
|
|
|
${{ current: { text: 'Alll' } }} | ${false}
|
|
|
|
${{ current: { text: 'All' } }} | ${true}
|
|
|
|
${{ current: { text: [] } }} | ${false}
|
|
|
|
${{ current: { text: [null] } }} | ${false}
|
|
|
|
${{ current: { text: [undefined] } }} | ${false}
|
|
|
|
${{ current: { text: ['Alll'] } }} | ${false}
|
|
|
|
${{ current: { text: ['Alll', 'All'] } }} | ${false}
|
|
|
|
${{ current: { text: ['All'] } }} | ${true}
|
|
|
|
${{ current: { text: ['All', 'Alll'] } }} | ${true}
|
|
|
|
${{ current: { text: { prop1: 'test' } } }} | ${false}
|
|
|
|
${{ current: { value: '' } }} | ${false}
|
|
|
|
${{ current: { value: null } }} | ${false}
|
|
|
|
${{ current: { value: undefined } }} | ${false}
|
|
|
|
${{ current: { value: '$__alll' } }} | ${false}
|
|
|
|
${{ current: { value: '$__all' } }} | ${true}
|
|
|
|
${{ current: { value: [] } }} | ${false}
|
|
|
|
${{ current: { value: [null] } }} | ${false}
|
|
|
|
${{ current: { value: [undefined] } }} | ${false}
|
|
|
|
${{ current: { value: ['$__alll'] } }} | ${false}
|
|
|
|
${{ current: { value: ['$__alll', '$__all'] } }} | ${false}
|
|
|
|
${{ current: { value: ['$__all'] } }} | ${true}
|
|
|
|
${{ current: { value: ['$__all', '$__alll'] } }} | ${true}
|
|
|
|
${{ current: { value: { prop1: 'test' } } }} | ${false}
|
|
|
|
${{ current: { value: '', text: '' } }} | ${false}
|
|
|
|
${{ current: { value: '', text: 'All' } }} | ${true}
|
|
|
|
${{ current: { value: '$__all', text: '' } }} | ${true}
|
|
|
|
${{ current: { value: '', text: ['All'] } }} | ${true}
|
|
|
|
${{ current: { value: ['$__all'], text: '' } }} | ${true}
|
2020-08-24 02:29:21 -05:00
|
|
|
`("when called with params: 'variable': '$variable' then result should be '$expected'", ({ variable, expected }) => {
|
|
|
|
expect(isAllVariable(variable)).toEqual(expected);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('getCurrentText', () => {
|
|
|
|
it.each`
|
|
|
|
variable | expected
|
|
|
|
${null} | ${''}
|
|
|
|
${undefined} | ${''}
|
|
|
|
${{}} | ${''}
|
|
|
|
${{ current: {} }} | ${''}
|
|
|
|
${{ current: { text: '' } }} | ${''}
|
|
|
|
${{ current: { text: null } }} | ${''}
|
|
|
|
${{ current: { text: undefined } }} | ${''}
|
|
|
|
${{ current: { text: 'A' } }} | ${'A'}
|
|
|
|
${{ current: { text: 'All' } }} | ${'All'}
|
|
|
|
${{ current: { text: [] } }} | ${''}
|
|
|
|
${{ current: { text: [null] } }} | ${''}
|
|
|
|
${{ current: { text: [undefined] } }} | ${''}
|
|
|
|
${{ current: { text: ['A'] } }} | ${'A'}
|
|
|
|
${{ current: { text: ['A', 'All'] } }} | ${'A,All'}
|
|
|
|
${{ current: { text: ['All'] } }} | ${'All'}
|
|
|
|
${{ current: { text: { prop1: 'test' } } }} | ${''}
|
|
|
|
`("when called with params: 'variable': '$variable' then result should be '$expected'", ({ variable, expected }) => {
|
|
|
|
expect(getCurrentText(variable)).toEqual(expected);
|
|
|
|
});
|
|
|
|
});
|
2020-11-04 01:56:02 -06:00
|
|
|
|
|
|
|
describe('getVariableRefresh', () => {
|
|
|
|
it.each`
|
|
|
|
variable | expected
|
|
|
|
${null} | ${VariableRefresh.never}
|
|
|
|
${undefined} | ${VariableRefresh.never}
|
|
|
|
${{}} | ${VariableRefresh.never}
|
|
|
|
${{ refresh: VariableRefresh.never }} | ${VariableRefresh.never}
|
|
|
|
${{ refresh: VariableRefresh.onTimeRangeChanged }} | ${VariableRefresh.onTimeRangeChanged}
|
|
|
|
${{ refresh: VariableRefresh.onDashboardLoad }} | ${VariableRefresh.onDashboardLoad}
|
|
|
|
${{ refresh: 'invalid' }} | ${VariableRefresh.never}
|
|
|
|
`("when called with params: 'variable': '$variable' then result should be '$expected'", ({ variable, expected }) => {
|
|
|
|
expect(getVariableRefresh(variable)).toEqual(expected);
|
|
|
|
});
|
|
|
|
});
|
Routing NG: Replace Angular routing with react-router (#31463)
* Add router packages
* Get react app root work instead of Angular one
* Logger util
* Patch Angular routing ($routeProvider, $routeParamsProvider)
* Use react-router-dom history instead of separate dependency
* Add test routes
* Sidemenu - use Link instead of anchors
* Patch Angular $location service (stub)
* WIP: geting rid of $location provider from TimeSrv
* Intercept anchor clicks to use history under the hood
* Sync Redux location slice with history state
* Make login/logout work
* Debug routes for testing
* Make force login work
* Make sure query param change does not recreate page components
* Hide side menu in specified locations
* Make the dashboar route query parameters work, make panel edit menu work
* Enable more routes
* Fix side menu
* Handle view modes
* Disable playlist routes
* Make SafeDynamicImport work again
* Bring back router-debug
* Separate redux location sync from route rendering
* Refactor updateLocation to thunk and move force refresh(login) to it
* Fixing init dashboard issue
* Support switching between dashboards without an unmount of DashboardPage
* More fixes for init dashboard and panel edit
* More type fixes
* Moving angular location wrapper out of main LocationService, and fixing typescript issues
* Fixed last typescript errors
* LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523)
* Moving location service implementation to runtime and removing get function and making it a package const singleton
* Added test that used locationService directly
* removed unused import
* AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525)
* Fixes angular panels by calling the monkey patch
* Moving angular stuff to to it's own files
* udpated
* Fixing clicking on divs and spans inside anchor
* Moving app notifications out of angular app and removing angular directive wrapper
* Moving search from angular to react and removing angular search wrapper
* Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back
* Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back)
* Open and close search now works
* Hide sidemenu when in kiosk mode
* Restoring some keybindings like ESC key
* Removed kiosk events and simplified it, just handled through updating URL
* Fixing typescript errors
* Simplified GrafanaRouteComponentProps and renamed to ContainerProps
* renamed back
* Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it
* Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change
* SafeDynamicImport causing unmount un every search update, not sure how to fix yet
* Fix signature for SafeDynamicImport so we do not create new route components on every route render
* Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc
* Updating DashboardPage and SoloPanelPage to use match params and history location
* Fixed DashboardPage tests
* Fixing solo route tests
* LocationService: Rename getCurrentLocation to just getLocation
* do not intercept link clicks with target blank or self
* Experimental useUrlParams hook
* Update DataSourceSettingsPage to use router match params
* fix links with urls that have no starting / to work like before
* Fix forceLogin
* Add queryParams to GrafanaRouteComponentProps
* PanelEditor get rid of updateLocation and location state
* Improve grafana route query params typing
* Add getSearchObject to LocationService
* Use DashboardPAge queryParams instead of location.search parsing
* Fix DashboardPage typing
* Fix some tests weirdness
* Bring back KeyboardSrv
* Fixes typescript issues
* Team pages now use router match params
* Get rid of from GrafanaRouteComponent props
* Removed unnessary calls to getSearchObject when calling locationService.partial
* Updated DashboardPage tests after queryParams was added
* Fixing dashboard settings back
* GrafanaRoute: Adding tests and remove use of global locationService
* Fixing tests and typescript errors
* Bring back kiosk modes and add tests
* Fix TimeSrv tests
* Fix typecheck errors
* Fixing tests
* Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory
* Get rid of routeChange event from TimeSrv from
* Fixed TopSectionItem test
* Trying to make basename work but failing
* Update TopSectionItem snapshot
* Fix TopSectionItem snapshot test
* Fix API keys creation
* Remove Angular dependencies from KeybindingSrv (#31617)
* Remove Angular dependency from KeybindingsSrv
* Fix tests and typecheck issues
* basename is starting to work
* Make dashboard save work
* KeybindingSrv: Remove as angular service and no usage angular scope
* So long bridge_srv, we won't miss you
* Update snapshots
* Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653)
* Dashboard: Refactoring ChangeTracker to use History api and no angular
* Updated
* Removed logging
* fixed unit tests
* updated snapshots
* Mechanism for force reloading routes (#31683)
* e2e: Fixes various things in e2e scenarios after router migration (#31685)
* Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688)
* RoutingNG: Initial explore redux location to router location migration
* Updated explore Wrapper tests
* Fixing more tests
* remove loggin
* rename back to make naming consistent
* Fixing return to dashboard button
* fixing navigation to explore from dashboard
* updated routeProps
* Updated tests
* Make DashboardListPage work
* Fixing navigation after add new data source, and fixes explore e2e
* Fixing solo panel page
* PluginsPage now works
* RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725)
* RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays
* Fixed test
* Make snapshots list work
* fixed alert notification channel edit page
* Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that
* fixed UserAdminPage
* fixed edit orgs page
* Fixing LdapPage
* fixing dashboard import
* Fixed new folder page
* Fixed data source dashboards page
* fixing Folder permissions and folder settings page
* fixing snapshot list page nav model
* remove unused file
* Added placeholder page for playlist
* Moved browser compatability to index-template
* Restored 404/default page
* Fixed reset password page
* Fixed SignUpInvited page
* Fixing CreateTeam, Create user page, add panel widget
* Restore browwser file to make tests happy
* Fixed unit tests
* Removed unused import
* Replacing usage of updateLocation
* Fixed test
* Updating search filters to use history / location service for filters
* remove unused file
* AppRootPage fixed
* Fixing test and search issue
* Changes to support enterprise extensions
* remove console.log
* Removing more use of redux location
* Fixed signup page
* removed unused old angular controllers
* Fixing bugs
* one final bugfix
* Removed location from redux state
* Fixing ts issues and tests
* Fixing test issue
* fixing tests
* Fixing tests
* removed unused stuff
* Fixed search test
* Adding some doc comments
* Routing NG: Angular location provider patch (#31773)
* Patch Angulars $location provider
* Update public/app/angular/bridgeReactAngularRouting.ts
* Remove only test
* Update tests, disable loggers in test env
* Routing NG: remove $location provider usage (#31816)
* Remove dashboard_loaders
* Remove $location from Analytics service, track page views form GrafanaRoute
* Remove NotificationsEditCtrl
* Remove Angular dependencies from uploadDashboardDirective
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove unused test helpers (#31831)
* Playlist react (#31829)
* playlist list in react
* Playlist start
* Things started to work
* Updated
* Handle empty list
* Fix ts
* Fixes and kiosk mode stuff
* Removed unused events
* fixing ts issue
* Another ts issue
* Fixing tests
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
* fixed test
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove Angular dependency from DashboardLoaderSrv (#31863)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2021-03-10 11:03:36 -06:00
|
|
|
|
|
|
|
describe('findTemplateVarChanges', () => {
|
|
|
|
it('detect adding/removing a variable', () => {
|
|
|
|
const a: UrlQueryMap = {};
|
|
|
|
const b: UrlQueryMap = {
|
|
|
|
'var-xyz': 'hello',
|
|
|
|
aaa: 'ignore me',
|
|
|
|
};
|
|
|
|
|
2021-08-13 02:10:37 -05:00
|
|
|
expect(findTemplateVarChanges(b, a)).toEqual({ 'var-xyz': { value: 'hello' } });
|
|
|
|
expect(findTemplateVarChanges(a, b)).toEqual({ 'var-xyz': { value: '', removed: true } });
|
Routing NG: Replace Angular routing with react-router (#31463)
* Add router packages
* Get react app root work instead of Angular one
* Logger util
* Patch Angular routing ($routeProvider, $routeParamsProvider)
* Use react-router-dom history instead of separate dependency
* Add test routes
* Sidemenu - use Link instead of anchors
* Patch Angular $location service (stub)
* WIP: geting rid of $location provider from TimeSrv
* Intercept anchor clicks to use history under the hood
* Sync Redux location slice with history state
* Make login/logout work
* Debug routes for testing
* Make force login work
* Make sure query param change does not recreate page components
* Hide side menu in specified locations
* Make the dashboar route query parameters work, make panel edit menu work
* Enable more routes
* Fix side menu
* Handle view modes
* Disable playlist routes
* Make SafeDynamicImport work again
* Bring back router-debug
* Separate redux location sync from route rendering
* Refactor updateLocation to thunk and move force refresh(login) to it
* Fixing init dashboard issue
* Support switching between dashboards without an unmount of DashboardPage
* More fixes for init dashboard and panel edit
* More type fixes
* Moving angular location wrapper out of main LocationService, and fixing typescript issues
* Fixed last typescript errors
* LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523)
* Moving location service implementation to runtime and removing get function and making it a package const singleton
* Added test that used locationService directly
* removed unused import
* AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525)
* Fixes angular panels by calling the monkey patch
* Moving angular stuff to to it's own files
* udpated
* Fixing clicking on divs and spans inside anchor
* Moving app notifications out of angular app and removing angular directive wrapper
* Moving search from angular to react and removing angular search wrapper
* Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back
* Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back)
* Open and close search now works
* Hide sidemenu when in kiosk mode
* Restoring some keybindings like ESC key
* Removed kiosk events and simplified it, just handled through updating URL
* Fixing typescript errors
* Simplified GrafanaRouteComponentProps and renamed to ContainerProps
* renamed back
* Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it
* Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change
* SafeDynamicImport causing unmount un every search update, not sure how to fix yet
* Fix signature for SafeDynamicImport so we do not create new route components on every route render
* Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc
* Updating DashboardPage and SoloPanelPage to use match params and history location
* Fixed DashboardPage tests
* Fixing solo route tests
* LocationService: Rename getCurrentLocation to just getLocation
* do not intercept link clicks with target blank or self
* Experimental useUrlParams hook
* Update DataSourceSettingsPage to use router match params
* fix links with urls that have no starting / to work like before
* Fix forceLogin
* Add queryParams to GrafanaRouteComponentProps
* PanelEditor get rid of updateLocation and location state
* Improve grafana route query params typing
* Add getSearchObject to LocationService
* Use DashboardPAge queryParams instead of location.search parsing
* Fix DashboardPage typing
* Fix some tests weirdness
* Bring back KeyboardSrv
* Fixes typescript issues
* Team pages now use router match params
* Get rid of from GrafanaRouteComponent props
* Removed unnessary calls to getSearchObject when calling locationService.partial
* Updated DashboardPage tests after queryParams was added
* Fixing dashboard settings back
* GrafanaRoute: Adding tests and remove use of global locationService
* Fixing tests and typescript errors
* Bring back kiosk modes and add tests
* Fix TimeSrv tests
* Fix typecheck errors
* Fixing tests
* Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory
* Get rid of routeChange event from TimeSrv from
* Fixed TopSectionItem test
* Trying to make basename work but failing
* Update TopSectionItem snapshot
* Fix TopSectionItem snapshot test
* Fix API keys creation
* Remove Angular dependencies from KeybindingSrv (#31617)
* Remove Angular dependency from KeybindingsSrv
* Fix tests and typecheck issues
* basename is starting to work
* Make dashboard save work
* KeybindingSrv: Remove as angular service and no usage angular scope
* So long bridge_srv, we won't miss you
* Update snapshots
* Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653)
* Dashboard: Refactoring ChangeTracker to use History api and no angular
* Updated
* Removed logging
* fixed unit tests
* updated snapshots
* Mechanism for force reloading routes (#31683)
* e2e: Fixes various things in e2e scenarios after router migration (#31685)
* Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688)
* RoutingNG: Initial explore redux location to router location migration
* Updated explore Wrapper tests
* Fixing more tests
* remove loggin
* rename back to make naming consistent
* Fixing return to dashboard button
* fixing navigation to explore from dashboard
* updated routeProps
* Updated tests
* Make DashboardListPage work
* Fixing navigation after add new data source, and fixes explore e2e
* Fixing solo panel page
* PluginsPage now works
* RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725)
* RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays
* Fixed test
* Make snapshots list work
* fixed alert notification channel edit page
* Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that
* fixed UserAdminPage
* fixed edit orgs page
* Fixing LdapPage
* fixing dashboard import
* Fixed new folder page
* Fixed data source dashboards page
* fixing Folder permissions and folder settings page
* fixing snapshot list page nav model
* remove unused file
* Added placeholder page for playlist
* Moved browser compatability to index-template
* Restored 404/default page
* Fixed reset password page
* Fixed SignUpInvited page
* Fixing CreateTeam, Create user page, add panel widget
* Restore browwser file to make tests happy
* Fixed unit tests
* Removed unused import
* Replacing usage of updateLocation
* Fixed test
* Updating search filters to use history / location service for filters
* remove unused file
* AppRootPage fixed
* Fixing test and search issue
* Changes to support enterprise extensions
* remove console.log
* Removing more use of redux location
* Fixed signup page
* removed unused old angular controllers
* Fixing bugs
* one final bugfix
* Removed location from redux state
* Fixing ts issues and tests
* Fixing test issue
* fixing tests
* Fixing tests
* removed unused stuff
* Fixed search test
* Adding some doc comments
* Routing NG: Angular location provider patch (#31773)
* Patch Angulars $location provider
* Update public/app/angular/bridgeReactAngularRouting.ts
* Remove only test
* Update tests, disable loggers in test env
* Routing NG: remove $location provider usage (#31816)
* Remove dashboard_loaders
* Remove $location from Analytics service, track page views form GrafanaRoute
* Remove NotificationsEditCtrl
* Remove Angular dependencies from uploadDashboardDirective
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove unused test helpers (#31831)
* Playlist react (#31829)
* playlist list in react
* Playlist start
* Things started to work
* Updated
* Handle empty list
* Fix ts
* Fixes and kiosk mode stuff
* Removed unused events
* fixing ts issue
* Another ts issue
* Fixing tests
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
* fixed test
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove Angular dependency from DashboardLoaderSrv (#31863)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2021-03-10 11:03:36 -06:00
|
|
|
});
|
|
|
|
|
|
|
|
it('then should ignore equal values', () => {
|
|
|
|
const a: UrlQueryMap = {
|
|
|
|
'var-xyz': 'hello',
|
|
|
|
bbb: 'ignore me',
|
|
|
|
};
|
|
|
|
const b: UrlQueryMap = {
|
|
|
|
'var-xyz': 'hello',
|
|
|
|
aaa: 'ignore me',
|
|
|
|
};
|
|
|
|
|
|
|
|
expect(findTemplateVarChanges(b, a)).toBeUndefined();
|
|
|
|
expect(findTemplateVarChanges(a, b)).toBeUndefined();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('then should ignore equal values with empty values', () => {
|
|
|
|
const a: UrlQueryMap = {
|
|
|
|
'var-xyz': '',
|
|
|
|
bbb: 'ignore me',
|
|
|
|
};
|
|
|
|
const b: UrlQueryMap = {
|
|
|
|
'var-xyz': '',
|
|
|
|
aaa: 'ignore me',
|
|
|
|
};
|
|
|
|
|
|
|
|
expect(findTemplateVarChanges(b, a)).toBeUndefined();
|
|
|
|
expect(findTemplateVarChanges(a, b)).toBeUndefined();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('then should ignore empty array values', () => {
|
|
|
|
const a: UrlQueryMap = {
|
|
|
|
'var-adhoc': [],
|
|
|
|
};
|
|
|
|
const b: UrlQueryMap = {};
|
|
|
|
|
|
|
|
expect(findTemplateVarChanges(b, a)).toBeUndefined();
|
|
|
|
expect(findTemplateVarChanges(a, b)).toBeUndefined();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('Should handle array values with one value same as just value', () => {
|
|
|
|
const a: UrlQueryMap = {
|
|
|
|
'var-test': ['test'],
|
|
|
|
};
|
|
|
|
const b: UrlQueryMap = {
|
|
|
|
'var-test': 'test',
|
|
|
|
};
|
|
|
|
|
|
|
|
expect(findTemplateVarChanges(b, a)).toBeUndefined();
|
|
|
|
expect(findTemplateVarChanges(a, b)).toBeUndefined();
|
|
|
|
});
|
|
|
|
|
|
|
|
it('Should detect change in array value and return array with single value', () => {
|
|
|
|
const a: UrlQueryMap = {
|
|
|
|
'var-test': ['test'],
|
|
|
|
};
|
|
|
|
const b: UrlQueryMap = {
|
|
|
|
'var-test': 'asd',
|
|
|
|
};
|
|
|
|
|
2021-08-13 02:10:37 -05:00
|
|
|
expect(findTemplateVarChanges(a, b)!['var-test']).toEqual({ value: ['test'] });
|
Routing NG: Replace Angular routing with react-router (#31463)
* Add router packages
* Get react app root work instead of Angular one
* Logger util
* Patch Angular routing ($routeProvider, $routeParamsProvider)
* Use react-router-dom history instead of separate dependency
* Add test routes
* Sidemenu - use Link instead of anchors
* Patch Angular $location service (stub)
* WIP: geting rid of $location provider from TimeSrv
* Intercept anchor clicks to use history under the hood
* Sync Redux location slice with history state
* Make login/logout work
* Debug routes for testing
* Make force login work
* Make sure query param change does not recreate page components
* Hide side menu in specified locations
* Make the dashboar route query parameters work, make panel edit menu work
* Enable more routes
* Fix side menu
* Handle view modes
* Disable playlist routes
* Make SafeDynamicImport work again
* Bring back router-debug
* Separate redux location sync from route rendering
* Refactor updateLocation to thunk and move force refresh(login) to it
* Fixing init dashboard issue
* Support switching between dashboards without an unmount of DashboardPage
* More fixes for init dashboard and panel edit
* More type fixes
* Moving angular location wrapper out of main LocationService, and fixing typescript issues
* Fixed last typescript errors
* LocationService: Move to runtime and remove getLocationService and export singleston const instead (#31523)
* Moving location service implementation to runtime and removing get function and making it a package const singleton
* Added test that used locationService directly
* removed unused import
* AngularApp: Moving angular dependencies and the app boot out of the main app into it's own file (#31525)
* Fixes angular panels by calling the monkey patch
* Moving angular stuff to to it's own files
* udpated
* Fixing clicking on divs and spans inside anchor
* Moving app notifications out of angular app and removing angular directive wrapper
* Moving search from angular to react and removing angular search wrapper
* Clean up, tried to remove the redux location wrapper but requires a big update for DashboardPage, so adding it back
* Moving AppWrapper to root to limit circular dependencies (app/core -> app/routing and back)
* Open and close search now works
* Hide sidemenu when in kiosk mode
* Restoring some keybindings like ESC key
* Removed kiosk events and simplified it, just handled through updating URL
* Fixing typescript errors
* Simplified GrafanaRouteComponentProps and renamed to ContainerProps
* renamed back
* Changed AlertRuleList to use GrafanaRouteComponentProps and location.search passed to it
* Removing the reloadOnSearch property, this is not needed now for react as react by default does not unmount components when only url match or query parmas change
* SafeDynamicImport causing unmount un every search update, not sure how to fix yet
* Fix signature for SafeDynamicImport so we do not create new route components on every route render
* Removing the redux location wrapper as it was causing errors, and making dashboard page work with RouteProps (location, match) etc
* Updating DashboardPage and SoloPanelPage to use match params and history location
* Fixed DashboardPage tests
* Fixing solo route tests
* LocationService: Rename getCurrentLocation to just getLocation
* do not intercept link clicks with target blank or self
* Experimental useUrlParams hook
* Update DataSourceSettingsPage to use router match params
* fix links with urls that have no starting / to work like before
* Fix forceLogin
* Add queryParams to GrafanaRouteComponentProps
* PanelEditor get rid of updateLocation and location state
* Improve grafana route query params typing
* Add getSearchObject to LocationService
* Use DashboardPAge queryParams instead of location.search parsing
* Fix DashboardPage typing
* Fix some tests weirdness
* Bring back KeyboardSrv
* Fixes typescript issues
* Team pages now use router match params
* Get rid of from GrafanaRouteComponent props
* Removed unnessary calls to getSearchObject when calling locationService.partial
* Updated DashboardPage tests after queryParams was added
* Fixing dashboard settings back
* GrafanaRoute: Adding tests and remove use of global locationService
* Fixing tests and typescript errors
* Bring back kiosk modes and add tests
* Fix TimeSrv tests
* Fix typecheck errors
* Fixing tests
* Updated SideMenu test to react-testing and wrapped component in Router, and fixed issue importing createMemoryHistory
* Get rid of routeChange event from TimeSrv from
* Fixed TopSectionItem test
* Trying to make basename work but failing
* Update TopSectionItem snapshot
* Fix TopSectionItem snapshot test
* Fix API keys creation
* Remove Angular dependencies from KeybindingSrv (#31617)
* Remove Angular dependency from KeybindingsSrv
* Fix tests and typecheck issues
* basename is starting to work
* Make dashboard save work
* KeybindingSrv: Remove as angular service and no usage angular scope
* So long bridge_srv, we won't miss you
* Update snapshots
* Dashboard: Refactoring ChangeTracker to use History api and no angular (#31653)
* Dashboard: Refactoring ChangeTracker to use History api and no angular
* Updated
* Removed logging
* fixed unit tests
* updated snapshots
* Mechanism for force reloading routes (#31683)
* e2e: Fixes various things in e2e scenarios after router migration (#31685)
* Explore: Update reading query params from router props and updating location via locationService (ReactRouter) (#31688)
* RoutingNG: Initial explore redux location to router location migration
* Updated explore Wrapper tests
* Fixing more tests
* remove loggin
* rename back to make naming consistent
* Fixing return to dashboard button
* fixing navigation to explore from dashboard
* updated routeProps
* Updated tests
* Make DashboardListPage work
* Fixing navigation after add new data source, and fixes explore e2e
* Fixing solo panel page
* PluginsPage now works
* RoutingNG: When parsing and rendering url search/query params preseve old logic of handling booleans and arrays (#31725)
* RoutingNG: When parsing and rendering url search/query params preserve old logic of handling booleans and arrays
* Fixed test
* Make snapshots list work
* fixed alert notification channel edit page
* Simplify LocationService, did not need special handling for login or forceLogin as target _self on link already handles that
* fixed UserAdminPage
* fixed edit orgs page
* Fixing LdapPage
* fixing dashboard import
* Fixed new folder page
* Fixed data source dashboards page
* fixing Folder permissions and folder settings page
* fixing snapshot list page nav model
* remove unused file
* Added placeholder page for playlist
* Moved browser compatability to index-template
* Restored 404/default page
* Fixed reset password page
* Fixed SignUpInvited page
* Fixing CreateTeam, Create user page, add panel widget
* Restore browwser file to make tests happy
* Fixed unit tests
* Removed unused import
* Replacing usage of updateLocation
* Fixed test
* Updating search filters to use history / location service for filters
* remove unused file
* AppRootPage fixed
* Fixing test and search issue
* Changes to support enterprise extensions
* remove console.log
* Removing more use of redux location
* Fixed signup page
* removed unused old angular controllers
* Fixing bugs
* one final bugfix
* Removed location from redux state
* Fixing ts issues and tests
* Fixing test issue
* fixing tests
* Fixing tests
* removed unused stuff
* Fixed search test
* Adding some doc comments
* Routing NG: Angular location provider patch (#31773)
* Patch Angulars $location provider
* Update public/app/angular/bridgeReactAngularRouting.ts
* Remove only test
* Update tests, disable loggers in test env
* Routing NG: remove $location provider usage (#31816)
* Remove dashboard_loaders
* Remove $location from Analytics service, track page views form GrafanaRoute
* Remove NotificationsEditCtrl
* Remove Angular dependencies from uploadDashboardDirective
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/features/dashboard/containers/DashboardPage.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove unused test helpers (#31831)
* Playlist react (#31829)
* playlist list in react
* Playlist start
* Things started to work
* Updated
* Handle empty list
* Fix ts
* Fixes and kiosk mode stuff
* Removed unused events
* fixing ts issue
* Another ts issue
* Fixing tests
Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com>
* fixed test
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Update public/app/AppWrapper.tsx
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
* Remove Angular dependency from DashboardLoaderSrv (#31863)
Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Co-authored-by: Torkel Ödegaard <torkel@grafana.org>
Co-authored-by: Hugo Häggmark <hugo.haggmark@grafana.com>
Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
2021-03-10 11:03:36 -06:00
|
|
|
});
|
|
|
|
});
|
2021-03-15 02:52:44 -05:00
|
|
|
|
|
|
|
describe('ensureStringValues', () => {
|
|
|
|
it.each`
|
|
|
|
value | expected
|
|
|
|
${null} | ${''}
|
|
|
|
${undefined} | ${''}
|
|
|
|
${{}} | ${''}
|
|
|
|
${{ current: {} }} | ${''}
|
|
|
|
${1} | ${'1'}
|
|
|
|
${[1, 2]} | ${['1', '2']}
|
|
|
|
${'1'} | ${'1'}
|
|
|
|
${['1', '2']} | ${['1', '2']}
|
2021-06-01 23:40:37 -05:00
|
|
|
${true} | ${'true'}
|
2021-03-15 02:52:44 -05:00
|
|
|
`('when called with value:$value then result should be:$expected', ({ value, expected }) => {
|
|
|
|
expect(ensureStringValues(value)).toEqual(expected);
|
|
|
|
});
|
|
|
|
});
|
2021-06-16 01:36:25 -05:00
|
|
|
|
|
|
|
describe('containsVariable', () => {
|
|
|
|
it.each`
|
2022-03-31 09:59:14 -05:00
|
|
|
value | expected
|
|
|
|
${''} | ${false}
|
|
|
|
${'$var'} | ${true}
|
|
|
|
${{ thing1: '${var}' }} | ${true}
|
|
|
|
${{ thing1: '${var:fmt}' }} | ${true}
|
|
|
|
${{ thing1: ['1', '${var}'] }} | ${true}
|
|
|
|
${{ thing1: ['1', '[[var]]'] }} | ${true}
|
|
|
|
${{ thing1: ['1', '[[var:fmt]]'] }} | ${true}
|
|
|
|
${{ thing1: { thing2: '${var}' } }} | ${true}
|
|
|
|
${{ params: [['param', '$var']] }} | ${true}
|
|
|
|
${{ params: [['param', '${var}']] }} | ${true}
|
2021-06-16 01:36:25 -05:00
|
|
|
`('when called with value:$value then result should be:$expected', ({ value, expected }) => {
|
|
|
|
expect(containsVariable(value, 'var')).toEqual(expected);
|
|
|
|
});
|
|
|
|
});
|