Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
import { css } from '@emotion/css';
|
|
|
|
import React from 'react';
|
|
|
|
|
|
|
|
import { Button, Modal } from '@grafana/ui';
|
|
|
|
|
|
|
|
interface UnsavedChangesModalProps {
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
message: string;
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
onDiscard: () => void;
|
|
|
|
onCancel: () => void;
|
|
|
|
onSave: () => void;
|
|
|
|
}
|
|
|
|
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
export const CorrelationUnsavedChangesModal = ({ onSave, onDiscard, onCancel, message }: UnsavedChangesModalProps) => {
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
return (
|
|
|
|
<Modal
|
|
|
|
isOpen={true}
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
title={`Unsaved changes to correlation`}
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
onDismiss={onCancel}
|
|
|
|
icon="exclamation-triangle"
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
className={css({ width: '600px' })}
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
>
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
<h5>{message}</h5>
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
<Modal.ButtonRow>
|
|
|
|
<Button variant="secondary" onClick={onCancel} fill="outline">
|
|
|
|
Cancel
|
|
|
|
</Button>
|
|
|
|
<Button variant="destructive" onClick={onDiscard}>
|
Correlations: Add transformations to Explore Editor (#75930)
* Add transformation add modal and use it
* Hook up saving
* Add transformation vars to var list, show added transformations
* Form validation
* Remove type assertion, start building out transformation data in helper (WIP)
* Style expression better, add delete logic
* Add ability to edit, additional styling on transformation card in helper
* simplify styling, conditionally run edit set up logic
* Keep more field information in function, integrate it with new editor
* Show default label on collapsed section, use deleteButton for confirmation of deleting transformations
* Change transformation add calculations from function to hook, add label to collapsed header, add transformation tooltip
* Make correlation and editor dirty state distinctive and integrate, WIP
* Track action pane for more detailed messaging/actions
* Better cancel modal logic
* Remove changes to adminsitration transformation editor
* Remove debugging line
* Remove unneeded comment
* Add in logic for closing editor mode
* Add tests for modal logic
* Use state to build vars list for helper
* WIP
* Fix labels and dirty state
* Fix bad message and stop exiting mode if discard action is performed
* Fix tests
* Update to not use unstable component and tweak default label
2023-11-02 15:09:30 -05:00
|
|
|
Continue without saving
|
Correlations: Add an editor in Explore (#73315)
* Start adding correlations editor mode
* Add selector for merge conflict resolution
* Enable saving
* Build out new corelation helper component
* flesh out save with label/description, change color
* Have breadcrumb exit correlation editor mode
* Add extension property to show/hide, use it for correlations
* Bring in feature toggle
* Remove unnecessary param
* Cleanup
* Parse logs json
* Work on correlation edit mode bar
* Tinker with a top element for the editor mode
* Handle various explore state changes with correlations editor mode
* WIP - add unsaved changes modal
* Have correlation bar always rendered, sometimes hidden
* Add various prompt modals
* Clear correlations data on mode bar unmount, only use not left pane changes to count as dirty
* Move special logic to explore
* Remove all shouldShow logic from plugin extensions
* remove grafana data changes
* WIP - clean up correlations state
* Interpolate data before sending to onclick
* Override outline button coloring to account for dark background
* More cleanup, more color tweaking
* Prettier formatting, change state to refer to editor
* Fix tests
* More state change tweaks
* ensure correlation save ability, change correlation editor state vars
* fix import
* Remove independent selector for editorMode, work close pane into editor exit flow
* Add change datasource post action
* Clean up based on PR feedback, handle closing left panel with helper better
* Remove breadcrumb additions, add section and better ID to cmd palette action
* Interpolate query results if it is ran with a helper with vars
* Pass the datasource query along with the correlate link to ensure the datasource unique ID requirement passes
* Use different onmount function to capture state of panes at time of close instead of time of mount
* Fix node graph’s datalink not working
* Actually commit the fix to saving
* Fix saving correlations with mixed datasource to use the first query correlation UID
* Add tracking
* Use query datasources in mixed scenario, move exit tracking to click handler
* Add correlations to a place where both can be used in the correlations editor
* Be more selective on when we await the datasource get
* Fix CSS to use objects
* Update betterer
* Add test around new decorator functionality
* Add tests for decorate with correlations
* Some reorganization and a few tweaks based on feedback
* Move dirty state change to state function and out of component
* Change the verbiage around a little
* Various suggestions from Gio
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
* More small Gio-related tweaks
* Tie helper data to datasource - clear it out when the datasource changes
* Missed another Gio tweak
* Fix linter error
* Only clear helper data on left pane changes
* Add height offset for correlation editor bar so it doesn’t scroll off page
---------
Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>
Co-authored-by: Giordano Ricci <me@giordanoricci.com>
2023-10-03 09:28:29 -05:00
|
|
|
</Button>
|
|
|
|
<Button variant="primary" onClick={onSave}>
|
|
|
|
Save correlation
|
|
|
|
</Button>
|
|
|
|
</Modal.ButtonRow>
|
|
|
|
</Modal>
|
|
|
|
);
|
|
|
|
};
|