2017-06-12 08:48:55 -05:00
package api
import (
2021-06-15 09:08:27 -05:00
"context"
2017-06-12 08:48:55 -05:00
"encoding/json"
2018-02-19 04:12:56 -06:00
"fmt"
2021-07-16 05:40:03 -05:00
"net/http"
2022-08-10 08:37:51 -05:00
"os"
2017-06-12 08:48:55 -05:00
"testing"
2023-03-30 09:31:53 -05:00
"time"
2017-06-12 08:48:55 -05:00
2022-03-10 11:19:50 -06:00
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
2017-06-12 08:48:55 -05:00
"github.com/grafana/grafana/pkg/api/dtos"
2021-01-15 07:43:20 -06:00
"github.com/grafana/grafana/pkg/api/response"
"github.com/grafana/grafana/pkg/api/routing"
2023-01-26 02:21:10 -06:00
"github.com/grafana/grafana/pkg/bus"
2017-06-12 16:05:32 -05:00
"github.com/grafana/grafana/pkg/components/simplejson"
2022-10-19 08:02:15 -05:00
"github.com/grafana/grafana/pkg/infra/db"
2023-01-17 07:17:54 -06:00
"github.com/grafana/grafana/pkg/infra/db/dbtest"
2023-03-30 09:31:53 -05:00
"github.com/grafana/grafana/pkg/infra/localcache"
"github.com/grafana/grafana/pkg/infra/log"
2023-01-26 02:21:10 -06:00
"github.com/grafana/grafana/pkg/infra/tracing"
2021-09-22 09:28:40 -05:00
"github.com/grafana/grafana/pkg/infra/usagestats"
2023-08-29 08:09:09 -05:00
"github.com/grafana/grafana/pkg/services/accesscontrol"
2023-01-23 03:54:29 -06:00
"github.com/grafana/grafana/pkg/services/accesscontrol/acimpl"
2022-11-24 08:38:55 -06:00
"github.com/grafana/grafana/pkg/services/accesscontrol/actest"
2022-03-10 05:58:18 -06:00
accesscontrolmock "github.com/grafana/grafana/pkg/services/accesscontrol/mock"
2018-10-13 00:53:28 -05:00
"github.com/grafana/grafana/pkg/services/alerting"
2022-09-19 02:54:37 -05:00
"github.com/grafana/grafana/pkg/services/annotations/annotationstest"
2023-09-06 04:16:10 -05:00
"github.com/grafana/grafana/pkg/services/auth/identity"
2023-01-27 01:50:36 -06:00
contextmodel "github.com/grafana/grafana/pkg/services/contexthandler/model"
2017-12-12 09:15:24 -06:00
"github.com/grafana/grafana/pkg/services/dashboards"
2022-02-16 07:15:44 -06:00
"github.com/grafana/grafana/pkg/services/dashboards/database"
2022-05-21 19:44:12 -05:00
"github.com/grafana/grafana/pkg/services/dashboards/service"
2022-05-25 03:41:51 -05:00
dashver "github.com/grafana/grafana/pkg/services/dashboardversion"
"github.com/grafana/grafana/pkg/services/dashboardversion/dashvertest"
2022-01-26 11:44:20 -06:00
"github.com/grafana/grafana/pkg/services/featuremgmt"
2022-10-10 14:47:53 -05:00
"github.com/grafana/grafana/pkg/services/folder"
2023-01-26 02:21:10 -06:00
"github.com/grafana/grafana/pkg/services/folder/folderimpl"
2022-11-11 07:28:24 -06:00
"github.com/grafana/grafana/pkg/services/folder/foldertest"
2022-03-21 04:49:49 -05:00
"github.com/grafana/grafana/pkg/services/guardian"
2023-02-01 10:32:05 -06:00
"github.com/grafana/grafana/pkg/services/libraryelements/model"
2023-09-06 04:16:10 -05:00
"github.com/grafana/grafana/pkg/services/librarypanels"
2020-10-28 03:36:57 -05:00
"github.com/grafana/grafana/pkg/services/live"
2022-08-10 04:56:48 -05:00
"github.com/grafana/grafana/pkg/services/org"
2023-09-11 06:59:24 -05:00
"github.com/grafana/grafana/pkg/services/pluginsintegration/pluginstore"
2022-04-21 08:03:17 -05:00
pref "github.com/grafana/grafana/pkg/services/preference"
"github.com/grafana/grafana/pkg/services/preference/preftest"
2019-04-30 06:32:18 -05:00
"github.com/grafana/grafana/pkg/services/provisioning"
2023-07-17 05:21:44 -05:00
"github.com/grafana/grafana/pkg/services/publicdashboards"
"github.com/grafana/grafana/pkg/services/publicdashboards/api"
2022-11-14 13:08:10 -06:00
"github.com/grafana/grafana/pkg/services/quota/quotatest"
2023-08-09 01:54:52 -05:00
"github.com/grafana/grafana/pkg/services/star/startest"
2022-09-21 07:04:01 -05:00
"github.com/grafana/grafana/pkg/services/tag/tagimpl"
2022-08-10 04:56:48 -05:00
"github.com/grafana/grafana/pkg/services/user"
2023-07-17 05:21:44 -05:00
"github.com/grafana/grafana/pkg/services/user/usertest"
2017-12-15 07:19:49 -06:00
"github.com/grafana/grafana/pkg/setting"
2021-10-11 07:30:59 -05:00
"github.com/grafana/grafana/pkg/web"
2023-08-29 08:09:09 -05:00
"github.com/grafana/grafana/pkg/web/webtest"
2017-06-12 08:48:55 -05:00
)
2020-06-22 11:00:39 -05:00
func TestGetHomeDashboard ( t * testing . T ) {
2021-07-16 05:40:03 -05:00
httpReq , err := http . NewRequest ( http . MethodGet , "" , nil )
require . NoError ( t , err )
2022-02-09 06:44:38 -06:00
httpReq . Header . Add ( "Content-Type" , "application/json" )
2023-01-27 01:50:36 -06:00
req := & contextmodel . ReqContext { SignedInUser : & user . SignedInUser { } , Context : & web . Context { Req : httpReq } }
2020-06-22 11:00:39 -05:00
cfg := setting . NewCfg ( )
cfg . StaticRootPath = "../../public/"
2022-04-21 08:03:17 -05:00
prefService := preftest . NewPreferenceServiceFake ( )
2022-05-25 03:41:51 -05:00
dashboardVersionService := dashvertest . NewDashboardVersionServiceFake ( )
2020-06-22 11:00:39 -05:00
2021-03-17 10:06:10 -05:00
hs := & HTTPServer {
2022-05-25 03:41:51 -05:00
Cfg : cfg ,
2023-09-11 06:59:24 -05:00
pluginStore : & pluginstore . FakePluginStore { } ,
2023-01-17 07:17:54 -06:00
SQLStore : dbtest . NewFakeDB ( ) ,
2022-05-25 03:41:51 -05:00
preferenceService : prefService ,
dashboardVersionService : dashboardVersionService ,
2023-08-30 09:51:18 -05:00
log : log . New ( "test-logger" ) ,
2021-03-17 10:06:10 -05:00
}
2020-06-22 11:00:39 -05:00
tests := [ ] struct {
name string
defaultSetting string
expectedDashboardPath string
} {
{ name : "using default config" , defaultSetting : "" , expectedDashboardPath : "../../public/dashboards/home.json" } ,
{ name : "custom path" , defaultSetting : "../../public/dashboards/default.json" , expectedDashboardPath : "../../public/dashboards/default.json" } ,
}
for _ , tc := range tests {
t . Run ( tc . name , func ( t * testing . T ) {
dash := dtos . DashboardFullWithMeta { }
dash . Meta . FolderTitle = "General"
2022-08-10 08:37:51 -05:00
homeDashJSON , err := os . ReadFile ( tc . expectedDashboardPath )
2020-06-22 11:00:39 -05:00
require . NoError ( t , err , "must be able to read expected dashboard file" )
hs . Cfg . DefaultHomeDashboardPath = tc . defaultSetting
bytes , err := simplejson . NewJson ( homeDashJSON )
require . NoError ( t , err , "must be able to encode file as JSON" )
2022-04-21 08:03:17 -05:00
prefService . ExpectedPreference = & pref . Preference { }
2020-06-22 11:00:39 -05:00
dash . Dashboard = bytes
b , err := json . Marshal ( dash )
require . NoError ( t , err , "must be able to marshal object to JSON" )
res := hs . GetHomeDashboard ( req )
2021-01-15 07:43:20 -06:00
nr , ok := res . ( * response . NormalResponse )
2020-06-22 11:00:39 -05:00
require . True ( t , ok , "should return *NormalResponse" )
2021-01-15 07:43:20 -06:00
require . Equal ( t , b , nr . Body ( ) , "default home dashboard should equal content on disk" )
2020-06-22 11:00:39 -05:00
} )
}
}
2022-10-14 14:33:06 -05:00
func newTestLive ( t * testing . T , store db . DB ) * live . GrafanaLive {
2022-01-26 11:44:20 -06:00
features := featuremgmt . WithFeatures ( )
2023-11-13 09:55:15 -06:00
cfg := setting . NewCfg ( )
cfg . AppURL = "http://localhost:3000/"
2022-01-26 11:44:20 -06:00
gLive , err := live . ProvideService ( nil , cfg ,
routing . NewRouteRegister ( ) ,
2023-02-27 12:48:18 -06:00
nil , nil , nil , nil ,
2022-03-22 14:48:32 -05:00
store ,
2022-01-26 11:44:20 -06:00
nil ,
& usagestats . UsageStatsMock { T : t } ,
nil ,
2023-01-23 03:54:29 -06:00
features , acimpl . ProvideAccessControl ( cfg ) , & dashboards . FakeDashboardService { } , annotationstest . NewFakeAnnotationsRepo ( ) , nil )
2021-05-04 10:44:55 -05:00
require . NoError ( t , err )
return gLive
}
2023-08-29 08:09:09 -05:00
func TestHTTPServer_GetDashboard_AccessControl ( t * testing . T ) {
setup := func ( ) * webtest . Server {
return SetupAPITestServer ( t , func ( hs * HTTPServer ) {
dash := dashboards . NewDashboard ( "some dash" )
dash . ID = 1
dash . UID = "1"
2018-01-30 07:09:30 -06:00
2023-08-29 08:09:09 -05:00
dashSvc := dashboards . NewFakeDashboardService ( t )
dashSvc . On ( "GetDashboard" , mock . Anything , mock . Anything ) . Return ( dash , nil ) . Maybe ( )
hs . DashboardService = dashSvc
2018-01-31 09:51:06 -06:00
2023-08-29 08:09:09 -05:00
hs . Cfg = setting . NewCfg ( )
hs . AccessControl = acimpl . ProvideAccessControl ( hs . Cfg )
hs . starService = startest . NewStarServiceFake ( )
hs . dashboardProvisioningService = mockDashboardProvisioningService { }
2018-01-29 14:23:07 -06:00
2023-08-29 08:09:09 -05:00
guardian . InitAccessControlGuardian ( hs . Cfg , hs . AccessControl , hs . DashboardService )
} )
}
2017-06-22 16:43:55 -05:00
2023-08-29 08:09:09 -05:00
getDashboard := func ( server * webtest . Server , permissions [ ] accesscontrol . Permission ) ( * http . Response , error ) {
return server . Send ( webtest . RequestWithSignedInUser ( server . NewGetRequest ( "/api/dashboards/uid/1" ) , userWithPermissions ( 1 , permissions ) ) )
}
2018-01-30 07:09:30 -06:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should not be able to get dashboard without correct permission" , func ( t * testing . T ) {
server := setup ( )
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
res , err := getDashboard ( server , nil )
require . NoError ( t , err )
assert . Equal ( t , http . StatusForbidden , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
2017-06-12 08:48:55 -05:00
} )
2023-08-29 08:09:09 -05:00
t . Run ( "Should be able to get when user has permission to read dashboard" , func ( t * testing . T ) {
server := setup ( )
2023-01-25 03:36:26 -06:00
2023-08-29 08:09:09 -05:00
permissions := [ ] accesscontrol . Permission { { Action : dashboards . ActionDashboardsRead , Scope : "dashboards:uid:1" } }
res , err := getDashboard ( server , permissions )
require . NoError ( t , err )
2022-02-07 05:43:43 -06:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusOK , res . StatusCode )
var data dtos . DashboardFullWithMeta
require . NoError ( t , json . NewDecoder ( res . Body ) . Decode ( & data ) )
2022-05-17 13:52:22 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , data . Meta . CanSave , false )
assert . Equal ( t , data . Meta . CanEdit , false )
assert . Equal ( t , data . Meta . CanDelete , false )
assert . Equal ( t , data . Meta . CanAdmin , false )
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
require . NoError ( t , res . Body . Close ( ) )
} )
2019-04-30 06:32:18 -05:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should set CanSave and CanEdit with correct permissions" , func ( t * testing . T ) {
server := setup ( )
2018-01-30 07:09:30 -06:00
2023-08-29 08:09:09 -05:00
res , err := getDashboard ( server , [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsRead , Scope : "dashboards:uid:1" } ,
{ Action : dashboards . ActionDashboardsWrite , Scope : "dashboards:uid:1" } ,
2017-06-12 08:48:55 -05:00
} )
2023-08-29 08:09:09 -05:00
require . NoError ( t , err )
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusOK , res . StatusCode )
var data dtos . DashboardFullWithMeta
require . NoError ( t , json . NewDecoder ( res . Body ) . Decode ( & data ) )
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , data . Meta . CanSave , true )
assert . Equal ( t , data . Meta . CanEdit , true )
assert . Equal ( t , data . Meta . CanDelete , false )
assert . Equal ( t , data . Meta . CanAdmin , false )
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
require . NoError ( t , res . Body . Close ( ) )
} )
2022-06-01 13:16:26 -05:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should set canDelete with correct permissions" , func ( t * testing . T ) {
server := setup ( )
res , err := getDashboard ( server , [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsRead , Scope : "dashboards:uid:1" } ,
{ Action : dashboards . ActionDashboardsDelete , Scope : "dashboards:uid:1" } ,
} )
require . NoError ( t , err )
2022-02-07 05:43:43 -06:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusOK , res . StatusCode )
var data dtos . DashboardFullWithMeta
require . NoError ( t , json . NewDecoder ( res . Body ) . Decode ( & data ) )
2018-01-29 14:23:07 -06:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , data . Meta . CanSave , false )
assert . Equal ( t , data . Meta . CanEdit , false )
assert . Equal ( t , data . Meta . CanDelete , true )
assert . Equal ( t , data . Meta . CanAdmin , false )
2017-06-22 17:34:19 -05:00
2023-08-29 08:09:09 -05:00
require . NoError ( t , res . Body . Close ( ) )
} )
2022-02-07 05:43:43 -06:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should set canAdmin with correct permissions" , func ( t * testing . T ) {
server := setup ( )
2020-11-13 02:52:38 -06:00
2023-08-29 08:09:09 -05:00
res , err := getDashboard ( server , [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsRead , Scope : "dashboards:uid:1" } ,
{ Action : dashboards . ActionDashboardsPermissionsRead , Scope : "dashboards:uid:1" } ,
{ Action : dashboards . ActionDashboardsPermissionsWrite , Scope : "dashboards:uid:1" } ,
2017-06-22 17:34:19 -05:00
} )
2023-08-29 08:09:09 -05:00
require . NoError ( t , err )
2017-06-22 17:34:19 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusOK , res . StatusCode )
var data dtos . DashboardFullWithMeta
require . NoError ( t , json . NewDecoder ( res . Body ) . Decode ( & data ) )
2022-06-01 13:16:26 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , data . Meta . CanSave , false )
assert . Equal ( t , data . Meta . CanEdit , false )
assert . Equal ( t , data . Meta . CanDelete , false )
assert . Equal ( t , data . Meta . CanAdmin , true )
2022-02-07 05:43:43 -06:00
2023-08-29 08:09:09 -05:00
require . NoError ( t , res . Body . Close ( ) )
} )
}
2017-12-15 07:19:49 -06:00
2023-08-29 08:09:09 -05:00
func TestHTTPServer_DeleteDashboardByUID_AccessControl ( t * testing . T ) {
setup := func ( ) * webtest . Server {
return SetupAPITestServer ( t , func ( hs * HTTPServer ) {
dash := dashboards . NewDashboard ( "some dash" )
dash . ID = 1
dash . UID = "1"
2018-01-29 14:23:07 -06:00
2023-08-29 08:09:09 -05:00
dashSvc := dashboards . NewFakeDashboardService ( t )
dashSvc . On ( "GetDashboard" , mock . Anything , mock . Anything ) . Return ( dash , nil ) . Maybe ( )
dashSvc . On ( "DeleteDashboard" , mock . Anything , mock . Anything , mock . Anything ) . Return ( nil ) . Maybe ( )
hs . DashboardService = dashSvc
2017-12-15 07:19:49 -06:00
2023-08-29 08:09:09 -05:00
hs . Cfg = setting . NewCfg ( )
hs . AccessControl = acimpl . ProvideAccessControl ( hs . Cfg )
hs . starService = startest . NewStarServiceFake ( )
2018-01-31 09:46:31 -06:00
2023-08-29 08:09:09 -05:00
hs . LibraryPanelService = & mockLibraryPanelService { }
hs . LibraryElementService = & mockLibraryElementService { }
2017-12-15 07:19:49 -06:00
2023-08-29 08:09:09 -05:00
pubDashService := publicdashboards . NewFakePublicDashboardService ( t )
pubDashService . On ( "DeleteByDashboard" , mock . Anything , mock . Anything ) . Return ( nil ) . Maybe ( )
2023-11-21 14:56:36 -06:00
middleware := publicdashboards . NewFakePublicDashboardMiddleware ( t )
2023-12-19 04:43:54 -06:00
hs . PublicDashboardsApi = api . ProvideApi ( pubDashService , nil , hs . AccessControl , featuremgmt . WithFeatures ( ) , middleware , hs . Cfg )
2017-06-22 17:34:19 -05:00
2023-08-29 08:09:09 -05:00
guardian . InitAccessControlGuardian ( hs . Cfg , hs . AccessControl , hs . DashboardService )
} )
}
deleteDashboard := func ( server * webtest . Server , permissions [ ] accesscontrol . Permission ) ( * http . Response , error ) {
return server . Send ( webtest . RequestWithSignedInUser ( server . NewRequest ( http . MethodDelete , "/api/dashboards/uid/1" , nil ) , userWithPermissions ( 1 , permissions ) ) )
}
2020-11-13 02:52:38 -06:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should not be able to delete dashboard without correct permission" , func ( t * testing . T ) {
server := setup ( )
res , err := deleteDashboard ( server , [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsDelete , Scope : "dashboards:uid:2" } ,
} )
require . NoError ( t , err )
2017-06-22 17:34:19 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusForbidden , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
} )
2018-01-29 14:23:07 -06:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should be able to delete dashboard with correct permission" , func ( t * testing . T ) {
server := setup ( )
res , err := deleteDashboard ( server , [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsDelete , Scope : "dashboards:uid:1" } ,
} )
require . NoError ( t , err )
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
assert . Equal ( t , http . StatusOK , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
} )
}
2018-01-29 14:23:07 -06:00
2023-08-29 08:09:09 -05:00
func TestHTTPServer_GetDashboardVersions_AccessControl ( t * testing . T ) {
setup := func ( ) * webtest . Server {
return SetupAPITestServer ( t , func ( hs * HTTPServer ) {
dash := dashboards . NewDashboard ( "some dash" )
dash . ID = 1
dash . UID = "1"
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
dashSvc := dashboards . NewFakeDashboardService ( t )
dashSvc . On ( "GetDashboard" , mock . Anything , mock . Anything ) . Return ( dash , nil ) . Maybe ( )
dashSvc . On ( "DeleteDashboard" , mock . Anything , mock . Anything , mock . Anything ) . Return ( nil ) . Maybe ( )
hs . DashboardService = dashSvc
2018-01-31 09:46:31 -06:00
2023-08-29 08:09:09 -05:00
hs . Cfg = setting . NewCfg ( )
hs . AccessControl = acimpl . ProvideAccessControl ( hs . Cfg )
hs . starService = startest . NewStarServiceFake ( )
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
hs . dashboardVersionService = & dashvertest . FakeDashboardVersionService {
ExpectedListDashboarVersions : [ ] * dashver . DashboardVersionDTO { } ,
ExpectedDashboardVersion : & dashver . DashboardVersionDTO { } ,
}
2017-06-13 17:28:34 -05:00
2023-08-29 08:09:09 -05:00
guardian . InitAccessControlGuardian ( hs . Cfg , hs . AccessControl , hs . DashboardService )
2017-06-12 08:48:55 -05:00
} )
2023-08-29 08:09:09 -05:00
}
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
getVersion := func ( server * webtest . Server , permissions [ ] accesscontrol . Permission ) ( * http . Response , error ) {
return server . Send ( webtest . RequestWithSignedInUser ( server . NewGetRequest ( "/api/dashboards/uid/1/versions/1" ) , userWithPermissions ( 1 , permissions ) ) )
}
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
getVersions := func ( server * webtest . Server , permissions [ ] accesscontrol . Permission ) ( * http . Response , error ) {
return server . Send ( webtest . RequestWithSignedInUser ( server . NewGetRequest ( "/api/dashboards/uid/1/versions" ) , userWithPermissions ( 1 , permissions ) ) )
}
2017-06-12 08:48:55 -05:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should not be able to list dashboard versions without correct permission" , func ( t * testing . T ) {
server := setup ( )
2022-02-07 05:43:43 -06:00
2023-08-29 08:09:09 -05:00
res , err := getVersions ( server , [ ] accesscontrol . Permission { } )
require . NoError ( t , err )
assert . Equal ( t , http . StatusForbidden , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
res , err = getVersion ( server , [ ] accesscontrol . Permission { } )
require . NoError ( t , err )
assert . Equal ( t , http . StatusForbidden , res . StatusCode )
2018-01-31 09:46:31 -06:00
2023-08-29 08:09:09 -05:00
require . NoError ( t , res . Body . Close ( ) )
} )
2017-06-12 16:05:32 -05:00
2023-08-29 08:09:09 -05:00
t . Run ( "Should be able to list dashboard versions with correct permission" , func ( t * testing . T ) {
server := setup ( )
2020-11-13 02:52:38 -06:00
2023-08-29 08:09:09 -05:00
permissions := [ ] accesscontrol . Permission {
{ Action : dashboards . ActionDashboardsRead , Scope : "dashboards:uid:1" } ,
{ Action : dashboards . ActionDashboardsWrite , Scope : "dashboards:uid:1" } ,
}
2017-06-13 17:28:34 -05:00
2023-08-29 08:09:09 -05:00
res , err := getVersions ( server , permissions )
require . NoError ( t , err )
assert . Equal ( t , http . StatusOK , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
2020-11-13 02:52:38 -06:00
2023-08-29 08:09:09 -05:00
res , err = getVersion ( server , permissions )
require . NoError ( t , err )
assert . Equal ( t , http . StatusOK , res . StatusCode )
require . NoError ( t , res . Body . Close ( ) )
2017-06-12 08:48:55 -05:00
} )
2023-08-29 08:09:09 -05:00
}
2018-01-31 09:51:06 -06:00
2023-08-29 08:09:09 -05:00
func TestDashboardAPIEndpoint ( t * testing . T ) {
2020-11-13 02:52:38 -06:00
t . Run ( "Given two dashboards with the same title in different folders" , func ( t * testing . T ) {
2023-01-18 06:52:41 -06:00
dashOne := dashboards . NewDashboard ( "dash" )
dashOne . ID = 2
2023-12-20 08:12:05 -06:00
dashOne . FolderUID = "folderUID"
2022-07-18 08:14:58 -05:00
dashOne . HasACL = false
2018-01-31 09:51:06 -06:00
2023-01-18 06:52:41 -06:00
dashTwo := dashboards . NewDashboard ( "dash" )
dashTwo . ID = 4
2023-12-20 08:12:05 -06:00
dashTwo . FolderUID = "folderUID2"
2022-07-18 08:14:58 -05:00
dashTwo . HasACL = false
2018-01-31 09:51:06 -06:00
} )
2018-02-19 04:12:56 -06:00
2020-11-13 02:52:38 -06:00
t . Run ( "Post dashboard response tests" , func ( t * testing . T ) {
2022-03-10 11:19:50 -06:00
dashboardStore := & dashboards . FakeDashboardStore { }
2022-02-16 07:15:44 -06:00
defer dashboardStore . AssertExpectations ( t )
2018-02-19 04:12:56 -06:00
// This tests that a valid request returns correct response
2020-11-13 02:52:38 -06:00
t . Run ( "Given a correct request for creating a dashboard" , func ( t * testing . T ) {
2023-10-24 02:04:45 -05:00
folderUID := "Folder"
2020-11-13 02:52:38 -06:00
const dashID int64 = 2
2018-02-19 04:12:56 -06:00
2023-01-18 06:52:41 -06:00
cmd := dashboards . SaveDashboardCommand {
OrgID : 1 ,
UserID : 5 ,
2023-08-30 10:46:47 -05:00
Dashboard : simplejson . NewFromAny ( map [ string ] any {
2018-02-19 04:12:56 -06:00
"title" : "Dash" ,
} ) ,
Overwrite : true ,
2023-10-24 02:04:45 -05:00
FolderUID : folderUID ,
2018-02-19 04:12:56 -06:00
IsFolder : false ,
Message : "msg" ,
}
2022-05-23 10:14:27 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
dashboardService . On ( "SaveDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.SaveDashboardDTO" ) , mock . AnythingOfType ( "bool" ) ) .
2023-12-20 08:12:05 -06:00
Return ( & dashboards . Dashboard { ID : dashID , UID : "uid" , Title : "Dash" , Slug : "dash" , Version : 2 , FolderUID : folderUID } , nil )
2023-10-24 02:04:45 -05:00
mockFolderService := & foldertest . FakeService {
2023-12-20 08:12:05 -06:00
ExpectedFolder : & folder . Folder { UID : folderUID , Title : "Folder" } ,
2023-10-24 02:04:45 -05:00
}
2018-02-19 04:12:56 -06:00
2023-10-24 02:04:45 -05:00
postDashboardScenario ( t , "When calling POST on" , "/api/dashboards" , "/api/dashboards" , cmd , dashboardService , mockFolderService , func ( sc * scenarioContext ) {
2020-11-13 02:52:38 -06:00
callPostDashboardShouldReturnSuccess ( sc )
2018-02-19 04:12:56 -06:00
2020-11-13 02:52:38 -06:00
result := sc . ToJSON ( )
assert . Equal ( t , "success" , result . Get ( "status" ) . MustString ( ) )
assert . Equal ( t , dashID , result . Get ( "id" ) . MustInt64 ( ) )
assert . Equal ( t , "uid" , result . Get ( "uid" ) . MustString ( ) )
assert . Equal ( t , "dash" , result . Get ( "slug" ) . MustString ( ) )
assert . Equal ( t , "/d/uid/dash" , result . Get ( "url" ) . MustString ( ) )
2018-02-19 04:12:56 -06:00
} )
} )
2021-05-26 09:20:13 -05:00
t . Run ( "Given a correct request for creating a dashboard with folder uid" , func ( t * testing . T ) {
const folderUid string = "folderUID"
const dashID int64 = 2
2023-01-18 06:52:41 -06:00
cmd := dashboards . SaveDashboardCommand {
OrgID : 1 ,
UserID : 5 ,
2023-08-30 10:46:47 -05:00
Dashboard : simplejson . NewFromAny ( map [ string ] any {
2021-05-26 09:20:13 -05:00
"title" : "Dash" ,
} ) ,
Overwrite : true ,
2023-01-18 06:52:41 -06:00
FolderUID : folderUid ,
2021-05-26 09:20:13 -05:00
IsFolder : false ,
Message : "msg" ,
}
2022-05-23 10:14:27 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
dashboardService . On ( "SaveDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.SaveDashboardDTO" ) , mock . AnythingOfType ( "bool" ) ) .
2023-01-16 09:33:55 -06:00
Return ( & dashboards . Dashboard { ID : dashID , UID : "uid" , Title : "Dash" , Slug : "dash" , Version : 2 } , nil )
2021-05-26 09:20:13 -05:00
2022-11-11 07:28:24 -06:00
mockFolder := & foldertest . FakeService {
2023-12-20 08:12:05 -06:00
ExpectedFolder : & folder . Folder { UID : "folderUID" , Title : "Folder" } ,
2021-05-26 09:20:13 -05:00
}
2022-05-23 10:14:27 -05:00
postDashboardScenario ( t , "When calling POST on" , "/api/dashboards" , "/api/dashboards" , cmd , dashboardService , mockFolder , func ( sc * scenarioContext ) {
2021-05-26 09:20:13 -05:00
callPostDashboardShouldReturnSuccess ( sc )
result := sc . ToJSON ( )
assert . Equal ( t , "success" , result . Get ( "status" ) . MustString ( ) )
assert . Equal ( t , dashID , result . Get ( "id" ) . MustInt64 ( ) )
assert . Equal ( t , "uid" , result . Get ( "uid" ) . MustString ( ) )
assert . Equal ( t , "dash" , result . Get ( "slug" ) . MustString ( ) )
assert . Equal ( t , "/d/uid/dash" , result . Get ( "url" ) . MustString ( ) )
} )
} )
2018-02-19 04:12:56 -06:00
// This tests that invalid requests returns expected error responses
2020-11-13 02:52:38 -06:00
t . Run ( "Given incorrect requests for creating a dashboard" , func ( t * testing . T ) {
2018-02-19 04:12:56 -06:00
testCases := [ ] struct {
SaveError error
ExpectedStatusCode int
} {
2023-08-30 09:51:18 -05:00
{ SaveError : dashboards . ErrDashboardNotFound , ExpectedStatusCode : http . StatusNotFound } ,
{ SaveError : dashboards . ErrFolderNotFound , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardWithSameUIDExists , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardWithSameNameInFolderExists , ExpectedStatusCode : http . StatusPreconditionFailed } ,
{ SaveError : dashboards . ErrDashboardVersionMismatch , ExpectedStatusCode : http . StatusPreconditionFailed } ,
{ SaveError : dashboards . ErrDashboardTitleEmpty , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardFolderCannotHaveParent , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : alerting . ValidationError { Reason : "Mu" } , ExpectedStatusCode : http . StatusUnprocessableEntity } ,
{ SaveError : dashboards . ErrDashboardTypeMismatch , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardFolderWithSameNameAsDashboard , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardWithSameNameAsFolder , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardFolderNameExists , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardUpdateAccessDenied , ExpectedStatusCode : http . StatusForbidden } ,
{ SaveError : dashboards . ErrDashboardInvalidUid , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardUidTooLong , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . ErrDashboardCannotSaveProvisionedDashboard , ExpectedStatusCode : http . StatusBadRequest } ,
{ SaveError : dashboards . UpdatePluginDashboardError { PluginId : "plug" } , ExpectedStatusCode : http . StatusPreconditionFailed } ,
2018-02-19 04:12:56 -06:00
}
2023-01-18 06:52:41 -06:00
cmd := dashboards . SaveDashboardCommand {
OrgID : 1 ,
2023-08-30 10:46:47 -05:00
Dashboard : simplejson . NewFromAny ( map [ string ] any {
2018-02-19 04:12:56 -06:00
"title" : "" ,
} ) ,
}
for _ , tc := range testCases {
2022-05-23 10:14:27 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
dashboardService . On ( "SaveDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.SaveDashboardDTO" ) , mock . AnythingOfType ( "bool" ) ) . Return ( nil , tc . SaveError )
2018-02-19 04:12:56 -06:00
2020-11-13 02:52:38 -06:00
postDashboardScenario ( t , fmt . Sprintf ( "Expect '%s' error when calling POST on" , tc . SaveError . Error ( ) ) ,
2022-05-23 10:14:27 -05:00
"/api/dashboards" , "/api/dashboards" , cmd , dashboardService , nil , func ( sc * scenarioContext ) {
2020-11-13 02:52:38 -06:00
callPostDashboard ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , tc . ExpectedStatusCode , sc . resp . Code , sc . resp . Body . String ( ) )
2020-11-13 02:52:38 -06:00
} )
2018-02-19 04:12:56 -06:00
}
} )
} )
2018-02-27 10:53:30 -06:00
2020-11-13 02:52:38 -06:00
t . Run ( "Given two dashboards being compared" , func ( t * testing . T ) {
2022-05-25 03:41:51 -05:00
fakeDashboardVersionService := dashvertest . NewDashboardVersionServiceFake ( )
2022-12-27 10:17:24 -06:00
fakeDashboardVersionService . ExpectedDashboardVersions = [ ] * dashver . DashboardVersionDTO {
2022-05-25 03:41:51 -05:00
{
DashboardID : 1 ,
Version : 1 ,
2023-08-30 10:46:47 -05:00
Data : simplejson . NewFromAny ( map [ string ] any {
2022-05-25 03:41:51 -05:00
"title" : "Dash1" ,
} ) ,
} ,
{
DashboardID : 2 ,
Version : 2 ,
2023-08-30 10:46:47 -05:00
Data : simplejson . NewFromAny ( map [ string ] any {
2022-05-25 03:41:51 -05:00
"title" : "Dash2" ,
} ) ,
} ,
}
2023-01-17 07:17:54 -06:00
sqlmock := dbtest . NewFakeDB ( )
2018-02-27 10:53:30 -06:00
cmd := dtos . CalculateDiffOptions {
Base : dtos . CalculateDiffTarget {
DashboardId : 1 ,
Version : 1 ,
} ,
New : dtos . CalculateDiffTarget {
DashboardId : 2 ,
Version : 2 ,
} ,
DiffType : "basic" ,
}
2020-11-13 02:52:38 -06:00
t . Run ( "when user does not have permission" , func ( t * testing . T ) {
2022-08-10 04:56:48 -05:00
role := org . RoleViewer
2020-11-13 02:52:38 -06:00
postDiffScenario ( t , "When calling POST on" , "/api/dashboards/calculate-diff" , "/api/dashboards/calculate-diff" , cmd , role , func ( sc * scenarioContext ) {
2023-08-29 08:09:09 -05:00
guardian . MockDashboardGuardian ( & guardian . FakeDashboardGuardian { CanSaveValue : false } )
2020-11-13 02:52:38 -06:00
callPostDashboard ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusForbidden , sc . resp . Code )
2023-01-17 07:17:54 -06:00
} , sqlmock , fakeDashboardVersionService )
2018-02-27 10:53:30 -06:00
} )
2020-11-13 02:52:38 -06:00
t . Run ( "when user does have permission" , func ( t * testing . T ) {
2022-08-10 04:56:48 -05:00
role := org . RoleAdmin
2020-11-13 02:52:38 -06:00
postDiffScenario ( t , "When calling POST on" , "/api/dashboards/calculate-diff" , "/api/dashboards/calculate-diff" , cmd , role , func ( sc * scenarioContext ) {
2023-08-29 08:09:09 -05:00
guardian . MockDashboardGuardian ( & guardian . FakeDashboardGuardian { CanSaveValue : true } )
2022-07-18 08:14:58 -05:00
// This test shouldn't hit GetDashboardACLInfoList, so no setup needed
2022-05-25 03:41:51 -05:00
sc . dashboardVersionService = fakeDashboardVersionService
2020-11-13 02:52:38 -06:00
callPostDashboard ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2023-01-17 07:17:54 -06:00
} , sqlmock , fakeDashboardVersionService )
2018-02-27 10:53:30 -06:00
} )
} )
2019-03-06 07:38:40 -06:00
2020-11-13 02:52:38 -06:00
t . Run ( "Given dashboard in folder being restored should restore to folder" , func ( t * testing . T ) {
2023-01-16 09:33:55 -06:00
fakeDash := dashboards . NewDashboard ( "Child dash" )
fakeDash . ID = 2
2022-07-18 08:14:58 -05:00
fakeDash . HasACL = false
2019-03-06 07:38:40 -06:00
2022-05-23 10:14:27 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
2023-01-25 03:36:26 -06:00
dashboardService . On ( "GetDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.GetDashboardQuery" ) ) . Return ( fakeDash , nil )
2022-05-23 10:14:27 -05:00
dashboardService . On ( "SaveDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.SaveDashboardDTO" ) , mock . AnythingOfType ( "bool" ) ) . Run ( func ( args mock . Arguments ) {
cmd := args . Get ( 1 ) . ( * dashboards . SaveDashboardDTO )
2023-01-16 09:33:55 -06:00
cmd . Dashboard = & dashboards . Dashboard {
ID : 2 , UID : "uid" , Title : "Dash" , Slug : "dash" , Version : 1 ,
2022-05-23 10:14:27 -05:00
}
} ) . Return ( nil , nil )
2019-03-06 07:38:40 -06:00
cmd := dtos . RestoreDashboardVersionCommand {
Version : 1 ,
}
2022-05-25 03:41:51 -05:00
fakeDashboardVersionService := dashvertest . NewDashboardVersionServiceFake ( )
2022-12-27 10:17:24 -06:00
fakeDashboardVersionService . ExpectedDashboardVersions = [ ] * dashver . DashboardVersionDTO {
2022-02-10 02:58:52 -06:00
{
2022-05-25 03:41:51 -05:00
DashboardID : 2 ,
2022-02-10 02:58:52 -06:00
Version : 1 ,
Data : fakeDash . Data ,
} }
2023-01-18 09:01:25 -06:00
mockSQLStore := dbtest . NewFakeDB ( )
2023-10-24 02:04:45 -05:00
origNewGuardian := guardian . New
guardian . MockDashboardGuardian ( & guardian . FakeDashboardGuardian { CanSaveValue : true } )
t . Cleanup ( func ( ) {
guardian . New = origNewGuardian
} )
2020-11-13 02:52:38 -06:00
restoreDashboardVersionScenario ( t , "When calling POST on" , "/api/dashboards/id/1/restore" ,
2022-05-25 03:41:51 -05:00
"/api/dashboards/id/:dashboardId/restore" , dashboardService , fakeDashboardVersionService , cmd , func ( sc * scenarioContext ) {
sc . dashboardVersionService = fakeDashboardVersionService
2020-11-13 02:52:38 -06:00
callRestoreDashboardVersion ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2022-02-07 05:43:43 -06:00
} , mockSQLStore )
2019-03-06 07:38:40 -06:00
} )
2020-11-13 02:52:38 -06:00
t . Run ( "Given dashboard in general folder being restored should restore to general folder" , func ( t * testing . T ) {
2023-01-16 09:33:55 -06:00
fakeDash := dashboards . NewDashboard ( "Child dash" )
fakeDash . ID = 2
2022-07-18 08:14:58 -05:00
fakeDash . HasACL = false
2019-03-06 07:38:40 -06:00
2022-05-23 10:14:27 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
2023-01-25 03:36:26 -06:00
dashboardService . On ( "GetDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.GetDashboardQuery" ) ) . Return ( fakeDash , nil )
2022-05-23 10:14:27 -05:00
dashboardService . On ( "SaveDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.SaveDashboardDTO" ) , mock . AnythingOfType ( "bool" ) ) . Run ( func ( args mock . Arguments ) {
cmd := args . Get ( 1 ) . ( * dashboards . SaveDashboardDTO )
2023-01-16 09:33:55 -06:00
cmd . Dashboard = & dashboards . Dashboard {
ID : 2 , UID : "uid" , Title : "Dash" , Slug : "dash" , Version : 1 ,
2022-05-23 10:14:27 -05:00
}
} ) . Return ( nil , nil )
2019-03-06 07:38:40 -06:00
2022-05-25 03:41:51 -05:00
fakeDashboardVersionService := dashvertest . NewDashboardVersionServiceFake ( )
2022-12-27 10:17:24 -06:00
fakeDashboardVersionService . ExpectedDashboardVersions = [ ] * dashver . DashboardVersionDTO {
2022-05-25 03:41:51 -05:00
{
DashboardID : 2 ,
Version : 1 ,
Data : fakeDash . Data ,
} }
2019-03-06 07:38:40 -06:00
cmd := dtos . RestoreDashboardVersionCommand {
Version : 1 ,
}
2023-01-18 09:01:25 -06:00
mockSQLStore := dbtest . NewFakeDB ( )
2020-11-13 02:52:38 -06:00
restoreDashboardVersionScenario ( t , "When calling POST on" , "/api/dashboards/id/1/restore" ,
2022-05-25 03:41:51 -05:00
"/api/dashboards/id/:dashboardId/restore" , dashboardService , fakeDashboardVersionService , cmd , func ( sc * scenarioContext ) {
2020-11-13 02:52:38 -06:00
callRestoreDashboardVersion ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2022-02-07 05:43:43 -06:00
} , mockSQLStore )
2019-03-06 07:38:40 -06:00
} )
2019-04-10 06:29:10 -05:00
2020-11-13 02:52:38 -06:00
t . Run ( "Given provisioned dashboard" , func ( t * testing . T ) {
2023-01-18 09:01:25 -06:00
mockSQLStore := dbtest . NewFakeDB ( )
2022-06-01 13:16:26 -05:00
dashboardStore := dashboards . NewFakeDashboardStore ( t )
2023-01-18 06:52:41 -06:00
dashboardStore . On ( "GetProvisionedDataByDashboardID" , mock . Anything , mock . AnythingOfType ( "int64" ) ) . Return ( & dashboards . DashboardProvisioning { ExternalID : "/dashboard1.json" } , nil ) . Once ( )
2022-06-01 13:16:26 -05:00
dashboardService := dashboards . NewFakeDashboardService ( t )
2022-02-16 07:15:44 -06:00
2022-02-07 05:43:43 -06:00
dataValue , err := simplejson . NewJson ( [ ] byte ( ` { "id": 1, "editable": true, "style": "dark"} ` ) )
require . NoError ( t , err )
2023-01-25 03:36:26 -06:00
qResult := & dashboards . Dashboard { ID : 1 , Data : dataValue }
dashboardService . On ( "GetDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.GetDashboardQuery" ) ) . Return ( qResult , nil )
2023-08-29 08:09:09 -05:00
guardian . MockDashboardGuardian ( & guardian . FakeDashboardGuardian { CanViewValue : true } )
2019-04-30 06:32:18 -05:00
2022-08-10 04:56:48 -05:00
loggedInUserScenarioWithRole ( t , "When calling GET on" , "GET" , "/api/dashboards/uid/dash" , "/api/dashboards/uid/:uid" , org . RoleEditor , func ( sc * scenarioContext ) {
2022-02-16 07:15:44 -06:00
fakeProvisioningService := provisioning . NewProvisioningServiceMock ( context . Background ( ) )
fakeProvisioningService . GetDashboardProvisionerResolvedPathFunc = func ( name string ) string {
2019-04-30 06:32:18 -05:00
return "/tmp/grafana/dashboards"
}
2023-01-19 10:38:07 -06:00
dash := getDashboardShouldReturn200WithConfig ( t , sc , fakeProvisioningService , dashboardStore , dashboardService , nil )
2022-02-16 07:15:44 -06:00
assert . Equal ( t , "../../../dashboard1.json" , dash . Meta . ProvisionedExternalId , mockSQLStore )
2022-02-07 05:43:43 -06:00
} , mockSQLStore )
2019-10-31 08:27:31 -05:00
2022-08-10 04:56:48 -05:00
loggedInUserScenarioWithRole ( t , "When allowUiUpdates is true and calling GET on" , "GET" , "/api/dashboards/uid/dash" , "/api/dashboards/uid/:uid" , org . RoleEditor , func ( sc * scenarioContext ) {
2022-02-16 07:15:44 -06:00
fakeProvisioningService := provisioning . NewProvisioningServiceMock ( context . Background ( ) )
fakeProvisioningService . GetDashboardProvisionerResolvedPathFunc = func ( name string ) string {
2019-10-31 08:27:31 -05:00
return "/tmp/grafana/dashboards"
}
2022-02-16 07:15:44 -06:00
fakeProvisioningService . GetAllowUIUpdatesFromConfigFunc = func ( name string ) bool {
2019-10-31 08:27:31 -05:00
return true
}
hs := & HTTPServer {
2022-02-16 07:15:44 -06:00
Cfg : setting . NewCfg ( ) ,
ProvisioningService : fakeProvisioningService ,
LibraryPanelService : & mockLibraryPanelService { } ,
LibraryElementService : & mockLibraryElementService { } ,
dashboardProvisioningService : mockDashboardProvisioningService { } ,
SQLStore : mockSQLStore ,
2022-04-04 09:57:43 -05:00
AccessControl : accesscontrolmock . New ( ) ,
2022-07-06 13:42:39 -05:00
DashboardService : dashboardService ,
2022-07-19 18:44:41 -05:00
Features : featuremgmt . WithFeatures ( ) ,
2023-08-09 01:54:52 -05:00
starService : startest . NewStarServiceFake ( ) ,
2019-10-31 08:27:31 -05:00
}
2022-02-07 05:43:43 -06:00
hs . callGetDashboard ( sc )
2019-10-31 08:27:31 -05:00
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2019-10-31 08:27:31 -05:00
dash := dtos . DashboardFullWithMeta { }
err := json . NewDecoder ( sc . resp . Body ) . Decode ( & dash )
2020-11-13 02:52:38 -06:00
require . NoError ( t , err )
2019-10-31 08:27:31 -05:00
2020-11-13 02:52:38 -06:00
assert . Equal ( t , false , dash . Meta . Provisioned )
2022-02-07 05:43:43 -06:00
} , mockSQLStore )
2019-04-10 06:29:10 -05:00
} )
2017-06-12 08:48:55 -05:00
}
2017-06-12 16:05:32 -05:00
2023-03-30 09:31:53 -05:00
func TestDashboardVersionsAPIEndpoint ( t * testing . T ) {
fakeDash := dashboards . NewDashboard ( "Child dash" )
fakeDashboardVersionService := dashvertest . NewDashboardVersionServiceFake ( )
dashboardService := dashboards . NewFakeDashboardService ( t )
dashboardService . On ( "GetDashboard" , mock . Anything , mock . AnythingOfType ( "*dashboards.GetDashboardQuery" ) ) . Return ( fakeDash , nil )
mockSQLStore := dbtest . NewFakeDB ( )
cfg := setting . NewCfg ( )
getHS := func ( userSvc * usertest . FakeUserService ) * HTTPServer {
return & HTTPServer {
Cfg : cfg ,
2023-09-11 06:59:24 -05:00
pluginStore : & pluginstore . FakePluginStore { } ,
2023-03-30 09:31:53 -05:00
SQLStore : mockSQLStore ,
AccessControl : accesscontrolmock . New ( ) ,
Features : featuremgmt . WithFeatures ( ) ,
DashboardService : dashboardService ,
dashboardVersionService : fakeDashboardVersionService ,
QuotaService : quotatest . New ( false , nil ) ,
userService : userSvc ,
CacheService : localcache . New ( 5 * time . Minute , 10 * time . Minute ) ,
log : log . New ( ) ,
}
}
setUp := func ( ) {
2023-08-29 08:09:09 -05:00
guardian . MockDashboardGuardian ( & guardian . FakeDashboardGuardian { CanSaveValue : true } )
2023-03-30 09:31:53 -05:00
}
loggedInUserScenarioWithRole ( t , "When user exists and calling GET on" , "GET" , "/api/dashboards/id/2/versions" ,
"/api/dashboards/id/:dashboardId/versions" , org . RoleEditor , func ( sc * scenarioContext ) {
setUp ( )
fakeDashboardVersionService . ExpectedListDashboarVersions = [ ] * dashver . DashboardVersionDTO {
{
Version : 1 ,
CreatedBy : 1 ,
} ,
{
Version : 2 ,
CreatedBy : 1 ,
} ,
}
getHS ( & usertest . FakeUserService {
ExpectedUser : & user . User { ID : 1 , Login : "test-user" } ,
} ) . callGetDashboardVersions ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2023-03-30 09:31:53 -05:00
var versions [ ] dashver . DashboardVersionMeta
err := json . NewDecoder ( sc . resp . Body ) . Decode ( & versions )
require . NoError ( t , err )
for _ , v := range versions {
assert . Equal ( t , "test-user" , v . CreatedBy )
}
} , mockSQLStore )
loggedInUserScenarioWithRole ( t , "When user does not exist and calling GET on" , "GET" , "/api/dashboards/id/2/versions" ,
"/api/dashboards/id/:dashboardId/versions" , org . RoleEditor , func ( sc * scenarioContext ) {
setUp ( )
fakeDashboardVersionService . ExpectedListDashboarVersions = [ ] * dashver . DashboardVersionDTO {
{
Version : 1 ,
CreatedBy : 1 ,
} ,
{
Version : 2 ,
CreatedBy : 1 ,
} ,
}
getHS ( & usertest . FakeUserService {
ExpectedError : user . ErrUserNotFound ,
} ) . callGetDashboardVersions ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2023-03-30 09:31:53 -05:00
var versions [ ] dashver . DashboardVersionMeta
err := json . NewDecoder ( sc . resp . Body ) . Decode ( & versions )
require . NoError ( t , err )
for _ , v := range versions {
assert . Equal ( t , anonString , v . CreatedBy )
}
} , mockSQLStore )
loggedInUserScenarioWithRole ( t , "When failing to get user and calling GET on" , "GET" , "/api/dashboards/id/2/versions" ,
"/api/dashboards/id/:dashboardId/versions" , org . RoleEditor , func ( sc * scenarioContext ) {
setUp ( )
fakeDashboardVersionService . ExpectedListDashboarVersions = [ ] * dashver . DashboardVersionDTO {
{
Version : 1 ,
CreatedBy : 1 ,
} ,
{
Version : 2 ,
CreatedBy : 1 ,
} ,
}
getHS ( & usertest . FakeUserService {
ExpectedError : fmt . Errorf ( "some error" ) ,
} ) . callGetDashboardVersions ( sc )
2023-08-30 09:51:18 -05:00
assert . Equal ( t , http . StatusOK , sc . resp . Code )
2023-03-30 09:31:53 -05:00
var versions [ ] dashver . DashboardVersionMeta
err := json . NewDecoder ( sc . resp . Body ) . Decode ( & versions )
require . NoError ( t , err )
for _ , v := range versions {
assert . Equal ( t , anonString , v . CreatedBy )
}
} , mockSQLStore )
}
2023-02-01 07:43:21 -06:00
func getDashboardShouldReturn200WithConfig ( t * testing . T , sc * scenarioContext , provisioningService provisioning . ProvisioningService , dashboardStore dashboards . Store , dashboardService dashboards . DashboardService , folderStore folder . FolderStore ) dtos . DashboardFullWithMeta {
2022-02-16 07:15:44 -06:00
t . Helper ( )
2019-04-30 06:32:18 -05:00
if provisioningService == nil {
2021-11-03 05:31:56 -05:00
provisioningService = provisioning . NewProvisioningServiceMock ( context . Background ( ) )
2019-04-30 06:32:18 -05:00
}
2023-11-13 09:55:15 -06:00
features := featuremgmt . WithFeatures ( )
2022-11-14 13:08:10 -06:00
var err error
2022-02-16 07:15:44 -06:00
if dashboardStore == nil {
2022-10-19 08:02:15 -05:00
sql := db . InitTestDB ( t )
2022-11-14 13:08:10 -06:00
quotaService := quotatest . New ( false , nil )
2023-11-13 09:55:15 -06:00
dashboardStore , err = database . ProvideDashboardStore ( sql , sql . Cfg , features , tagimpl . ProvideService ( sql ) , quotaService )
2022-11-14 13:08:10 -06:00
require . NoError ( t , err )
2022-02-16 07:15:44 -06:00
}
2021-05-12 01:48:17 -05:00
libraryPanelsService := mockLibraryPanelService { }
libraryElementsService := mockLibraryElementService { }
2022-03-10 05:58:18 -06:00
cfg := setting . NewCfg ( )
2022-06-07 04:02:20 -05:00
ac := accesscontrolmock . New ( )
folderPermissions := accesscontrolmock . NewMockedPermissionsService ( )
dashboardPermissions := accesscontrolmock . NewMockedPermissionsService ( )
2021-05-12 01:48:17 -05:00
2023-03-02 07:09:57 -06:00
folderSvc := folderimpl . ProvideService ( ac , bus . ProvideBus ( tracing . InitializeTracerForTest ( ) ) ,
2023-12-05 09:13:31 -06:00
cfg , dashboardStore , folderStore , db . InitTestDB ( t ) , features , nil )
2023-01-26 02:21:10 -06:00
2022-05-23 10:14:27 -05:00
if dashboardService == nil {
2023-04-14 04:17:23 -05:00
dashboardService , err = service . ProvideDashboardServiceImpl (
2023-03-03 09:56:33 -06:00
cfg , dashboardStore , folderStore , nil , features , folderPermissions , dashboardPermissions ,
2023-12-05 09:13:31 -06:00
ac , folderSvc , nil ,
2022-06-07 04:02:20 -05:00
)
2023-04-14 04:17:23 -05:00
require . NoError ( t , err )
2022-05-23 10:14:27 -05:00
}
2023-04-14 04:17:23 -05:00
dashboardProvisioningService , err := service . ProvideDashboardServiceImpl (
cfg , dashboardStore , folderStore , nil , features , folderPermissions , dashboardPermissions ,
2023-12-05 09:13:31 -06:00
ac , folderSvc , nil ,
2023-04-14 04:17:23 -05:00
)
require . NoError ( t , err )
2019-04-30 06:32:18 -05:00
hs := & HTTPServer {
2023-04-14 04:17:23 -05:00
Cfg : cfg ,
LibraryPanelService : & libraryPanelsService ,
LibraryElementService : & libraryElementsService ,
SQLStore : sc . sqlStore ,
ProvisioningService : provisioningService ,
AccessControl : accesscontrolmock . New ( ) ,
dashboardProvisioningService : dashboardProvisioningService ,
DashboardService : dashboardService ,
Features : featuremgmt . WithFeatures ( ) ,
2023-08-09 01:54:52 -05:00
starService : startest . NewStarServiceFake ( ) ,
2019-04-30 06:32:18 -05:00
}
2021-05-12 01:48:17 -05:00
2022-02-07 05:43:43 -06:00
hs . callGetDashboard ( sc )
2017-06-12 16:05:32 -05:00
2020-11-13 02:52:38 -06:00
require . Equal ( sc . t , 200 , sc . resp . Code )
2017-06-12 16:05:32 -05:00
dash := dtos . DashboardFullWithMeta { }
2022-11-14 13:08:10 -06:00
err = json . NewDecoder ( sc . resp . Body ) . Decode ( & dash )
2020-11-13 02:52:38 -06:00
require . NoError ( sc . t , err )
2017-06-12 16:05:32 -05:00
return dash
}
2022-02-07 05:43:43 -06:00
func ( hs * HTTPServer ) callGetDashboard ( sc * scenarioContext ) {
2019-04-30 06:32:18 -05:00
sc . handlerFunc = hs . GetDashboard
2018-01-29 06:51:01 -06:00
sc . fakeReqWithParams ( "GET" , sc . url , map [ string ] string { } ) . exec ( )
}
2022-02-07 05:43:43 -06:00
func ( hs * HTTPServer ) callGetDashboardVersions ( sc * scenarioContext ) {
sc . handlerFunc = hs . GetDashboardVersions
2017-06-13 17:28:34 -05:00
sc . fakeReqWithParams ( "GET" , sc . url , map [ string ] string { } ) . exec ( )
}
2020-11-13 02:52:38 -06:00
func callPostDashboard ( sc * scenarioContext ) {
2017-06-12 16:05:32 -05:00
sc . fakeReqWithParams ( "POST" , sc . url , map [ string ] string { } ) . exec ( )
}
2020-11-13 02:52:38 -06:00
func callRestoreDashboardVersion ( sc * scenarioContext ) {
2019-03-06 07:38:40 -06:00
sc . fakeReqWithParams ( "POST" , sc . url , map [ string ] string { } ) . exec ( )
}
2020-11-13 02:52:38 -06:00
func callPostDashboardShouldReturnSuccess ( sc * scenarioContext ) {
callPostDashboard ( sc )
2018-01-30 16:37:54 -06:00
2020-11-13 02:52:38 -06:00
assert . Equal ( sc . t , 200 , sc . resp . Code )
2018-01-30 16:37:54 -06:00
}
2023-01-18 06:52:41 -06:00
func postDashboardScenario ( t * testing . T , desc string , url string , routePattern string , cmd dashboards . SaveDashboardCommand , dashboardService dashboards . DashboardService , folderService folder . Service , fn scenarioFunc ) {
2020-11-13 02:52:38 -06:00
t . Run ( fmt . Sprintf ( "%s %s" , desc , url ) , func ( t * testing . T ) {
2020-12-15 12:09:04 -06:00
cfg := setting . NewCfg ( )
2019-02-11 14:12:01 -06:00
hs := HTTPServer {
2022-11-14 13:08:10 -06:00
Cfg : cfg ,
ProvisioningService : provisioning . NewProvisioningServiceMock ( context . Background ( ) ) ,
Live : newTestLive ( t , db . InitTestDB ( t ) ) ,
QuotaService : quotatest . New ( false , nil ) ,
2023-09-11 06:59:24 -05:00
pluginStore : & pluginstore . FakePluginStore { } ,
2021-05-12 01:48:17 -05:00
LibraryPanelService : & mockLibraryPanelService { } ,
LibraryElementService : & mockLibraryElementService { } ,
2022-07-06 13:42:39 -05:00
DashboardService : dashboardService ,
2022-02-16 07:15:44 -06:00
folderService : folderService ,
2022-03-03 08:05:47 -06:00
Features : featuremgmt . WithFeatures ( ) ,
2022-11-24 08:38:55 -06:00
accesscontrolService : actest . FakeService { } ,
2023-08-30 09:51:18 -05:00
log : log . New ( "test-logger" ) ,
2019-02-11 14:12:01 -06:00
}
2020-11-13 02:52:38 -06:00
sc := setupScenarioContext ( t , url )
2023-01-27 01:50:36 -06:00
sc . defaultHandler = routing . Wrap ( func ( c * contextmodel . ReqContext ) response . Response {
2021-11-29 03:18:01 -06:00
c . Req . Body = mockRequestBody ( cmd )
2022-02-09 06:44:38 -06:00
c . Req . Header . Add ( "Content-Type" , "application/json" )
2017-06-12 16:05:32 -05:00
sc . context = c
2023-01-18 06:52:41 -06:00
sc . context . SignedInUser = & user . SignedInUser { OrgID : cmd . OrgID , UserID : cmd . UserID }
2017-06-12 16:05:32 -05:00
2021-11-29 03:18:01 -06:00
return hs . PostDashboard ( c )
2017-06-12 16:05:32 -05:00
} )
sc . m . Post ( routePattern , sc . defaultHandler )
fn ( sc )
} )
}
2018-01-29 12:27:53 -06:00
2022-05-25 03:41:51 -05:00
func postDiffScenario ( t * testing . T , desc string , url string , routePattern string , cmd dtos . CalculateDiffOptions ,
2022-12-13 04:03:36 -06:00
role org . RoleType , fn scenarioFunc , sqlmock db . DB , fakeDashboardVersionService * dashvertest . FakeDashboardVersionService ) {
2020-11-13 02:52:38 -06:00
t . Run ( fmt . Sprintf ( "%s %s" , desc , url ) , func ( t * testing . T ) {
2022-02-10 02:58:52 -06:00
cfg := setting . NewCfg ( )
2022-12-15 08:34:17 -06:00
dashSvc := dashboards . NewFakeDashboardService ( t )
2022-02-10 02:58:52 -06:00
hs := HTTPServer {
2022-05-25 03:41:51 -05:00
Cfg : cfg ,
ProvisioningService : provisioning . NewProvisioningServiceMock ( context . Background ( ) ) ,
2022-10-19 08:02:15 -05:00
Live : newTestLive ( t , db . InitTestDB ( t ) ) ,
2022-11-14 13:08:10 -06:00
QuotaService : quotatest . New ( false , nil ) ,
2022-05-25 03:41:51 -05:00
LibraryPanelService : & mockLibraryPanelService { } ,
LibraryElementService : & mockLibraryElementService { } ,
SQLStore : sqlmock ,
dashboardVersionService : fakeDashboardVersionService ,
2022-07-19 18:44:41 -05:00
Features : featuremgmt . WithFeatures ( ) ,
2022-12-15 08:34:17 -06:00
DashboardService : dashSvc ,
2022-02-10 02:58:52 -06:00
}
2020-11-13 02:52:38 -06:00
sc := setupScenarioContext ( t , url )
2023-01-27 01:50:36 -06:00
sc . defaultHandler = routing . Wrap ( func ( c * contextmodel . ReqContext ) response . Response {
2021-11-29 03:18:01 -06:00
c . Req . Body = mockRequestBody ( cmd )
2022-02-09 06:44:38 -06:00
c . Req . Header . Add ( "Content-Type" , "application/json" )
2018-02-27 10:53:30 -06:00
sc . context = c
2022-08-10 04:56:48 -05:00
sc . context . SignedInUser = & user . SignedInUser {
2022-08-11 06:28:55 -05:00
OrgID : testOrgID ,
UserID : testUserID ,
2018-02-27 10:53:30 -06:00
}
sc . context . OrgRole = role
2022-02-10 02:58:52 -06:00
return hs . CalculateDashboardDiff ( c )
2018-02-27 10:53:30 -06:00
} )
sc . m . Post ( routePattern , sc . defaultHandler )
fn ( sc )
} )
}
2022-05-25 03:41:51 -05:00
func restoreDashboardVersionScenario ( t * testing . T , desc string , url string , routePattern string ,
mock * dashboards . FakeDashboardService , fakeDashboardVersionService * dashvertest . FakeDashboardVersionService ,
2022-12-13 04:03:36 -06:00
cmd dtos . RestoreDashboardVersionCommand , fn scenarioFunc , sqlStore db . DB ) {
2020-11-13 02:52:38 -06:00
t . Run ( fmt . Sprintf ( "%s %s" , desc , url ) , func ( t * testing . T ) {
2020-12-15 12:09:04 -06:00
cfg := setting . NewCfg ( )
2023-10-24 02:04:45 -05:00
folderSvc := foldertest . NewFakeService ( )
folderSvc . ExpectedFolder = & folder . Folder { }
2019-03-06 07:38:40 -06:00
hs := HTTPServer {
2022-05-25 03:41:51 -05:00
Cfg : cfg ,
ProvisioningService : provisioning . NewProvisioningServiceMock ( context . Background ( ) ) ,
2022-10-19 08:02:15 -05:00
Live : newTestLive ( t , db . InitTestDB ( t ) ) ,
2022-11-14 13:08:10 -06:00
QuotaService : quotatest . New ( false , nil ) ,
2022-05-25 03:41:51 -05:00
LibraryPanelService : & mockLibraryPanelService { } ,
LibraryElementService : & mockLibraryElementService { } ,
2022-07-06 13:42:39 -05:00
DashboardService : mock ,
2022-05-25 03:41:51 -05:00
SQLStore : sqlStore ,
Features : featuremgmt . WithFeatures ( ) ,
dashboardVersionService : fakeDashboardVersionService ,
2022-11-24 08:38:55 -06:00
accesscontrolService : actest . FakeService { } ,
2023-10-24 02:04:45 -05:00
folderService : folderSvc ,
2019-03-06 07:38:40 -06:00
}
2020-11-13 02:52:38 -06:00
sc := setupScenarioContext ( t , url )
2022-05-17 11:57:27 -05:00
sc . sqlStore = sqlStore
2022-05-25 03:41:51 -05:00
sc . dashboardVersionService = fakeDashboardVersionService
2023-01-27 01:50:36 -06:00
sc . defaultHandler = routing . Wrap ( func ( c * contextmodel . ReqContext ) response . Response {
2021-11-29 03:18:01 -06:00
c . Req . Body = mockRequestBody ( cmd )
2022-02-09 06:44:38 -06:00
c . Req . Header . Add ( "Content-Type" , "application/json" )
2019-03-06 07:38:40 -06:00
sc . context = c
2022-08-10 04:56:48 -05:00
sc . context . SignedInUser = & user . SignedInUser {
2022-08-11 06:28:55 -05:00
OrgID : testOrgID ,
UserID : testUserID ,
2019-03-06 07:38:40 -06:00
}
2022-08-10 04:56:48 -05:00
sc . context . OrgRole = org . RoleAdmin
2019-03-06 07:38:40 -06:00
2021-11-29 03:18:01 -06:00
return hs . RestoreDashboardVersion ( c )
2019-03-06 07:38:40 -06:00
} )
sc . m . Post ( routePattern , sc . defaultHandler )
fn ( sc )
} )
}
2018-03-22 16:13:46 -05:00
func ( sc * scenarioContext ) ToJSON ( ) * simplejson . Json {
2022-04-12 02:30:34 -05:00
result := simplejson . New ( )
err := json . NewDecoder ( sc . resp . Body ) . Decode ( result )
2020-11-13 02:52:38 -06:00
require . NoError ( sc . t , err )
2018-01-29 12:27:53 -06:00
return result
}
2019-10-31 08:27:31 -05:00
type mockDashboardProvisioningService struct {
2021-03-12 04:51:02 -06:00
dashboards . DashboardProvisioningService
2019-10-31 08:27:31 -05:00
}
2022-09-21 07:04:01 -05:00
func ( s mockDashboardProvisioningService ) GetProvisionedDashboardDataByDashboardID ( ctx context . Context , dashboardID int64 ) (
2023-01-18 06:52:41 -06:00
* dashboards . DashboardProvisioning , error ) {
2021-03-17 10:06:10 -05:00
return nil , nil
2019-10-31 08:27:31 -05:00
}
2021-05-12 01:48:17 -05:00
type mockLibraryPanelService struct {
}
2023-09-06 04:16:10 -05:00
var _ librarypanels . Service = ( * mockLibraryPanelService ) ( nil )
func ( m * mockLibraryPanelService ) ConnectLibraryPanelsForDashboard ( c context . Context , signedInUser identity . Requester , dash * dashboards . Dashboard ) error {
2021-05-12 01:48:17 -05:00
return nil
}
2023-09-06 04:16:10 -05:00
func ( m * mockLibraryPanelService ) ImportLibraryPanelsForDashboard ( c context . Context , signedInUser identity . Requester , libraryPanels * simplejson . Json , panels [ ] any , folderID int64 ) error {
2021-09-20 03:58:24 -05:00
return nil
}
2021-05-12 01:48:17 -05:00
type mockLibraryElementService struct {
}
2023-09-06 04:16:10 -05:00
func ( l * mockLibraryElementService ) CreateElement ( c context . Context , signedInUser identity . Requester , cmd model . CreateLibraryElementCommand ) ( model . LibraryElementDTO , error ) {
2023-02-01 10:32:05 -06:00
return model . LibraryElementDTO { } , nil
2021-09-20 03:58:24 -05:00
}
// GetElement gets an element from a UID.
2023-09-06 04:16:10 -05:00
func ( l * mockLibraryElementService ) GetElement ( c context . Context , signedInUser identity . Requester , cmd model . GetLibraryElementCommand ) ( model . LibraryElementDTO , error ) {
2023-02-01 10:32:05 -06:00
return model . LibraryElementDTO { } , nil
2021-05-12 01:48:17 -05:00
}
// GetElementsForDashboard gets all connected elements for a specific dashboard.
2023-02-01 10:32:05 -06:00
func ( l * mockLibraryElementService ) GetElementsForDashboard ( c context . Context , dashboardID int64 ) ( map [ string ] model . LibraryElementDTO , error ) {
return map [ string ] model . LibraryElementDTO { } , nil
2021-05-12 01:48:17 -05:00
}
// ConnectElementsToDashboard connects elements to a specific dashboard.
2023-09-06 04:16:10 -05:00
func ( l * mockLibraryElementService ) ConnectElementsToDashboard ( c context . Context , signedInUser identity . Requester , elementUIDs [ ] string , dashboardID int64 ) error {
2021-05-12 01:48:17 -05:00
return nil
}
// DisconnectElementsFromDashboard disconnects elements from a specific dashboard.
2021-09-27 02:04:36 -05:00
func ( l * mockLibraryElementService ) DisconnectElementsFromDashboard ( c context . Context , dashboardID int64 ) error {
2021-05-12 01:48:17 -05:00
return nil
}
// DeleteLibraryElementsInFolder deletes all elements for a specific folder.
2023-09-06 04:16:10 -05:00
func ( l * mockLibraryElementService ) DeleteLibraryElementsInFolder ( c context . Context , signedInUser identity . Requester , folderUID string ) error {
2021-05-12 01:48:17 -05:00
return nil
}