IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2026-09-05 04:40:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

A11y: Fix fastpass issues for /admin/* pages (#39435)

Browse Source 
* A11y: Fix fastpass issues for /admin/* pages
See #39429
This commit is contained in:
kay delaney
2021-09-22 21:23:54 +01:00
committed by GitHub
parent 1c64f7d3ff
commit 00dad0f4e8
6 changed files with 39 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/app/features/users/UsersTable.tsx
+9 -2
View File
@@ -35,7 +35,7 @@ const UsersTable: FC<Props> = (props) => {
return (
<tr key={`${user.userId}-${index}`}>
<td className="width-2 text-center">
<img className="filter-table__avatar" src={user.avatarUrl} />
<img className="filter-table__avatar" src={user.avatarUrl} alt="User avatar" />
</td>
<td className="max-width-6">
<span className="ellipsis" title={user.login}>
@@ -57,6 +57,7 @@ const UsersTable: FC<Props> = (props) => {
<td className="width-8">
<OrgRolePicker
aria-label="Role"
value={user.role}
disabled={!canUpdateRole}
onChange={(newRole) => onRoleChange(newRole, user)}
@@ -65,7 +66,13 @@ const UsersTable: FC<Props> = (props) => {
{canRemoveFromOrg && (
<td>
<Button size="sm" variant="destructive" onClick={() => setShowRemoveModal(user.login)} icon="times" />
<Button
size="sm"
variant="destructive"
onClick={() => setShowRemoveModal(user.login)}
icon="times"
aria-label="Delete user"
/>
<ConfirmModal
body={`Are you sure you want to delete user ${user.login}?`}
confirmText="Delete"
public/app/features/users/__snapshots__/UsersTable.test.tsx.snap
+18
View File
@@ -74,6 +74,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -115,6 +116,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -122,6 +124,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"
@@ -144,6 +147,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -185,6 +189,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -192,6 +197,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"
@@ -214,6 +220,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -255,6 +262,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -262,6 +270,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"
@@ -284,6 +293,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -325,6 +335,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -332,6 +343,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"
@@ -354,6 +366,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -395,6 +408,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -402,6 +416,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"
@@ -424,6 +439,7 @@ exports[`Render should render users table 1`] = `
className="width-2 text-center"
>
<img
alt="User avatar"
className="filter-table__avatar"
src="url/to/avatar"
/>
@@ -465,6 +481,7 @@ exports[`Render should render users table 1`] = `
className="width-8"
>
<OrgRolePicker
aria-label="Role"
disabled={false}
onChange={[Function]}
value="Admin"
@@ -472,6 +489,7 @@ exports[`Render should render users table 1`] = `
</td>
<td>
<Button
aria-label="Delete user"
icon="times"
onClick={[Function]}
size="sm"