IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Remove disablePrometheusExemplarSampling feature toggle (#81579)

Browse Source 
remove disablePrometheusExemplarSampling ft
This commit is contained in:
ismail simsek 2024-01-30 17:00:04 +01:00 committed by GitHub
parent 6d582858f7
commit 0139ac205d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
View File

@ -31,7 +31,6 @@ Some features are enabled by default. You can disable these feature by setting t
| `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | Yes | | `redshiftAsyncQueryDataSupport` | Enable async query data support for Redshift | Yes |
| `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | Yes | | `athenaAsyncQueryDataSupport` | Enable async query data support for Athena | Yes |
| `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle | Yes | | `nestedFolderPicker` | Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle | Yes |
| `disablePrometheusExemplarSampling` | Disable Prometheus exemplar sampling | |
| `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | Yes | | `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | Yes |
| `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | Yes | | `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | Yes |
| `prometheusMetricEncyclopedia` | Adds the metrics explorer component to the Prometheus query builder as an option in metric select | Yes | | `prometheusMetricEncyclopedia` | Adds the metrics explorer component to the Prometheus query builder as an option in metric select | Yes |

1
packages/grafana-data/src/types/featureToggles.gen.ts
View File

@ -53,7 +53,6 @@ export interface FeatureToggles {
accessControlOnCall?: boolean; accessControlOnCall?: boolean;
nestedFolders?: boolean; nestedFolders?: boolean;
nestedFolderPicker?: boolean; nestedFolderPicker?: boolean;
disablePrometheusExemplarSampling?: boolean;
alertingBacktesting?: boolean; alertingBacktesting?: boolean;
editPanelCSVDragAndDrop?: boolean; editPanelCSVDragAndDrop?: boolean;
alertingNoNormalState?: boolean; alertingNoNormalState?: boolean;

8
pkg/services/featuremgmt/registry.go
View File

@ -303,14 +303,6 @@ var (
AllowSelfServe: true, AllowSelfServe: true,
Created: time.Date(2023, time.July, 24, 12, 0, 0, 0, time.UTC), Created: time.Date(2023, time.July, 24, 12, 0, 0, 0, time.UTC),
}, },
{
Name: "disablePrometheusExemplarSampling",
Description: "Disable Prometheus exemplar sampling",
Stage: FeatureStageGeneralAvailability,
Owner: grafanaObservabilityMetricsSquad,
AllowSelfServe: true,
Created: time.Date(2022, time.December, 19, 12, 0, 0, 0, time.UTC),
},
{ {
Name: "alertingBacktesting", Name: "alertingBacktesting",
Description: "Rule backtesting API for alerting", Description: "Rule backtesting API for alerting",

1
pkg/services/featuremgmt/toggles_gen.csv
View File

@ -34,7 +34,6 @@ mysqlAnsiQuotes,experimental,@grafana/backend-platform,2022-10-12,false,false,fa
accessControlOnCall,preview,@grafana/identity-access-team,2022-10-19,false,false,false accessControlOnCall,preview,@grafana/identity-access-team,2022-10-19,false,false,false
nestedFolders,preview,@grafana/backend-platform,2022-10-22,false,false,false nestedFolders,preview,@grafana/backend-platform,2022-10-22,false,false,false
nestedFolderPicker,GA,@grafana/grafana-frontend-platform,2023-07-24,false,false,true nestedFolderPicker,GA,@grafana/grafana-frontend-platform,2023-07-24,false,false,true
disablePrometheusExemplarSampling,GA,@grafana/observability-metrics,2022-12-19,false,false,false
alertingBacktesting,experimental,@grafana/alerting-squad,2022-10-20,false,false,false alertingBacktesting,experimental,@grafana/alerting-squad,2022-10-20,false,false,false
editPanelCSVDragAndDrop,experimental,@grafana/grafana-bi-squad,2022-12-20,false,false,true editPanelCSVDragAndDrop,experimental,@grafana/grafana-bi-squad,2022-12-20,false,false,true
alertingNoNormalState,preview,@grafana/alerting-squad,2023-01-14,false,false,false alertingNoNormalState,preview,@grafana/alerting-squad,2023-01-14,false,false,false

1 Name Stage Owner Created requiresDevMode RequiresRestart FrontendOnly
34 accessControlOnCall preview @grafana/identity-access-team 2022-10-19 false false false
35 nestedFolders preview @grafana/backend-platform 2022-10-22 false false false
36 nestedFolderPicker GA @grafana/grafana-frontend-platform 2023-07-24 false false true
disablePrometheusExemplarSampling GA @grafana/observability-metrics 2022-12-19 false false false
37 alertingBacktesting experimental @grafana/alerting-squad 2022-10-20 false false false
38 editPanelCSVDragAndDrop experimental @grafana/grafana-bi-squad 2022-12-20 false false true
39 alertingNoNormalState preview @grafana/alerting-squad 2023-01-14 false false false

4
pkg/services/featuremgmt/toggles_gen.go
View File

@ -147,10 +147,6 @@ const (
// Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle // Enables the new folder picker to work with nested folders. Requires the nestedFolders feature toggle
FlagNestedFolderPicker = "nestedFolderPicker" FlagNestedFolderPicker = "nestedFolderPicker"
// FlagDisablePrometheusExemplarSampling
// Disable Prometheus exemplar sampling
FlagDisablePrometheusExemplarSampling = "disablePrometheusExemplarSampling"
// FlagAlertingBacktesting // FlagAlertingBacktesting
// Rule backtesting API for alerting // Rule backtesting API for alerting
FlagAlertingBacktesting = "alertingBacktesting" FlagAlertingBacktesting = "alertingBacktesting"

6
pkg/tsdb/prometheus/querydata/request.go
View File

@ -75,10 +75,6 @@ func New(
// standard deviation sampler is the default for backwards compatibility // standard deviation sampler is the default for backwards compatibility
exemplarSampler := exemplar.NewStandardDeviationSampler exemplarSampler := exemplar.NewStandardDeviationSampler
if features.IsEnabledGlobally(featuremgmt.FlagDisablePrometheusExemplarSampling) {
exemplarSampler = exemplar.NewNoOpSampler
}
return &QueryData{ return &QueryData{
intervalCalculator: intervalv2.NewCalculator(), intervalCalculator: intervalv2.NewCalculator(),
tracer: tracing.DefaultTracer(), tracer: tracing.DefaultTracer(),
@ -87,8 +83,8 @@ func New(
TimeInterval: timeInterval, TimeInterval: timeInterval,
ID: settings.ID, ID: settings.ID,
URL: settings.URL, URL: settings.URL,
enableDataplane: features.IsEnabledGlobally(featuremgmt.FlagPrometheusDataplane),
exemplarSampler: exemplarSampler, exemplarSampler: exemplarSampler,
enableDataplane: features.IsEnabledGlobally(featuremgmt.FlagPrometheusDataplane),
enableScope: features.IsEnabledGlobally(featuremgmt.FlagPromQLScope), enableScope: features.IsEnabledGlobally(featuremgmt.FlagPromQLScope),
}, nil }, nil
} }