mirror of
https://github.com/grafana/grafana.git
synced 2025-02-25 18:55:37 -06:00
Alerting: Add GetFullState method to FileStore (#78701)
* Alerting: Add GetFullState method to FileStore * make tests compile, create stateStore in NewAlertmanager * return errors instead of logging, accept an arbitrary number of strings * make NewAlertmanager() accept a stateStore
This commit is contained in:
@@ -8,6 +8,7 @@ import (
|
||||
"path/filepath"
|
||||
|
||||
alertingNotify "github.com/grafana/alerting/notify"
|
||||
"github.com/prometheus/alertmanager/cluster/clusterpb"
|
||||
|
||||
"github.com/grafana/grafana/pkg/infra/kvstore"
|
||||
"github.com/grafana/grafana/pkg/infra/log"
|
||||
@@ -62,6 +63,45 @@ func (fileStore *FileStore) FilepathFor(ctx context.Context, filename string) (s
|
||||
return fileStore.pathFor(filename), err
|
||||
}
|
||||
|
||||
// GetFullState receives a list of keys, looks for the corresponding values in the kvstore,
|
||||
// and returns a base64-encoded protobuf message containing those key-value pairs.
|
||||
// That base64-encoded string represents the Alertmanager's internal state.
|
||||
func (fileStore *FileStore) GetFullState(ctx context.Context, filenames ...string) (string, error) {
|
||||
all, err := fileStore.kv.GetAll(ctx)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
|
||||
keys, ok := all[fileStore.orgID]
|
||||
if !ok {
|
||||
return "", fmt.Errorf("no values for org %d", fileStore.orgID)
|
||||
}
|
||||
|
||||
var parts []clusterpb.Part
|
||||
for _, f := range filenames {
|
||||
v, ok := keys[f]
|
||||
if !ok {
|
||||
return "", fmt.Errorf("no value found for key %q", f)
|
||||
}
|
||||
|
||||
b, err := decode(v)
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("error decoding value for key %q", f)
|
||||
}
|
||||
parts = append(parts, clusterpb.Part{Key: f, Data: b})
|
||||
}
|
||||
|
||||
fs := clusterpb.FullState{
|
||||
Parts: parts,
|
||||
}
|
||||
b, err := fs.Marshal()
|
||||
if err != nil {
|
||||
return "", fmt.Errorf("error marshaling full state: %w", err)
|
||||
}
|
||||
|
||||
return encode(b), nil
|
||||
}
|
||||
|
||||
// Persist takes care of persisting the binary representation of internal state to the database as a base64 encoded string.
|
||||
func (fileStore *FileStore) Persist(ctx context.Context, filename string, st alertingNotify.State) (int64, error) {
|
||||
var size int64
|
||||
|
||||
@@ -2,10 +2,12 @@ package notifier
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/base64"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/prometheus/alertmanager/cluster/clusterpb"
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"github.com/grafana/grafana/pkg/services/ngalert/tests/fakes"
|
||||
@@ -74,6 +76,52 @@ func TestFileStore_FilepathFor(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestFileStore_GetFullState(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
|
||||
t.Run("empty store", func(tt *testing.T) {
|
||||
store := fakes.NewFakeKVStore(t)
|
||||
fs := NewFileStore(1, store, workingDir)
|
||||
_, err := fs.GetFullState(ctx, "silences", "notifications")
|
||||
require.NotNil(tt, err)
|
||||
require.Equal(tt, "no values for org 1", err.Error())
|
||||
})
|
||||
|
||||
t.Run("no values for key", func(tt *testing.T) {
|
||||
store := fakes.NewFakeKVStore(t)
|
||||
require.NoError(t, store.Set(ctx, 1, "alertmanager", "test-key", "test-value"))
|
||||
fs := NewFileStore(1, store, workingDir)
|
||||
_, err := fs.GetFullState(ctx, "silences")
|
||||
require.NotNil(tt, err)
|
||||
require.Equal(tt, "no value found for key \"silences\"", err.Error())
|
||||
})
|
||||
|
||||
t.Run("non-empty values", func(tt *testing.T) {
|
||||
store := fakes.NewFakeKVStore(t)
|
||||
silences := []byte("test-silences")
|
||||
nflog := []byte("test-notifications")
|
||||
require.NoError(t, store.Set(ctx, 1, "alertmanager", "silences", base64.StdEncoding.EncodeToString(silences)))
|
||||
require.NoError(t, store.Set(ctx, 1, "alertmanager", "notifications", base64.StdEncoding.EncodeToString(nflog)))
|
||||
|
||||
state := clusterpb.FullState{
|
||||
Parts: []clusterpb.Part{
|
||||
{Key: "silences", Data: silences},
|
||||
{Key: "notifications", Data: nflog},
|
||||
},
|
||||
}
|
||||
b, err := state.Marshal()
|
||||
require.NoError(t, err)
|
||||
|
||||
encodedFullState := base64.StdEncoding.EncodeToString(b)
|
||||
|
||||
fs := NewFileStore(1, store, workingDir)
|
||||
|
||||
got, err := fs.GetFullState(ctx, "silences", "notifications")
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, encodedFullState, got)
|
||||
})
|
||||
}
|
||||
|
||||
func TestFileStore_Persist(t *testing.T) {
|
||||
store := fakes.NewFakeKVStore(t)
|
||||
state := &fakeState{data: "something to marshal"}
|
||||
|
||||
Reference in New Issue
Block a user