Elasticsearch: Remove enableElasticsearchBackendQuerying feature toggle (#88668)

* wip

* Fix newly introduced any

* Remove toggle

* Remove unused code in LegacyQueryRunner

pkg/services/featuremgmt/registry.go

@@ -413,14 +413,6 @@ var (
 			Owner:             grafanaDashboardsSquad,
 			HideFromAdminPage: true, // Non-feature, used to test out a bug fix that impacts the performance of template variables.
 		},
-		{
-			Name:           "enableElasticsearchBackendQuerying",
-			Description:    "Enable the processing of queries and responses in the Elasticsearch data source through backend",
-			Stage:          FeatureStageGeneralAvailability,
-			Owner:          grafanaObservabilityLogsSquad,
-			Expression:     "true", // enabled by default
-			AllowSelfServe: true,
-		},
 		{
 			Name:         "faroDatasourceSelector",
 			Description:  "Enable the data source selector within the Frontend Apps section of the Frontend Observability",

pkg/services/featuremgmt/toggles_gen.csv

@@ -54,7 +54,6 @@ alertStateHistoryLokiOnly,experimental,@grafana/alerting-squad,false,false,false
 unifiedRequestLog,experimental,@grafana/grafana-backend-group,false,false,false
 renderAuthJWT,preview,@grafana/grafana-as-code,false,false,false
 refactorVariablesTimeRange,preview,@grafana/dashboards-squad,false,false,false
-enableElasticsearchBackendQuerying,GA,@grafana/observability-logs,false,false,false
 faroDatasourceSelector,preview,@grafana/app-o11y,false,false,true
 enableDatagridEditing,preview,@grafana/dataviz-squad,false,false,true
 extraThemes,experimental,@grafana/grafana-frontend-platform,false,false,true

pkg/services/featuremgmt/toggles_gen.go

@@ -227,10 +227,6 @@ const (
 	// Refactor time range variables flow to reduce number of API calls made when query variables are chained
 	FlagRefactorVariablesTimeRange = "refactorVariablesTimeRange"
 
-	// FlagEnableElasticsearchBackendQuerying
-	// Enable the processing of queries and responses in the Elasticsearch data source through backend
-	FlagEnableElasticsearchBackendQuerying = "enableElasticsearchBackendQuerying"
-
 	// FlagFaroDatasourceSelector
 	// Enable the data source selector within the Frontend Apps section of the Frontend Observability
 	FlagFaroDatasourceSelector = "faroDatasourceSelector"

pkg/services/featuremgmt/toggles_gen.json

@@ -2179,7 +2179,8 @@
       "metadata": {
         "name": "enableElasticsearchBackendQuerying",
         "resourceVersion": "1717578796182",
-        "creationTimestamp": "2024-06-05T09:13:16Z"
+        "creationTimestamp": "2024-06-05T09:13:16Z",
+        "deletionTimestamp": "2024-06-05T14:07:54Z"
       },
       "spec": {
         "description": "Enable the processing of queries and responses in the Elasticsearch data source through backend",

pkg/tsdb/elasticsearch/client/index_pattern_test.go

@@ -90,6 +90,10 @@ func TestIndexPattern(t *testing.T) {
 			require.Equal(t, indices[0], "data-2018-moredata-05.15")
 		})
 
+		indexPatternScenario(t, noInterval, "", timeRange, func(indices []string) {
+			require.Len(t, indices, 0)
+		})
+
 		t.Run("Should return 01 week", func(t *testing.T) {
 			from = time.Date(2018, 1, 15, 17, 50, 0, 0, time.UTC)
 			to = time.Date(2018, 1, 15, 17, 55, 0, 0, time.UTC)