IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-02-25 18:55:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't remove DWARF info from Go binaries in dev (#100328)

Browse Source 
Only ask the linker to strip DWARF information if we're not in
dev, to avoid seeing stuff like this when using delve:

    ~ $ dlv attach $(pgrep grafana)
    (dlv) l main.main
    Command failed: location "main.main" not found

After this change:

    ~ $ dlv attach $(pgrep grafana)
    Type 'help' for list of commands.
    (dlv) l main.main
    Showing /home/justin/code/grafana/pkg/cmd/grafana/main.go:23 (PC: 0xac93533)
        18: var commit = gcli.DefaultCommitValue
        19: var enterpriseCommit = gcli.DefaultCommitValue
        20: var buildBranch = "main"
        21: var buildstamp string
        22:
        23: func main() {
        24:         app := MainApp()
        25:
        26:         if err := app.Run(os.Args); err != nil {
This commit is contained in:
beejeebus 2025-02-10 08:43:31 -05:00 committed by GitHub
parent 68700e3d7d
commit 02caf915a5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/build/cmd.go
View File

@ -243,7 +243,16 @@ func ldflags(opts BuildOpts) (string, error) {
buildBranch = v
}
var b bytes.Buffer
b.WriteString("-w")
if !opts.isDev {
// Only ask the linker to strip DWARF information if we're not in
// dev, to avoid seeing stuff like this when using delve:
//
// ~ $ dlv attach $(pgrep grafana)
// (dlv) l main.main
// Command failed: location "main.main" not found
//
b.WriteString("-w")
}
b.WriteString(fmt.Sprintf(" -X main.version=%s", opts.version))
b.WriteString(fmt.Sprintf(" -X main.commit=%s", commitSha))
if enterpriseCommitSha != "" {