IntenseWebs/grafana
3
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2024-11-25 10:20:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

PasswordField: Fix button role (#37816)

Browse Source 
* Fix button role

* Fix tests
This commit is contained in:
Alex Khomenko 2021-08-12 11:46:33 +03:00 committed by GitHub
parent e4779cfb4f
commit 059ef4ee9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
public/app/core/components/PasswordField/PasswordField.test.tsx
View File

@ -8,15 +8,15 @@ describe('PasswordField', () => {
placeholder: 'enter password',
'data-testid': 'password-field',
};
it('should renders correctly', () => {
it('should render correctly', () => {
render(<PasswordField {...props} />);
expect(screen.getByTestId('password-field')).toBeInTheDocument();
expect(screen.getByRole('button')).toBeInTheDocument();
expect(screen.getByRole('switch', { name: 'Show password' })).toBeInTheDocument();
});
it('should able to show password value if clicked on password-reveal icon', () => {
render(<PasswordField {...props} />);
expect(screen.getByTestId('password-field')).toHaveProperty('type', 'password');
fireEvent.click(screen.getByRole('button'));
fireEvent.click(screen.getByRole('switch', { name: 'Show password' }));
expect(screen.getByTestId('password-field')).toHaveProperty('type', 'text');
});
});

2
public/app/core/components/PasswordField/PasswordField.tsx
View File

@ -29,7 +29,7 @@ export const PasswordField: FC<Props> = React.forwardRef<HTMLInputElement, Props
name={showPassword ? 'eye-slash' : 'eye'}
type="button"
aria-controls={id}
aria-role="switch"
role="switch"
aria-checked={showPassword}
aria-label="Show password"
onClick={() => {