Zipkin: support running queries with keyboard shortcut (#37960)

* Zipkin: replace input field with QueryField component

* Fix failing tests

* Remove console.log

* Partially migrate test to react

* Zipkin: finish migration from enzyme to react

* Remove comments
This commit is contained in:
Olof Bourghardt
2021-08-24 09:52:34 +02:00
committed by GitHub
parent ccab9611cb
commit 05b0df2254
3 changed files with 24 additions and 28 deletions

View File

@@ -1,16 +1,16 @@
import { ButtonCascader, CascaderOption } from '@grafana/ui'; import { CascaderOption } from '@grafana/ui';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, renderHook } from '@testing-library/react-hooks';
import { shallow } from 'enzyme'; import { render, screen } from '@testing-library/react';
import React from 'react'; import React from 'react';
import { ZipkinDatasource } from './datasource'; import { ZipkinDatasource } from './datasource';
import { QueryField, useLoadOptions, useServices } from './QueryField'; import { ZipkinQueryField, useLoadOptions, useServices } from './QueryField';
import { ZipkinQuery } from './types'; import { ZipkinQuery } from './types';
describe('QueryField', () => { describe('QueryField', () => {
it('renders properly', () => { it('renders properly', () => {
const ds = {} as ZipkinDatasource; const ds = {} as ZipkinDatasource;
const wrapper = shallow( render(
<QueryField <ZipkinQueryField
history={[]} history={[]}
datasource={ds} datasource={ds}
query={{ query: '1234' } as ZipkinQuery} query={{ query: '1234' } as ZipkinQuery}
@@ -19,9 +19,8 @@ describe('QueryField', () => {
/> />
); );
expect(wrapper.find(ButtonCascader).length).toBe(1); expect(screen.getByText(/1234/i)).toBeInTheDocument();
expect(wrapper.find('input').length).toBe(1); expect(screen.getByText(/Traces/i)).toBeInTheDocument();
expect(wrapper.find('input').props().value).toBe('1234');
}); });
}); });
@@ -52,7 +51,6 @@ describe('useLoadOptions', () => {
return Promise.resolve(['span1', 'span2']); return Promise.resolve(['span1', 'span2']);
} }
console.log({ url });
if (url === '/api/v2/traces' && params?.serviceName === 'service1' && params?.spanName === 'span1') { if (url === '/api/v2/traces' && params?.serviceName === 'service1' && params?.spanName === 'span1') {
return Promise.resolve([[{ name: 'trace1', duration: 10_000, traceId: 'traceId1' }]]); return Promise.resolve([[{ name: 'trace1', duration: 10_000, traceId: 'traceId1' }]]);
} }

View File

@@ -1,6 +1,5 @@
import { css } from '@emotion/css'; import { css } from '@emotion/css';
import { ExploreQueryFieldProps } from '@grafana/data'; import { ExploreQueryFieldProps } from '@grafana/data';
import { selectors } from '@grafana/e2e-selectors';
import { import {
ButtonCascader, ButtonCascader,
CascaderOption, CascaderOption,
@@ -9,6 +8,7 @@ import {
InlineFieldRow, InlineFieldRow,
RadioButtonGroup, RadioButtonGroup,
useTheme2, useTheme2,
QueryField,
} from '@grafana/ui'; } from '@grafana/ui';
import { notifyApp } from 'app/core/actions'; import { notifyApp } from 'app/core/actions';
import { createErrorNotification } from 'app/core/copy/appNotification'; import { createErrorNotification } from 'app/core/copy/appNotification';
@@ -23,7 +23,7 @@ import { ZipkinQuery, ZipkinQueryType, ZipkinSpan } from './types';
type Props = ExploreQueryFieldProps<ZipkinDatasource, ZipkinQuery>; type Props = ExploreQueryFieldProps<ZipkinDatasource, ZipkinQuery>;
export const QueryField = ({ query, onChange, onRunQuery, datasource }: Props) => { export const ZipkinQueryField = ({ query, onChange, onRunQuery, datasource }: Props) => {
const serviceOptions = useServices(datasource); const serviceOptions = useServices(datasource);
const theme = useTheme2(); const theme = useTheme2();
const { onLoadOptions, allOptions } = useLoadOptions(datasource); const { onLoadOptions, allOptions } = useLoadOptions(datasource);
@@ -39,6 +39,11 @@ export const QueryField = ({ query, onChange, onRunQuery, datasource }: Props) =
[onChange, onRunQuery, query] [onChange, onRunQuery, query]
); );
const onChangeQuery = (value: string) => {
const nextQuery = { ...query, query: value };
onChange(nextQuery);
};
let cascaderOptions = useMapToCascaderOptions(serviceOptions, allOptions); let cascaderOptions = useMapToCascaderOptions(serviceOptions, allOptions);
return ( return (
@@ -78,21 +83,14 @@ export const QueryField = ({ query, onChange, onRunQuery, datasource }: Props) =
Traces Traces
</ButtonCascader> </ButtonCascader>
</div> </div>
<div className="gf-form gf-form--grow flex-shrink-1"> <div className="gf-form gf-form--grow flex-shrink-1 min-width-15">
<div className="slate-query-field__wrapper"> <QueryField
<div className="slate-query-field" aria-label={selectors.components.QueryField.container}> query={query.query}
<input onChange={onChangeQuery}
style={{ width: '100%' }} onRunQuery={onRunQuery}
value={query.query || ''} placeholder={'Insert Trace ID (run with Shift+Enter)'}
onChange={(e) => portalOrigin="zipkin"
onChange({ />
...query,
query: e.currentTarget.value,
})
}
/>
</div>
</div>
</div> </div>
</div> </div>
)} )}

View File

@@ -1,8 +1,8 @@
import { DataSourcePlugin } from '@grafana/data'; import { DataSourcePlugin } from '@grafana/data';
import { ZipkinDatasource } from './datasource'; import { ZipkinDatasource } from './datasource';
import { QueryField } from './QueryField'; import { ZipkinQueryField } from './QueryField';
import { ConfigEditor } from './ConfigEditor'; import { ConfigEditor } from './ConfigEditor';
export const plugin = new DataSourcePlugin(ZipkinDatasource) export const plugin = new DataSourcePlugin(ZipkinDatasource)
.setConfigEditor(ConfigEditor) .setConfigEditor(ConfigEditor)
.setExploreQueryField(QueryField); .setExploreQueryField(ZipkinQueryField);