Chore: Logging improvements (#44925)

Fixing a couple bugs, adds some tests and hopefully decrease 
lock contention when logging.
Switching from using sync.RWMutex to go-kit SwapLogger.
Fixes bug when creating a new logger from an existing one that 
screwed up the keyvals and/or lost the logger name. 

Ref #44681
This commit is contained in:
Marcus Efraimsson
2022-02-07 16:00:08 +01:00
committed by GitHub
parent f4b13f7d04
commit 05ea825c76
7 changed files with 187 additions and 99 deletions

View File

@@ -42,11 +42,11 @@ func logSentryEventScenario(t *testing.T, desc string, event frontendlogging.Fro
}))
origHandler := frontendLogger.GetLogger()
frontendLogger.SetLogger(level.NewFilter(newfrontendLogger, level.AllowInfo()))
frontendLogger.Swap(level.NewFilter(newfrontendLogger, level.AllowInfo()))
sourceMapReads := []SourceMapReadRecord{}
t.Cleanup(func() {
frontendLogger.SetLogger(origHandler)
frontendLogger.Swap(origHandler)
})
sc := setupScenarioContext(t, "/log")